Re: [PATCH 3/5] bfq: Check kstrtoul() return value

2017-09-01 Thread weiping zhang
> Sorry but I do not like this proposal because: > * If invalid input is provided writing into a sysfs attribute should fail > instead of ignoring the invalid input silently. > * simple_strtoul() is considered obsolete and must not be used in new code. > From include/linux/kernel.h: > > /*

Re: [PATCH 3/5] bfq: Check kstrtoul() return value

2017-09-01 Thread Bart Van Assche
On Sat, 2017-09-02 at 01:37 +0800, weiping zhang wrote: > 2017-09-02 1:14 GMT+08:00 Paolo Valente : > > Il giorno 30 ago 2017, alle ore 20:42, Bart Van Assche > > ha scritto: > > > > > > Make sysfs writes fail for invalid numbers instead of

Re: [PATCH 3/5] bfq: Check kstrtoul() return value

2017-09-01 Thread weiping zhang
2017-09-02 1:14 GMT+08:00 Paolo Valente : > >> Il giorno 30 ago 2017, alle ore 20:42, Bart Van Assche >> ha scritto: >> >> Make sysfs writes fail for invalid numbers instead of storing >> uninitialized data copied from the stack. This patch

Re: [PATCH 3/5] bfq: Check kstrtoul() return value

2017-09-01 Thread Paolo Valente
> Il giorno 30 ago 2017, alle ore 20:42, Bart Van Assche > ha scritto: > > Make sysfs writes fail for invalid numbers instead of storing > uninitialized data copied from the stack. This patch removes > all uninitialized_var() occurrences from the BFQ source code. > >

[PATCH 3/5] bfq: Check kstrtoul() return value

2017-08-30 Thread Bart Van Assche
Make sysfs writes fail for invalid numbers instead of storing uninitialized data copied from the stack. This patch removes all uninitialized_var() occurrences from the BFQ source code. Signed-off-by: Bart Van Assche Cc: Paolo Valente ---