Re: [PATCH 4/7] blk-mq: Avoid that request processing stalls when sharing tags

2017-12-01 Thread Ming Lei
On Sat, Dec 02, 2017 at 01:05:05AM +, Bart Van Assche wrote: > On Sat, 2017-12-02 at 09:00 +0800, Ming Lei wrote: > > On Sat, Dec 02, 2017 at 12:48:51AM +, Bart Van Assche wrote: > > > Further tests have shown that the lockup I referred to does not occur > > > before commit > > >

Re: [PATCH 4/7] blk-mq: Avoid that request processing stalls when sharing tags

2017-12-01 Thread Ming Lei
On Sat, Dec 02, 2017 at 01:05:05AM +, Bart Van Assche wrote: > On Sat, 2017-12-02 at 09:00 +0800, Ming Lei wrote: > > On Sat, Dec 02, 2017 at 12:48:51AM +, Bart Van Assche wrote: > > > Further tests have shown that the lockup I referred to does not occur > > > before commit > > >

Re: [PATCH 4/7] blk-mq: Avoid that request processing stalls when sharing tags

2017-12-01 Thread Bart Van Assche
On Sat, 2017-12-02 at 09:00 +0800, Ming Lei wrote: > On Sat, Dec 02, 2017 at 12:48:51AM +, Bart Van Assche wrote: > > Further tests have shown that the lockup I referred to does not occur > > before commit > > b347689ffbca but that it occurs with b347689ffbca. > > Then you need to root cause

Re: [PATCH 4/7] blk-mq: Avoid that request processing stalls when sharing tags

2017-12-01 Thread Ming Lei
On Sat, Dec 02, 2017 at 12:48:51AM +, Bart Van Assche wrote: > On Sat, 2017-12-02 at 08:36 +0800, Ming Lei wrote: > > On Fri, Dec 01, 2017 at 07:52:14PM +, Bart Van Assche wrote: > > > On Fri, 2017-12-01 at 10:58 +0800, Ming Lei wrote: > > > > On Thu, Nov 30, 2017 at 04:08:45PM -0800, Bart

Re: [PATCH 4/7] blk-mq: Avoid that request processing stalls when sharing tags

2017-12-01 Thread Bart Van Assche
On Sat, 2017-12-02 at 08:36 +0800, Ming Lei wrote: > On Fri, Dec 01, 2017 at 07:52:14PM +, Bart Van Assche wrote: > > On Fri, 2017-12-01 at 10:58 +0800, Ming Lei wrote: > > > On Thu, Nov 30, 2017 at 04:08:45PM -0800, Bart Van Assche wrote: > > > > blk_mq_dispatch_rq_list() is called. Make sure

Re: [PATCH 4/7] blk-mq: Avoid that request processing stalls when sharing tags

2017-12-01 Thread Ming Lei
On Fri, Dec 01, 2017 at 07:52:14PM +, Bart Van Assche wrote: > On Fri, 2017-12-01 at 10:58 +0800, Ming Lei wrote: > > On Thu, Nov 30, 2017 at 04:08:45PM -0800, Bart Van Assche wrote: > > > blk_mq_sched_mark_restart_hctx() must be called before > > > > Could you please describe the theory on

Re: [PATCH 4/7] blk-mq: Avoid that request processing stalls when sharing tags

2017-12-01 Thread Bart Van Assche
On Fri, 2017-12-01 at 10:58 +0800, Ming Lei wrote: > On Thu, Nov 30, 2017 at 04:08:45PM -0800, Bart Van Assche wrote: > > blk_mq_sched_mark_restart_hctx() must be called before > > Could you please describe the theory on commit log? Like, why is it > a must? and what is the issue to be fixed?

Re: [PATCH 4/7] blk-mq: Avoid that request processing stalls when sharing tags

2017-11-30 Thread Ming Lei
On Thu, Nov 30, 2017 at 04:08:45PM -0800, Bart Van Assche wrote: > blk_mq_sched_mark_restart_hctx() must be called before Could you please describe the theory on commit log? Like, why is it a must? and what is the issue to be fixed? > blk_mq_dispatch_rq_list() is called. Make sure that >

[PATCH 4/7] blk-mq: Avoid that request processing stalls when sharing tags

2017-11-30 Thread Bart Van Assche
blk_mq_sched_mark_restart_hctx() must be called before blk_mq_dispatch_rq_list() is called. Make sure that BLK_MQ_S_SCHED_RESTART is set before any blk_mq_dispatch_rq_list() call occurs. Fixes: commit b347689ffbca ("blk-mq-sched: improve dispatching from sw queue") Signed-off-by: Bart Van Assche