Re: [PATCH 7/8] blk-wbt: add general throttling mechanism

2016-11-09 Thread Dave Chinner
On Wed, Nov 09, 2016 at 09:07:08AM -0700, Jens Axboe wrote: > On 11/09/2016 01:40 AM, Jan Kara wrote: > >Also I'm not sure why such logic for devices with writeback cache is > >needed. Sure the disk is fast to accept writes but if that causes long > >read latencies, we should scale down the

Re: [PATCH 7/8] blk-wbt: add general throttling mechanism

2016-11-09 Thread Jens Axboe
On 11/09/2016 09:07 AM, Jens Axboe wrote: On 11/09/2016 01:40 AM, Jan Kara wrote: So for devices with write cache, you will completely drain the device before waking anybody waiting to issue new requests. Isn't it too strict? In particular may_queue() will allow new writers to issue new writes

Re: [PATCH 7/8] blk-wbt: add general throttling mechanism

2016-11-09 Thread Jens Axboe
On 11/09/2016 01:40 AM, Jan Kara wrote: So for devices with write cache, you will completely drain the device before waking anybody waiting to issue new requests. Isn't it too strict? In particular may_queue() will allow new writers to issue new writes once we drop below the limit so it can

Re: [PATCH 7/8] blk-wbt: add general throttling mechanism

2016-11-08 Thread Jens Axboe
On Tue, Nov 08 2016, Jan Kara wrote: > On Tue 01-11-16 15:08:50, Jens Axboe wrote: > > We can hook this up to the block layer, to help throttle buffered > > writes. > > > > wbt registers a few trace points that can be used to track what is > > happening in the system: > > > > wbt_lat: 259:0:

Re: [PATCH 7/8] blk-wbt: add general throttling mechanism

2016-11-08 Thread Jan Kara
On Tue 01-11-16 15:08:50, Jens Axboe wrote: > We can hook this up to the block layer, to help throttle buffered > writes. > > wbt registers a few trace points that can be used to track what is > happening in the system: > > wbt_lat: 259:0: latency 2446318 > wbt_stat: 259:0: rmean=2446318,

[PATCH 7/8] blk-wbt: add general throttling mechanism

2016-11-01 Thread Jens Axboe
We can hook this up to the block layer, to help throttle buffered writes. wbt registers a few trace points that can be used to track what is happening in the system: wbt_lat: 259:0: latency 2446318 wbt_stat: 259:0: rmean=2446318, rmin=2446318, rmax=2446318, rsamples=1,

[PATCH 7/8] blk-wbt: add general throttling mechanism

2016-10-26 Thread Jens Axboe
We can hook this up to the block layer, to help throttle buffered writes. wbt registers a few trace points that can be used to track what is happening in the system: wbt_lat: 259:0: latency 2446318 wbt_stat: 259:0: rmean=2446318, rmin=2446318, rmax=2446318, rsamples=1,