[PATCH 7/9] xfs: add support for passing in write hints for buffered writes

2017-06-26 Thread Jens Axboe
Reviewed-by: Andreas Dilger Reviewed-by: Martin K. Petersen Reviewed-by: Darrick J. Wong Signed-off-by: Jens Axboe --- fs/xfs/xfs_aops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 76b6f988e2fa..ceb124bd8f80 100644 --- a/fs/xfs/xfs_aops.c +

Re: [PATCH 7/9] xfs: add support for passing in write hints for buffered writes

2017-06-26 Thread Jens Axboe
On 06/26/2017 03:56 AM, Christoph Hellwig wrote: >> +ioend->io_bio->bi_opf |= >> write_hint_to_opf(inode_write_hint(ioend->io_inode)); > > Too long line again. > > I think simply adding an inode_hint_to_opf() flag would make the various > opencoded versions of the above call a little easier

Re: [PATCH 7/9] xfs: add support for passing in write hints for buffered writes

2017-06-26 Thread Christoph Hellwig
> + ioend->io_bio->bi_opf |= > write_hint_to_opf(inode_write_hint(ioend->io_inode)); Too long line again. I think simply adding an inode_hint_to_opf() flag would make the various opencoded versions of the above call a little easier to read.

Re: [PATCH 7/9] xfs: add support for passing in write hints for buffered writes

2017-06-20 Thread Jens Axboe
On 06/20/2017 07:35 PM, Darrick J. Wong wrote: > On Tue, Jun 20, 2017 at 06:22:04PM -0600, Jens Axboe wrote: >> Reviewed-by: Andreas Dilger >> Signed-off-by: Jens Axboe > > Looks ok to me, > Reviewed-by: Darrick J. Wong Thanks Darrick, added. -- Jens Axboe

Re: [PATCH 7/9] xfs: add support for passing in write hints for buffered writes

2017-06-20 Thread Darrick J. Wong
On Tue, Jun 20, 2017 at 06:22:04PM -0600, Jens Axboe wrote: > Reviewed-by: Andreas Dilger > Signed-off-by: Jens Axboe Looks ok to me, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_aops.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c >

[PATCH 7/9] xfs: add support for passing in write hints for buffered writes

2017-06-20 Thread Jens Axboe
Reviewed-by: Andreas Dilger Signed-off-by: Jens Axboe --- fs/xfs/xfs_aops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 76b6f988e2fa..e4d9d470402c 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -506,6 +506,7 @@ xfs_submit_ioend(

[PATCH 7/9] xfs: add support for passing in write hints for buffered writes

2017-06-19 Thread Jens Axboe
Reviewed-by: Andreas Dilger Signed-off-by: Jens Axboe --- fs/xfs/xfs_aops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 76b6f988e2fa..e4d9d470402c 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -506,6 +506,7 @@ xfs_submit_ioend(