Re: [PATCH v2] blk-mq: Make blk_mq_get_request() error path less confusing

2017-11-03 Thread Jens Axboe
On 11/03/2017 12:31 PM, Bart Van Assche wrote: > On Mon, 2017-10-16 at 16:32 -0700, Bart Van Assche wrote: >> blk_mq_get_tag() can modify data->ctx. This means that in the >> error path of blk_mq_get_request() data->ctx should be passed to >> blk_mq_put_ctx() instead of local_ctx. Note: since

Re: [PATCH v2] blk-mq: Make blk_mq_get_request() error path less confusing

2017-11-03 Thread Bart Van Assche
On Mon, 2017-10-16 at 16:32 -0700, Bart Van Assche wrote: > blk_mq_get_tag() can modify data->ctx. This means that in the > error path of blk_mq_get_request() data->ctx should be passed to > blk_mq_put_ctx() instead of local_ctx. Note: since blk_mq_put_ctx() > ignores its argument, this patch does

Re: [PATCH v2] blk-mq: Make blk_mq_get_request() error path less confusing

2017-10-17 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v2] blk-mq: Make blk_mq_get_request() error path less confusing

2017-10-17 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v2] blk-mq: Make blk_mq_get_request() error path less confusing

2017-10-17 Thread Hannes Reinecke
On 10/17/2017 01:32 AM, Bart Van Assche wrote: > blk_mq_get_tag() can modify data->ctx. This means that in the > error path of blk_mq_get_request() data->ctx should be passed to > blk_mq_put_ctx() instead of local_ctx. Note: since blk_mq_put_ctx() > ignores its argument, this patch does not change

Re: [PATCH v2] blk-mq: Make blk_mq_get_request() error path less confusing

2017-10-16 Thread Ming Lei
On Mon, Oct 16, 2017 at 04:32:26PM -0700, Bart Van Assche wrote: > blk_mq_get_tag() can modify data->ctx. This means that in the > error path of blk_mq_get_request() data->ctx should be passed to > blk_mq_put_ctx() instead of local_ctx. Note: since blk_mq_put_ctx() > ignores its argument, this

[PATCH v2] blk-mq: Make blk_mq_get_request() error path less confusing

2017-10-16 Thread Bart Van Assche
blk_mq_get_tag() can modify data->ctx. This means that in the error path of blk_mq_get_request() data->ctx should be passed to blk_mq_put_ctx() instead of local_ctx. Note: since blk_mq_put_ctx() ignores its argument, this patch does not change any functionality. References: commit 1ad43c0078b7