Re: [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On 09/14/2017 10:33 AM, Ming Lei wrote: > On Fri, Sep 15, 2017 at 12:30 AM, Jens Axboe wrote: >> On 09/14/2017 09:57 AM, Ming Lei wrote: >>> On Tue, Sep 12, 2017 at 5:27 AM, Jens Axboe wrote: On 09/11/2017 03:13 PM, Mike Snitzer wrote: > On Mon, Sep 11

Re: [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On Fri, Sep 15, 2017 at 12:30 AM, Jens Axboe wrote: > On 09/14/2017 09:57 AM, Ming Lei wrote: >> On Tue, Sep 12, 2017 at 5:27 AM, Jens Axboe wrote: >>> On 09/11/2017 03:13 PM, Mike Snitzer wrote: On Mon, Sep 11 2017 at 4:51pm -0400, Jens Axboe

Re: [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On 09/14/2017 09:57 AM, Ming Lei wrote: > On Tue, Sep 12, 2017 at 5:27 AM, Jens Axboe wrote: >> On 09/11/2017 03:13 PM, Mike Snitzer wrote: >>> On Mon, Sep 11 2017 at 4:51pm -0400, >>> Jens Axboe wrote: >>> On 09/11/2017 10:16 AM, Mike Snitzer wrote: >

Re: [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On Tue, Sep 12, 2017 at 5:27 AM, Jens Axboe wrote: > On 09/11/2017 03:13 PM, Mike Snitzer wrote: >> On Mon, Sep 11 2017 at 4:51pm -0400, >> Jens Axboe wrote: >> >>> On 09/11/2017 10:16 AM, Mike Snitzer wrote: Here is v2 that should obviate the need to

Re: [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On 09/11/2017 04:30 PM, Mike Snitzer wrote: > On Mon, Sep 11 2017 at 5:51pm -0400, > Mike Snitzer wrote: > >> On Mon, Sep 11 2017 at 5:27pm -0400, >> Jens Axboe wrote: >>> >>> Does the below work for you? >> >> I _will_ test your patch and let you know! >

Re: [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On Mon, Sep 11 2017 at 5:51pm -0400, Mike Snitzer wrote: > On Mon, Sep 11 2017 at 5:27pm -0400, > Jens Axboe wrote: > > > > Does the below work for you? > > I _will_ test your patch and let you know! Tested with bfq on underlying paths and both none and

Re: [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On Mon, Sep 11 2017 at 5:27pm -0400, Jens Axboe wrote: > On 09/11/2017 03:13 PM, Mike Snitzer wrote: > > On Mon, Sep 11 2017 at 4:51pm -0400, > > Jens Axboe wrote: > > > >> On 09/11/2017 10:16 AM, Mike Snitzer wrote: > >>> Here is v2 that should obviate the

Re: [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On 09/11/2017 03:13 PM, Mike Snitzer wrote: > On Mon, Sep 11 2017 at 4:51pm -0400, > Jens Axboe wrote: > >> On 09/11/2017 10:16 AM, Mike Snitzer wrote: >>> Here is v2 that should obviate the need to rename blk_mq_insert_request >>> (by using bools to control run_queue and

Re: [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On Mon, Sep 11 2017 at 4:51pm -0400, Jens Axboe wrote: > On 09/11/2017 10:16 AM, Mike Snitzer wrote: > > Here is v2 that should obviate the need to rename blk_mq_insert_request > > (by using bools to control run_queue and async). > > > > As for inserting directly into

Re: [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On 09/11/2017 10:16 AM, Mike Snitzer wrote: > Here is v2 that should obviate the need to rename blk_mq_insert_request > (by using bools to control run_queue and async). > > As for inserting directly into dispatch, if that can be done that is > great but I'd prefer to have that be a follow-up

[PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

, and does so in well-known terms. What do you think? Thanks, Mike From: Mike Snitzer <snit...@redhat.com> Date: Fri, 8 Sep 2017 11:45:13 -0400 Subject: [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request() A NULL pointer crash was reported for the case of having t