Re: [PATCH v2 11/51] md: raid1: initialize bvec table via bio_add_page()

2017-06-29 Thread Shaohua Li
On Wed, Jun 28, 2017 at 12:22:51AM +0800, Ming Lei wrote: > On Tue, Jun 27, 2017 at 05:36:39PM +0800, Guoqing Jiang wrote: > > > > > > On 06/26/2017 08:09 PM, Ming Lei wrote: > > > We will support multipage bvec soon, so initialize bvec > > > table using the standardy way instead of writing the

Re: [PATCH v2 11/51] md: raid1: initialize bvec table via bio_add_page()

2017-06-28 Thread Guoqing Jiang
On 06/28/2017 12:22 AM, Ming Lei wrote: Seems above section is similar as reset_bvec_table introduced in next patch, why there is difference between raid1 and raid10? Maybe add reset_bvec_table into md.c, then call it in raid1 or raid10 is better, just my 2 cents. Hi Guoqing, I think it is

Re: [PATCH v2 11/51] md: raid1: initialize bvec table via bio_add_page()

2017-06-27 Thread Ming Lei
On Tue, Jun 27, 2017 at 05:36:39PM +0800, Guoqing Jiang wrote: > > > On 06/26/2017 08:09 PM, Ming Lei wrote: > > We will support multipage bvec soon, so initialize bvec > > table using the standardy way instead of writing the > > talbe directly. Otherwise it won't work any more once > >

Re: [PATCH v2 11/51] md: raid1: initialize bvec table via bio_add_page()

2017-06-27 Thread Guoqing Jiang
On 06/26/2017 08:09 PM, Ming Lei wrote: We will support multipage bvec soon, so initialize bvec table using the standardy way instead of writing the talbe directly. Otherwise it won't work any more once multipage bvec is enabled. Cc: Shaohua Li Cc: linux-r...@vger.kernel.org

[PATCH v2 11/51] md: raid1: initialize bvec table via bio_add_page()

2017-06-26 Thread Ming Lei
We will support multipage bvec soon, so initialize bvec table using the standardy way instead of writing the talbe directly. Otherwise it won't work any more once multipage bvec is enabled. Cc: Shaohua Li Cc: linux-r...@vger.kernel.org Signed-off-by: Ming Lei