Re: [PATCH v2 4/7] blk-mq: Introduce blk_quiesce_queue() and blk_resume_queue()

On 10/05/2016 11:14 AM, Sagi Grimberg wrote: Hello Ming, Can you have a look at the attached patch? That patch uses an srcu read lock for all queue types, whether or not the BLK_MQ_F_BLOCKING flag has been set. Additionally, I have dropped the QUEUE_FLAG_QUIESCING flag. Just like previous

Re: [PATCH v2 4/7] blk-mq: Introduce blk_quiesce_queue() and blk_resume_queue()

On Wed, Oct 5, 2016 at 12:16 PM, Bart Van Assche wrote: > On 10/01/16 15:56, Ming Lei wrote: >> >> If we just call the rcu/srcu read lock(or the mutex) around .queue_rq(), >> the >> above code needn't to be duplicated any more. > > > Hello Ming, > > Can you have a look

Re: [PATCH v2 4/7] blk-mq: Introduce blk_quiesce_queue() and blk_resume_queue()

On Fri, Sep 30, 2016 at 11:55 PM, Bart Van Assche wrote: > On 09/29/16 14:51, Ming Lei wrote: >> >> On Thu, Sep 29, 2016 at 7:59 AM, Bart Van Assche >> wrote: >>> >>> blk_quiesce_queue() prevents that new queue_rq() invocations >> >> >>

Re: [PATCH v2 4/7] blk-mq: Introduce blk_quiesce_queue() and blk_resume_queue()

On Thu, Sep 29, 2016 at 7:59 AM, Bart Van Assche wrote: > blk_quiesce_queue() prevents that new queue_rq() invocations blk_mq_quiesce_queue() > occur and waits until ongoing invocations have finished. This > function does *not* wait until all outstanding requests