Re: [PATCH v3 07/49] bcache: comment on direct access to bvec table

On Thu, Aug 10, 2017 at 04:26:03AM -0700, Christoph Hellwig wrote: > I think all this bcache code needs bigger attention. For one > bio_alloc_pages is only used in bcache, so we should move it in there. Looks a good idea. > > Second the way bio_alloc_pages is currently written looks

Re: [PATCH v3 07/49] bcache: comment on direct access to bvec table

I think all this bcache code needs bigger attention. For one bio_alloc_pages is only used in bcache, so we should move it in there. Second the way bio_alloc_pages is currently written looks potentially dangerous for multi-page biovecs, so we should think about a better calling convention. The

[PATCH v3 07/49] bcache: comment on direct access to bvec table

Looks all are safe after multipage bvec is supported. Cc: linux-bca...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/md/bcache/btree.c | 1 + drivers/md/bcache/super.c | 6 ++ drivers/md/bcache/util.c | 7 +++ 3 files changed, 14 insertions(+) diff --git