Re: [PATCH v6 9/9] block, scsi: Make SCSI device suspend and resume work reliably

2017-10-10 Thread Ming Lei
On Mon, Oct 09, 2017 at 09:16:53PM +, Bart Van Assche wrote: > On Sat, 2017-10-07 at 12:33 +0800, Ming Lei wrote: > > On Wed, Oct 04, 2017 at 05:01:10PM -0700, Bart Van Assche wrote: > > > It is essential during suspend and resume that neither the filesystem > > > state nor the filesystem

Re: [PATCH v6 9/9] block, scsi: Make SCSI device suspend and resume work reliably

2017-10-09 Thread Bart Van Assche
On Mon, 2017-10-09 at 14:16 -0700, Bart Van Assche wrote: > On Sat, 2017-10-07 at 12:33 +0800, Ming Lei wrote: > > On Wed, Oct 04, 2017 at 05:01:10PM -0700, Bart Van Assche wrote: > > > int > > > scsi_device_quiesce(struct scsi_device *sdev) > > > { > > > + struct request_queue *q =

Re: [PATCH v6 9/9] block, scsi: Make SCSI device suspend and resume work reliably

2017-10-09 Thread Bart Van Assche
On Sat, 2017-10-07 at 12:33 +0800, Ming Lei wrote: > On Wed, Oct 04, 2017 at 05:01:10PM -0700, Bart Van Assche wrote: > > It is essential during suspend and resume that neither the filesystem > > state nor the filesystem metadata in RAM changes. This is why while > > the hibernation image is being

Re: [PATCH v6 9/9] block, scsi: Make SCSI device suspend and resume work reliably

2017-10-06 Thread Ming Lei
On Wed, Oct 04, 2017 at 05:01:10PM -0700, Bart Van Assche wrote: > It is essential during suspend and resume that neither the filesystem > state nor the filesystem metadata in RAM changes. This is why while > the hibernation image is being written or restored that SCSI devices quiesce isn't used

[PATCH v6 9/9] block, scsi: Make SCSI device suspend and resume work reliably

2017-10-04 Thread Bart Van Assche
It is essential during suspend and resume that neither the filesystem state nor the filesystem metadata in RAM changes. This is why while the hibernation image is being written or restored that SCSI devices are quiesced. The SCSI core quiesces devices through scsi_device_quiesce() and