Re: [PATCH v8 17/18] xfs: minimal conversion to errseq_t writeback error reporting

2017-06-30 Thread Christoph Hellwig
On Fri, Jun 30, 2017 at 12:45:54PM -0400, Jeff Layton wrote: > Should I aim to do that with an individual patch for each fs, or is it > better to do a swath of them all at once in a single patch here? I'd be perfectly happy with one big patch for all the trivial conversions.

Re: [PATCH v8 17/18] xfs: minimal conversion to errseq_t writeback error reporting

2017-06-30 Thread Jeff Layton
On Thu, 2017-06-29 at 07:12 -0700, Christoph Hellwig wrote: > Nice and simple, this looks great! > > Reviewed-by: Christoph Hellwig Thanks! I think this turned out to be a lot cleaner too. For filesystems that use filemap_write_and_wait_range today this now becomes a pretty straight conversion

Re: [PATCH v8 17/18] xfs: minimal conversion to errseq_t writeback error reporting

2017-06-29 Thread Darrick J. Wong
On Thu, Jun 29, 2017 at 09:19:53AM -0400, jlay...@kernel.org wrote: > From: Jeff Layton > > Just check and advance the data errseq_t in struct file before > before returning from fsync on normal files. Internal filemap_* > callers are left as-is. > > Signed-off-by: Jeff Layton Looks ok, Review

Re: [PATCH v8 17/18] xfs: minimal conversion to errseq_t writeback error reporting

2017-06-29 Thread Christoph Hellwig
Nice and simple, this looks great! Reviewed-by: Christoph Hellwig

[PATCH v8 17/18] xfs: minimal conversion to errseq_t writeback error reporting

2017-06-29 Thread jlayton
From: Jeff Layton Just check and advance the data errseq_t in struct file before before returning from fsync on normal files. Internal filemap_* callers are left as-is. Signed-off-by: Jeff Layton --- fs/xfs/xfs_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/x