Doubt related to immutable biovecs

Hello, I've some queries related to accessing the 'bio_vec' and 'bi_vcnt' members in the BIO structure after the kernel changes implemented for the 'immutable biovecs' - Background - - From the changes done for the immutable biovecs, I understand that the driver code now no longer needs to

[PATCH RFC 2/4] dm thin: parse "keep_bio_blkcg" from userspace tools

keep_bio_blkcg feature is off by default, and it can be turned on by using "keep_bio_blkcg" argument. Signed-off-by: Hou Tao --- drivers/md/dm-thin.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index

[PATCH RFC 4/4] dm thin: associate bio with current task if keep_bio_blkcg is enabled

If keep_bio_blkcg is enabled, assign the io_context and the blkcg of current task to bio before processing the bio. Signed-off-by: Hou Tao --- drivers/md/dm-thin.c | 5 + drivers/md/dm-thin.h | 17 + 2 files changed, 22 insertions(+) create mode 100644

[PATCH RFC 0/4] dm thin: support blk-throttle on data and metadata device

Hi all, We need to throttle the O_DIRECT IO on data and metadata device of a dm-thin pool and encounter some problems. If we set the limitation on the root blkcg, the throttle works. If we set the limitation on a child blkcg, the throttle doesn't work well. The reason why the throttle doesn't

[PATCH RFC 3/4] dm thin: show the enabled status of keep_bio_blkcg feature

If keep_bio_blkcg feature is enabled, we can ensure that by STATUSTYPE_TABLE or STATUSTYPE_INFO command. Signed-off-by: Hou Tao --- drivers/md/dm-thin.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 20 gen 2017, alle ore 14:14, Paolo Valente > ha scritto: > >> >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> This is basically identical to deadline-iosched, except it registers >> as a MQ capable scheduler. This is

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

On Fri, Jan 20 2017, Paolo Valente wrote: > > > Il giorno 20 gen 2017, alle ore 14:14, Paolo Valente > > ha scritto: > > > >> > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha > >> scritto: > >> > >> This is basically identical to

[GIT PULL] Block fixes for 4.10-rc

Hi Linus, Just two small fixes for this -rc. One is just killing an unused variable from Keith, but the other fixes a performance regression for nbd in this series, where we inadvertently flipped when we set MSG_MORE when outputting data. Please pull! git://git.kernel.dk/linux-block.git

Re: [LSF/MM TOPIC] Badblocks checking/representation in filesystems

On Fri, 2017-01-20 at 18:24 +0900, Yasunori Goto wrote: : > > > > Like mentioned before, this discussion is more about presentation > > of errors in a known consumable format, rather than recovering from > > errors. While recovering from errors is interesting, we already > > have layers like

[PATCH 4/4] nbd: add a nbd-control interface

This patch mirrors the loop back device behavior with a few changes. First there is no DEL operation as NBD doesn't get as much churn as loop devices do. Secondly the GET_NEXT operation can optionally create a new NBD device or not. Our infrastructure people want to not allow NBD to create new

[PATCH 3/4] nbd: use an idr to keep track of nbd devices

To prepare for dynamically adding new nbd devices to the system switch from using an array for the nbd devices and instead use an idr. This copies what loop does for keeping track of its devices. Signed-off-by: Josef Bacik --- drivers/block/nbd.c | 213

[PATCH 1/4] nbd: use our own workqueue for recv threads

Since we are in the memory reclaim path we need our recv work to be on a workqueue that has WQ_MEM_RECLAIM set so we can avoid deadlocks. Also set WQ_HIGHPRI since we are in the completion path for IO. Signed-off-by: Josef Bacik --- drivers/block/nbd.c | 13 +++-- 1 file

[PATCH 2/4] miscdevice: add a minor number for nbd-control

NBD is moving to a loop-control esque way of managing it's device creation and deletion. Reserver a minor number for the new device. Signed-off-by: Josef Bacik --- include/linux/miscdevice.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/miscdevice.h

Re: [PATCH RFC 0/4] dm thin: support blk-throttle on data and metadata device

Hou Tao writes: > Hi all, > > We need to throttle the O_DIRECT IO on data and metadata device > of a dm-thin pool and encounter some problems. If we set the > limitation on the root blkcg, the throttle works. If we set the > limitation on a child blkcg, the throttle doesn't

Re: [Lsf-pc] [LSF/MM TOPIC] Badblocks checking/representation in filesystems

On Fri, Jan 20, 2017 at 1:47 AM, Jan Kara wrote: > On Thu 19-01-17 14:17:19, Vishal Verma wrote: >> On 01/18, Jan Kara wrote: >> > On Tue 17-01-17 15:37:05, Vishal Verma wrote: >> > 2) PMEM is exposed for DAX aware filesystem. This seems to be what you are >> > mostly interested in.

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

On 2017-01-19 09:02:16 [+0800], kernel test robot wrote: > test-description: Trinity is a linux system call fuzz tester. you don't even get to fire up trinity. With and without the patch you crash very early. > +-+++ > |

Re: [PATCH RFC 0/4] dm thin: support blk-throttle on data and metadata device

On Fri, Jan 20 2017 at 10:19am -0500, Jeff Moyer wrote: > Hou Tao writes: > > > Hi all, > > > > We need to throttle the O_DIRECT IO on data and metadata device > > of a dm-thin pool and encounter some problems. If we set the > > limitation on the root

Re: [PATCH RFC 0/4] dm thin: support blk-throttle on data and metadata device

On Fri, Jan 20, 2017 at 10:19:22AM -0500, Jeff Moyer wrote: > Hou Tao writes: > > > Hi all, > > > > We need to throttle the O_DIRECT IO on data and metadata device > > of a dm-thin pool and encounter some problems. If we set the > > limitation on the root blkcg, the throttle

Re: Doubt related to immutable biovecs

Hi, On Fri, Jan 20, 2017 at 9:41 PM, Suraj Choudhari wrote: > Hello, > > I've some queries related to accessing the 'bio_vec' and 'bi_vcnt' > members in the BIO structure after the kernel changes implemented for > the 'immutable biovecs' - > > Background - > - From

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: > > This is basically identical to deadline-iosched, except it registers > as a MQ capable scheduler. This is still a single queue design. > Jens, no spin_lock_irq* in the code. So, also request dispatches are

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

> Il giorno 17 gen 2017, alle ore 03:47, Jens Axboe ha scritto: > > On 12/22/2016 09:49 AM, Paolo Valente wrote: >> >>> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >>> >>> This is basically identical to deadline-iosched, except it registers >>>

Re: [LSF/MM TOPIC][LSF/MM ATTEND] NAPI polling for block drivers

On Tue, Jan 17, 2017 at 05:45:53PM +0200, Sagi Grimberg wrote: > > >-- > >[1] > >queue = b'nvme0q1' > > usecs : count distribution > > 0 -> 1 : 7310 || > > 2 -> 3 : 11 | | > > 4 -> 7

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

On 2017-01-20 08:32:37 [-0800], Jens Axboe wrote: > That's alright, sounds like it's not a -next regression, but rather something > that is already broken. I can reproduce a lot of breakage if I enable > CONFIG_DEBUG_TEST_DRIVER_REMOVE, in fact my system doesn't boot at all. This > is the first

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

On 01/20/2017 08:01 AM, Sebastian Andrzej Siewior wrote: > On 2017-01-19 09:02:16 [+0800], kernel test robot wrote: >> test-description: Trinity is a linux system call fuzz tester. > > you don't even get to fire up trinity. With and without the patch you > crash very early. > >>

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

On 01/20/2017 08:23 AM, Sebastian Andrzej Siewior wrote: >>> yes. With and without the patch there is a lot of wrong stuff like >>> complains about a kobject initialized again. This leads to a double free >>> at some point. >> >> And what patch are we talking about? I don't mind being CC'ed into a

Re: [lkp-robot] [rcu] b332151a29: kernel_BUG_at_mm/slab.c

On 2017-01-20 08:09:36 [-0800], Jens Axboe wrote: > Is there a full trace of this? [3.654003] scsi host0: scsi_debug: version 1.86 [20160430] [3.654003] dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0 [3.660755] scsi 0:0:0:0: Direct-Access Linuxscsi_debug 0186

Re: [Lsf-pc] [LSF/MM TOPIC] Badblocks checking/representation in filesystems

On Thu 19-01-17 11:03:12, Dan Williams wrote: > On Thu, Jan 19, 2017 at 10:59 AM, Vishal Verma > wrote: > > On 01/19, Jan Kara wrote: > >> On Wed 18-01-17 21:56:58, Verma, Vishal L wrote: > >> > On Wed, 2017-01-18 at 13:32 -0800, Dan Williams wrote: > >> > > On Wed, Jan

Re: [LSF/MM TOPIC] Badblocks checking/representation in filesystems

Hello, Virshal-san. First of all, your discussion is quite interesting for me. Thanks. > > > > If DUE does happen and is flagged to the file system via MCE (somehow...), > > and the fs finds that the error corrupts its allocated data page, or > > metadata, now if the fs wants to recover its

Re: [Lsf-pc] [LSF/MM TOPIC] Badblocks checking/representation in filesystems

On Thu 19-01-17 14:17:19, Vishal Verma wrote: > On 01/18, Jan Kara wrote: > > On Tue 17-01-17 15:37:05, Vishal Verma wrote: > > 2) PMEM is exposed for DAX aware filesystem. This seems to be what you are > > mostly interested in. We could possibly do something more efficient than > > what NVDIMM