Re: vgdisplay hang on iSCSI session

2018-02-12 Thread Jean-Louis Dupond
Hi, Nobody any idea's on this? Would be nice to have some pointers at least :) Thanks Jean-Louis Op 2018-02-05 17:01, schreef Jean-Louis Dupond: Hi All, We've got some "strange" issue on a Xen hypervisor with CentOS 6 and 4.9.63-29.el6.x86_6 kernel. The system has a local raid + is connected

Re: [PATCH] blk: optimization for classic polling

2018-02-12 Thread Bart Van Assche
On 05/29/83 20:21, Nitesh Shetty wrote: [ ... ] Hello Nitesh, Can you check the clock of the system you used to send this e-mail? In the header of your e-mail I found the following: Date: Sun, 30 May 2083 09:51:06 +0530 Thanks, Bart.

Re: [PATCH rfc 3/5] irq_poll: wire up irq_am

2018-02-12 Thread Sagi Grimberg
Hey Bart, +void irq_poll_init_am(struct irq_poll *iop, unsigned int nr_events, +unsigned short nr_levels, unsigned short start_level, irq_poll_am_fn *amfn) +{ + iop->amfn = amfn; + irq_am_init(>am, nr_events, nr_levels, start_level, irq_poll_am); +} This function has a

Re: vgdisplay hang on iSCSI session

2018-02-12 Thread Bart Van Assche
On 02/05/18 08:01, Jean-Louis Dupond wrote: We've got some "strange" issue on a Xen hypervisor with CentOS 6 and 4.9.63-29.el6.x86_6 kernel. Hello Jean-Louis, Since this behavior was observed with a distro kernel I think a support request should be submitted to the vendor of that kernel.

Re: [PATCH v2] blk-throttle: fix race between blkcg_bio_issue_check and cgroup_rmdir

2018-02-12 Thread Tejun Heo
Hello, Joseph. On Fri, Feb 09, 2018 at 10:15:19AM +0800, Joseph Qi wrote: > IIUC, we have to identify it is in blkcg_css_offline now which will > blkg_put. Since percpu_ref_kill_and_confirm in kill_css will set flag > __PERCPU_REF_DEAD, so we can use this to avoid the race. IOW, if >

[PATCH] nbd: fix return value in error handling path

2018-02-12 Thread Gustavo A. R. Silva
It seems that the proper value to return in this particular case is the one contained into variable new_index instead of ret. Addresses-Coverity-ID: 1465148 ("Copy-paste error") Fixes: e46c7287b1c2 ("nbd: add a basic netlink interface") Signed-off-by: Gustavo A. R. Silva

[PATCH] block: Move SECTOR_SIZE and SECTOR_SHIFT definitions into

2018-02-12 Thread Bart Van Assche
It happens often while I'm preparing a patch for a block driver that I'm wondering: is a definition of SECTOR_SIZE and/or SECTOR_SHIFT available for this driver? Do I have to introduce definitions of these constants before I can use these constants? To avoid this confusion, move the existing

[PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-02-12 Thread Bart Van Assche
When debugging e.g. the SCSI timeout handler it is important that requests that have not yet been started or that already have completed are also reported through debugfs. This patch depends on a patch that went upstream in kernel v4.15, namely commit 14e3062fb185 ("scsi: core: Fix a

RE: [PATCH 0/5] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

2018-02-12 Thread Kashyap Desai
> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Sunday, February 11, 2018 11:01 AM > To: Kashyap Desai > Cc: Hannes Reinecke; Jens Axboe; linux-block@vger.kernel.org; Christoph > Hellwig; Mike Snitzer; linux-s...@vger.kernel.org; Arun Easi; Omar Sandoval; >

Re: v4.16-rc1 + dm-mpath + BFQ

2018-02-12 Thread Bart Van Assche
On 02/11/18 23:35, Paolo Valente wrote: Also this smells a little bit like some spurious elevator call. Unfortunately I have no clue on the cause. To go on, I need at least to reproduce it. In this respect: Bart, could you please tell me how to setup the offending configuration, and to cause

[PATCH] block: Reorder the queue flag manipulaton function definitions

2018-02-12 Thread Bart Van Assche
Move the definition of queue_flag_clear_unlocked() up and move the definition of queue_in_flight() down such that all queue flag manipulation function definitions become contiguous. This patch does not change any functionality. Signed-off-by: Bart Van Assche ---

Re: [PATCH V2 4/4] nvme: lightnvm: add late setup of block size and metadata

2018-02-12 Thread Javier Gonzalez
> On 9 Feb 2018, at 01.27, Matias Bjørling wrote: > > The nvme driver sets up the size of the nvme namespace in two steps. > First it initializes the device with standard logical block and > metadata sizes, and then sets the correct logical block and metadata > size. Due to

Re: [PATCH 0/5] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

2018-02-12 Thread Ming Lei
Hi Kashyap, On Tue, Feb 13, 2018 at 12:05:14AM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Sunday, February 11, 2018 11:01 AM > > To: Kashyap Desai > > Cc: Hannes Reinecke; Jens Axboe; linux-block@vger.kernel.org; Christoph

Re: [PATCH 5/6] genhd: Fix BUG in blkdev_open()

2018-02-12 Thread Hou Tao
Hi Jan, On 2018/2/7 0:05, Jan Kara wrote: > When two blkdev_open() calls for a partition race with device removal > and recreation, we can hit BUG_ON(!bd_may_claim(bdev, whole, holder)) in > blkdev_open(). The race can happen as follows: > > CPU0 CPU1

Re: [PATCH 4/6] genhd: Fix use after free in __blkdev_get()

2018-02-12 Thread Hou Tao
Hi Jan, On 2018/2/7 0:05, Jan Kara wrote: > When two blkdev_open() calls race with device removal and recreation, > __blkdev_get() can use looked up gendisk after it is freed: > > CPU0 CPU1CPU2 >

[PATCH] blk-throttle: avoid multiple counting for same bio

2018-02-12 Thread Chengguang Xu
In current throttling/upper limit policy of blkio cgroup blkio.throttle.io_service_bytes does not exactly represent the number of bytes issued to the disk by the group, sometimes this number could be counted multiple times of real bytes. This fix introduces BIO_COUNTED flag to avoid multiple