Re: [PATCH] loop: fix LOOP_GET_STATUS lock imbalance

On 4/6/18 10:57 AM, Omar Sandoval wrote: > From: Omar Sandoval > > Commit 2d1d4c1e591f made loop_get_status() drop lo_ctx_mutex before > returning, but the loop_get_status_old(), loop_get_status64(), and > loop_get_status_compat() wrappers don't call loop_get_status() if the >

Re: [PATCH V3 4/4] genirq/affinity: irq vector spread among online CPUs as far as possible

On Fri, 6 Apr 2018, Thomas Gleixner wrote: > On Fri, 6 Apr 2018, Ming Lei wrote: > > > > I will post V4 soon by using cpu_present_mask in the 1st stage irq spread. > > And it should work fine for Kashyap's case in normal cases. > > No need to resend. I've changed it already and will push it out

Re: 4.15.14 crash with iscsi target and dvd

Bart Van Assche wrote: > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is null. > > I added a dev_printk in scsi_print_command where the 2 if statements return. > > Logs: > > [ 29.866415] sr 3:0:0:0: cmd->cmnd is NULL

Re: [PATCH] blk-cgroup: remove entries in blkg_tree before queue release

Hi Alexandru, Thank you for the patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCH] block/compat_ioctl: fix range check in BLKGETSIZE

kernel ulong and compat_ulong_t may not be same width. Use type directly to eliminate mismatches. This would result in truncation rather than EFBIG for 32bit mode for large disks. Signed-off-by: Khazhismel Kumykov --- block/compat_ioctl.c | 2 +- 1 file changed, 1

Re: [PATCH] blk-cgroup: remove entries in blkg_tree before queue release

Hi Alexandru, Thank you for the patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: 4.15.14 crash with iscsi target and dvd

On Fri, 2018-04-06 at 21:03 -0400, Wakko Warner wrote: > Bart Van Assche wrote: > > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is > > > null. > > > I added a dev_printk in scsi_print_command where the 2 if

Re: 4.15.14 crash with iscsi target and dvd

Bart Van Assche wrote: > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is null. > > I added a dev_printk in scsi_print_command where the 2 if statements return. > > Logs: > > [ 29.866415] sr 3:0:0:0: cmd->cmnd is NULL

Re: Multi-Actuator SAS HDD First Look

On Thu, 5 Apr 2018 17:43:46 -0600 Tim Walker wrote: > On Tue, Apr 3, 2018 at 1:46 AM, Christoph Hellwig > wrote: > > On Sat, Mar 31, 2018 at 01:03:46PM +0200, Hannes Reinecke wrote: > >> Actually I would propose to have a 'management' LUN at LUN0,

Re: Multi-Actuator SAS HDD First Look

On Fri, Apr 06, 2018 at 08:24:18AM +0200, Hannes Reinecke wrote: > Ah. Far better. > What about delegating FORMAT UNIT to the control LUN, and not > implementing it for the individual disk LUNs? > That would make an even stronger case for having a control LUN; > with that there wouldn't be any

WARNING: lock held when returning to user space!

Hello, syzbot hit the following crash on upstream commit 38c23685b273cfb4ccf31a199feccce3bdcb5d83 (Fri Apr 6 04:29:35 2018 +) Merge tag 'armsoc-drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc syzbot dashboard link:

Re: [PATCH] blk-mq: only run mapped hw queues in blk_mq_run_hw_queues()

On 04/06/2018 10:51 AM, Christian Borntraeger wrote: > > > On 04/06/2018 10:41 AM, Ming Lei wrote: >> On Thu, Apr 05, 2018 at 07:39:56PM +0200, Christian Borntraeger wrote: >>> >>> >>> On 04/05/2018 06:11 PM, Ming Lei wrote: > > Could you please apply the following patch and provide

Re: [PATCH] blk-mq: only run mapped hw queues in blk_mq_run_hw_queues()

On 04/06/2018 11:23 AM, Ming Lei wrote: > On Fri, Apr 06, 2018 at 10:51:28AM +0200, Christian Borntraeger wrote: >> >> >> On 04/06/2018 10:41 AM, Ming Lei wrote: >>> On Thu, Apr 05, 2018 at 07:39:56PM +0200, Christian Borntraeger wrote: On 04/05/2018 06:11 PM, Ming Lei wrote:

Re: [PATCH] blk-mq: only run mapped hw queues in blk_mq_run_hw_queues()

On 04/06/2018 11:23 AM, Ming Lei wrote: > On Fri, Apr 06, 2018 at 10:51:28AM +0200, Christian Borntraeger wrote: >> >> >> On 04/06/2018 10:41 AM, Ming Lei wrote: >>> On Thu, Apr 05, 2018 at 07:39:56PM +0200, Christian Borntraeger wrote: On 04/05/2018 06:11 PM, Ming Lei wrote:

Re: [PATCH] blk-mq: only run mapped hw queues in blk_mq_run_hw_queues()

On Thu, Apr 05, 2018 at 07:39:56PM +0200, Christian Borntraeger wrote: > > > On 04/05/2018 06:11 PM, Ming Lei wrote: > >> > >> Could you please apply the following patch and provide the dmesg boot log? > > > > And please post out the 'lscpu' log together from the test machine too. > >

Re: [PATCH V3 4/4] genirq/affinity: irq vector spread among online CPUs as far as possible

On Fri, 6 Apr 2018, Ming Lei wrote: > > I will post V4 soon by using cpu_present_mask in the 1st stage irq spread. > And it should work fine for Kashyap's case in normal cases. No need to resend. I've changed it already and will push it out after lunch. Thanks, tglx

Re: [PATCH] blk-mq: only run mapped hw queues in blk_mq_run_hw_queues()

On 04/05/2018 06:05 PM, Ming Lei wrote: [...] > diff --git a/block/blk-mq.c b/block/blk-mq.c > index 90838e998f66..996f8a963026 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -1324,9 +1324,18 @@ static void __blk_mq_run_hw_queue(struct blk_mq_hw_ctx > *hctx) >*/ > if

Re: [PATCH] blk-mq: only run mapped hw queues in blk_mq_run_hw_queues()

On 04/06/2018 10:41 AM, Ming Lei wrote: > On Thu, Apr 05, 2018 at 07:39:56PM +0200, Christian Borntraeger wrote: >> >> >> On 04/05/2018 06:11 PM, Ming Lei wrote: Could you please apply the following patch and provide the dmesg boot log? >>> >>> And please post out the 'lscpu' log

Re: [PATCH V3 4/4] genirq/affinity: irq vector spread among online CPUs as far as possible

Hi Thomas, On Wed, Apr 04, 2018 at 09:38:26PM +0200, Thomas Gleixner wrote: > On Wed, 4 Apr 2018, Ming Lei wrote: > > On Wed, Apr 04, 2018 at 10:25:16AM +0200, Thomas Gleixner wrote: > > > In the example above: > > > > > > > > > irq 39, cpu list 0,4 > > > > > > irq 40, cpu list 1,6 > > >

Re: [PATCH] blk-mq: only run mapped hw queues in blk_mq_run_hw_queues()

On Fri, Apr 06, 2018 at 10:51:28AM +0200, Christian Borntraeger wrote: > > > On 04/06/2018 10:41 AM, Ming Lei wrote: > > On Thu, Apr 05, 2018 at 07:39:56PM +0200, Christian Borntraeger wrote: > >> > >> > >> On 04/05/2018 06:11 PM, Ming Lei wrote: > > Could you please apply the

[PATCH] blk-cgroup: remove entries in blkg_tree before queue release

The q->id is used as an index within the blkg_tree radix tree. If the entry is not released before reclaiming the blk_queue_ida's id blkcg_init_queue() within a different driver from which this id was originally for can fail due to the entry at that index within the radix tree already existing.

Re: [PATCH] blk-mq: only run mapped hw queues in blk_mq_run_hw_queues()

On 04/06/2018 04:58 PM, Ming Lei wrote: > On Fri, Apr 06, 2018 at 04:26:49PM +0200, Christian Borntraeger wrote: >> >> >> On 04/06/2018 03:41 PM, Ming Lei wrote: >>> On Fri, Apr 06, 2018 at 12:19:19PM +0200, Christian Borntraeger wrote: On 04/06/2018 11:23 AM, Ming Lei wrote:

Re: [PATCH] blk-mq: only run mapped hw queues in blk_mq_run_hw_queues()

On Fri, Apr 06, 2018 at 12:19:19PM +0200, Christian Borntraeger wrote: > > > On 04/06/2018 11:23 AM, Ming Lei wrote: > > On Fri, Apr 06, 2018 at 10:51:28AM +0200, Christian Borntraeger wrote: > >> > >> > >> On 04/06/2018 10:41 AM, Ming Lei wrote: > >>> On Thu, Apr 05, 2018 at 07:39:56PM +0200,

Re: [PATCH] blk-mq: only run mapped hw queues in blk_mq_run_hw_queues()

On 04/06/2018 03:41 PM, Ming Lei wrote: > On Fri, Apr 06, 2018 at 12:19:19PM +0200, Christian Borntraeger wrote: >> >> >> On 04/06/2018 11:23 AM, Ming Lei wrote: >>> On Fri, Apr 06, 2018 at 10:51:28AM +0200, Christian Borntraeger wrote: On 04/06/2018 10:41 AM, Ming Lei wrote:

Re: WARNING: lock held when returning to user space!

On Fri, Apr 6, 2018 at 4:27 PM, Jens Axboe wrote: > On 4/6/18 7:02 AM, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on upstream commit >> 38c23685b273cfb4ccf31a199feccce3bdcb5d83 (Fri Apr 6 04:29:35 2018 +) >> Merge tag 'armsoc-drivers' of >>

Re: [PATCH] blk-mq: only run mapped hw queues in blk_mq_run_hw_queues()

On Fri, Apr 06, 2018 at 05:11:53PM +0200, Christian Borntraeger wrote: > > > On 04/06/2018 04:58 PM, Ming Lei wrote: > > On Fri, Apr 06, 2018 at 04:26:49PM +0200, Christian Borntraeger wrote: > >> > >> > >> On 04/06/2018 03:41 PM, Ming Lei wrote: > >>> On Fri, Apr 06, 2018 at 12:19:19PM +0200,

Re: WARNING: lock held when returning to user space!

On 4/6/18 7:02 AM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 38c23685b273cfb4ccf31a199feccce3bdcb5d83 (Fri Apr 6 04:29:35 2018 +) > Merge tag 'armsoc-drivers' of > git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc > syzbot dashboard link: >

Re: [PATCH] blk-mq: only run mapped hw queues in blk_mq_run_hw_queues()

On Fri, Apr 06, 2018 at 04:26:49PM +0200, Christian Borntraeger wrote: > > > On 04/06/2018 03:41 PM, Ming Lei wrote: > > On Fri, Apr 06, 2018 at 12:19:19PM +0200, Christian Borntraeger wrote: > >> > >> > >> On 04/06/2018 11:23 AM, Ming Lei wrote: > >>> On Fri, Apr 06, 2018 at 10:51:28AM +0200,

Re: WARNING: lock held when returning to user space!

On 4/6/18 8:57 AM, Dmitry Vyukov wrote: > On Fri, Apr 6, 2018 at 4:27 PM, Jens Axboe wrote: >> On 4/6/18 7:02 AM, syzbot wrote: >>> Hello, >>> >>> syzbot hit the following crash on upstream commit >>> 38c23685b273cfb4ccf31a199feccce3bdcb5d83 (Fri Apr 6 04:29:35 2018 +) >>>

[PATCH] loop: fix LOOP_GET_STATUS lock imbalance

From: Omar Sandoval Commit 2d1d4c1e591f made loop_get_status() drop lo_ctx_mutex before returning, but the loop_get_status_old(), loop_get_status64(), and loop_get_status_compat() wrappers don't call loop_get_status() if the passed argument is NULL. The callers expect that the

Re: [PATCH] loop: fix LOOP_GET_STATUS lock imbalance

On Fri, Apr 06, 2018 at 09:57:03AM -0700, Omar Sandoval wrote: > From: Omar Sandoval > > Commit 2d1d4c1e591f made loop_get_status() drop lo_ctx_mutex before > returning, but the loop_get_status_old(), loop_get_status64(), and > loop_get_status_compat() wrappers don't call

Re: Multi-Actuator SAS HDD First Look

On 2018-04-06 02:42 AM, Christoph Hellwig wrote: On Fri, Apr 06, 2018 at 08:24:18AM +0200, Hannes Reinecke wrote: Ah. Far better. What about delegating FORMAT UNIT to the control LUN, and not implementing it for the individual disk LUNs? That would make an even stronger case for having a