[PATCH] block: skd: Use %pad printk format for dma_addr_t values

2018-07-12 Thread Helge Deller
Use the existing %pad printk format to print dma_addr_t values. This avoids the following warnings when compiling on the parisc64 platform: drivers/block/skd_main.c: In function 'skd_preop_sg_list': drivers/block/skd_main.c:660:4: warning: format '%llx' expects argument of type 'long long

Re: [RFC PATCH 3/3] blk-mq: Remove generation seqeunce

2018-07-12 Thread Bart Van Assche
On Mon, 2018-05-21 at 17:11 -0600, Keith Busch wrote: > /* > - * We marked @rq->aborted_gstate and waited for RCU. If there were > - * completions that we lost to, they would have finished and > - * updated @rq->gstate by now; otherwise, the completion path is > - * now

Re: [PATCH] block: skd: Use %pad printk format for dma_addr_t values

2018-07-12 Thread Jens Axboe
On 7/12/18 2:29 PM, Helge Deller wrote: > Use the existing %pad printk format to print dma_addr_t values. > This avoids the following warnings when compiling on the parisc64 platform: > > drivers/block/skd_main.c: In function 'skd_preop_sg_list': > drivers/block/skd_main.c:660:4: warning: format

Re: [RFC PATCH 3/3] blk-mq: Remove generation seqeunce

2018-07-12 Thread Keith Busch
On Thu, Jul 12, 2018 at 06:16:12PM +, Bart Van Assche wrote: > On Mon, 2018-05-21 at 17:11 -0600, Keith Busch wrote: > > /* > > -* We marked @rq->aborted_gstate and waited for RCU. If there were > > -* completions that we lost to, they would have finished and > > -* updated

Re: [PATCH] block: skd: Use %pad printk format for dma_addr_t values

2018-07-12 Thread Bart Van Assche
On 07/12/18 13:29, Helge Deller wrote: Use the existing %pad printk format to print dma_addr_t values. This avoids the following warnings when compiling on the parisc64 platform: Reviewed-by: Bart Van Assche

Re: Silent data corruption in blkdev_direct_IO()

2018-07-12 Thread Ming Lei
On Thu, Jul 12, 2018 at 10:36 PM, Hannes Reinecke wrote: > Hi Jens, Christoph, > > we're currently hunting down a silent data corruption occurring due to > commit 72ecad22d9f1 ("block: support a full bio worth of IO for > simplified bdev direct-io"). > > While the whole thing is still hazy on the

Re: [RFC PATCH 3/3] blk-mq: Remove generation seqeunce

2018-07-12 Thread jianchao.wang
On 07/13/2018 06:24 AM, Bart Van Assche wrote: > On Thu, 2018-07-12 at 13:24 -0600, Keith Busch wrote: >> On Thu, Jul 12, 2018 at 06:16:12PM +, Bart Van Assche wrote: >>> What prevents that a request finishes and gets reused after the >>> blk_mq_req_expired() call has finished and before

Re: [RFC PATCH 3/3] blk-mq: Remove generation seqeunce

2018-07-12 Thread jianchao.wang
On 07/13/2018 06:24 AM, Bart Van Assche wrote: > Hello Keith, > > Before commit 12f5b9314545 ("blk-mq: Remove generation seqeunce"), if a > request completion was reported after request timeout processing had > started, completion handling was skipped. The following code in >

Re: [RFC PATCH 3/3] blk-mq: Remove generation seqeunce

2018-07-12 Thread Bart Van Assche
On Thu, 2018-07-12 at 13:24 -0600, Keith Busch wrote: > On Thu, Jul 12, 2018 at 06:16:12PM +, Bart Van Assche wrote: > > What prevents that a request finishes and gets reused after the > > blk_mq_req_expired() call has finished and before kref_get_unless_zero() is > > called? Is this perhaps a

Hello Beautiful

2018-07-12 Thread Jack
Hi Dear, my name is Jack and i am seeking for a relationship in which i will feel loved after a series of failed relationships. I am hoping that you would be interested and we could possibly get to know each other more if you do not mind. I am open to answering questions from you as i think

Silent data corruption in blkdev_direct_IO()

2018-07-12 Thread Hannes Reinecke
Hi Jens, Christoph, we're currently hunting down a silent data corruption occurring due to commit 72ecad22d9f1 ("block: support a full bio worth of IO for simplified bdev direct-io"). While the whole thing is still hazy on the details, the one thing we've found is that reverting that patch fixes

Re: Silent data corruption in blkdev_direct_IO()

2018-07-12 Thread Jens Axboe
On 7/12/18 8:36 AM, Hannes Reinecke wrote: > Hi Jens, Christoph, > > we're currently hunting down a silent data corruption occurring due to > commit 72ecad22d9f1 ("block: support a full bio worth of IO for > simplified bdev direct-io"). > > While the whole thing is still hazy on the details, the

Re: Silent data corruption in blkdev_direct_IO()

2018-07-12 Thread Martin Wilck
On Thu, 2018-07-12 at 09:08 -0600, Jens Axboe wrote: > On 7/12/18 8:36 AM, Hannes Reinecke wrote: > > Hi Jens, Christoph, > > > > we're currently hunting down a silent data corruption occurring due > > to > > commit 72ecad22d9f1 ("block: support a full bio worth of IO for > > simplified bdev

Re: Silent data corruption in blkdev_direct_IO()

2018-07-12 Thread Jens Axboe
On 7/12/18 10:14 AM, Hannes Reinecke wrote: > On 07/12/2018 05:08 PM, Jens Axboe wrote: >> On 7/12/18 8:36 AM, Hannes Reinecke wrote: >>> Hi Jens, Christoph, >>> >>> we're currently hunting down a silent data corruption occurring due to >>> commit 72ecad22d9f1 ("block: support a full bio worth of

Re: Silent data corruption in blkdev_direct_IO()

2018-07-12 Thread Jens Axboe
On 7/12/18 10:20 AM, Jens Axboe wrote: > On 7/12/18 10:14 AM, Hannes Reinecke wrote: >> On 07/12/2018 05:08 PM, Jens Axboe wrote: >>> On 7/12/18 8:36 AM, Hannes Reinecke wrote: Hi Jens, Christoph, we're currently hunting down a silent data corruption occurring due to commit

Re: Silent data corruption in blkdev_direct_IO()

2018-07-12 Thread Hannes Reinecke
On 07/12/2018 05:08 PM, Jens Axboe wrote: On 7/12/18 8:36 AM, Hannes Reinecke wrote: Hi Jens, Christoph, we're currently hunting down a silent data corruption occurring due to commit 72ecad22d9f1 ("block: support a full bio worth of IO for simplified bdev direct-io"). While the whole thing is