Re: [PATCH 01/14] blk-mq: kill q->mq_map

2018-10-27 Thread jianchao.wang
Hi Jens On 10/26/18 5:16 AM, Jens Axboe wrote: > It's just a pointer to set->mq_map, use that instead. Instead of using the set->mq_map and then a two-dimensional set->mq_map, how about migrate the mq_map from per-set to per-cpuctx ? something like: q->queue_hw_ctx[ctx->map[type]] Thanks

Re: [PATCH 01/14] blk-mq: kill q->mq_map

2018-10-27 Thread Jens Axboe
On 10/27/18 8:19 AM, jianchao.wang wrote: > Hi Jens > > On 10/26/18 5:16 AM, Jens Axboe wrote: >> It's just a pointer to set->mq_map, use that instead. > Instead of using the set->mq_map and then a two-dimensional set->mq_map, > how about migrate the mq_map from per-set to per-cpuctx ? >

Re: [PATCH 01/14] blk-mq: kill q->mq_map

2018-10-27 Thread Jens Axboe
On 10/27/18 10:48 AM, Jens Axboe wrote: > On 10/27/18 8:19 AM, jianchao.wang wrote: >> Hi Jens >> >> On 10/26/18 5:16 AM, Jens Axboe wrote: >>> It's just a pointer to set->mq_map, use that instead. >> Instead of using the set->mq_map and then a two-dimensional set->mq_map, >> how about migrate the

Re: [PATCH 1/3] block: make sure discard bio is aligned with logical block size

2018-10-27 Thread Ming Lei
On Fri, Oct 26, 2018 at 09:44:15AM +0200, Christoph Hellwig wrote: > > if (req_sects > UINT_MAX >> 9) > > - req_sects = UINT_MAX >> 9; > > + req_sects = (UINT_MAX >> 9) & ~bs_mask; > > Given that we have this same thing duplicated in write zeroes >

recent issues with heavy delete's causing soft lockups

2018-10-27 Thread Thomas Fjellstrom
Hi As of the past few months or so I've been dealing with my workstation locking up for upwards of minutes at a time when deleting a large directory tree. I don't recall this being a problem before. Current setup is 3 SATA SSDs in an lvm vg. most space is allocated to an ext4 /home where my

Re: recent issues with heavy delete's causing soft lockups

2018-10-27 Thread Jens Axboe
On Oct 27, 2018, at 12:40 PM, Thomas Fjellstrom wrote: > > Hi > > As of the past few months or so I've been dealing with my workstation locking > up for upwards of minutes at a time when deleting a large directory tree. I > don't recall this being a problem before. > > Current setup is 3