Re: [LSF/MM TOPIC] [LSF/MM ATTEND] md raid general discussion

On 01/10/2017 12:38 AM, Coly Li wrote: Hi Folks, I'd like to propose a general md raid discussion, it is quite necessary for most of active md raid developers sit together to discuss current challenge of Linux software raid and development trends. In the last years, we have many development

[PATCH] block: use bio_io_error directly

g.me> Cc: Alexander Viro <v...@zeniv.linux.org.uk> Signed-off-by: Guoqing Jiang <gqji...@suse.com> --- drivers/block/drbd/drbd_int.h | 3 +-- drivers/md/dm-mpath.c | 3 +-- drivers/nvme/target/io-cmd.c | 3 +-- fs/block_dev.c| 3 +-- 4 files changed, 4 insertions(+), 8 del

Re: [PATCH v2 11/51] md: raid1: initialize bvec table via bio_add_page()

it is a good idea, and even the two patches can be put into one, so how about the following patch? Looks good. Acked-by: Guoqing Jiang <gqji...@suse.com> Thanks, Guoqing Shaohua, what do you think of this one? --- diff --git a/drivers/md/md.c b/drivers/md/md.c index 3d957ac1e109..7ffc62

Re: [PATCH v2 11/51] md: raid1: initialize bvec table via bio_add_page()

On 06/26/2017 08:09 PM, Ming Lei wrote: We will support multipage bvec soon, so initialize bvec table using the standardy way instead of writing the talbe directly. Otherwise it won't work any more once multipage bvec is enabled. Cc: Shaohua Li Cc: linux-r...@vger.kernel.org

[PATCH] block: simplify code with bio_io_error

bio_io_error was introduced in the commit 4246a0b ("block: add a bi_error field to struct bio"), so use it directly. Signed-off-by: Guoqing Jiang <gqji...@suse.com> --- block/blk-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/blk-core.c b/

Re: [PATCH] badblocks: fix wrong return value in badblocks_set if badblocks are disabled

On 09/29/2017 02:45 AM, Liu Bo wrote: On Thu, Sep 28, 2017 at 09:57:41AM +0800, Guoqing Jiang wrote: On 09/28/2017 06:13 AM, Liu Bo wrote: MD's rdev_set_badblocks() expects that badblocks_set() returns 1 if badblocks are disabled, otherwise, rdev_set_badblocks() will record superblock

Re: [PATCH] badblocks: fix wrong return value in badblocks_set if badblocks are disabled

On 09/28/2017 06:13 AM, Liu Bo wrote: MD's rdev_set_badblocks() expects that badblocks_set() returns 1 if badblocks are disabled, otherwise, rdev_set_badblocks() will record superblock changes and return success in that case and md will fail to report an IO error which it should. This bug has

Re: bfq: BUG bfq_queue: Objects remaining in bfq_queue on __kmem_cache_shutdown() after rmmod

Hi, On 12/08/2017 08:34 AM, Holger Hoffstätte wrote: So plugging in a device on USB with BFQ as scheduler now works without hiccup (probably thanks to Ming Lei's last patch), but of course I found another problem. Unmounting the device after use, changing the scheduler back to deadline or

Re: bfq: BUG bfq_queue: Objects remaining in bfq_queue on __kmem_cache_shutdown() after rmmod

On 12/21/2017 03:53 PM, Paolo Valente wrote: Il giorno 21 dic 2017, alle ore 08:08, Guoqing Jiang <gqji...@suse.com> ha scritto: Hi, On 12/08/2017 08:34 AM, Holger Hoffstätte wrote: So plugging in a device on USB with BFQ as scheduler now works without hiccup (probably thanks t

Re: [PATCH BUGFIX V2 1/2] block, bfq: put async queues for root bfq groups too

vein, bfqg_stats_xfer_dead is not executed for a root group. This commit fixes bfq_pd_offline so that the latter executes the above missing operations for a root group too. Reported-by: Holger Hoffstätte <hol...@applied-asynchrony.com> Reported-by: Guoqing Jiang <gqji...@suse.com>

Re: [PATCH BUGFIX V2 1/2] block, bfq: put async queues for root bfq groups too

On 01/10/2018 02:13 PM, Paolo Valente wrote: Il giorno 10 gen 2018, alle ore 02:41, Guoqing Jiang <gqji...@suse.com> ha scritto: On 01/09/2018 05:27 PM, Paolo Valente wrote: For each pair [device for which bfq is selected as I/O scheduler, group in blkio/io], bfq mai

Bug report - issue with bfq?

Hi, In my test, I found some issues when try bfq with xfs. The test basically just set the disk's scheduler to bfq, create xfs on top of it, mount fs and write something, then umount the fs. After several rounds of iteration, I can see different calltraces appeared. For example, the one which

Re: Bug report - issue with bfq?

On 01/03/2018 03:44 PM, Paolo Valente wrote: Il giorno 03 gen 2018, alle ore 04:58, Guoqing Jiang <gqji...@suse.com> ha scritto: Hi, Hi In my test, I found some issues when try bfq with xfs. The test basically just set the disk's scheduler to bfq, create xfs on top of it, mo