to be used.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Dan Williams <dan.j.willi...@intel.com>
Added for 4.8, thanks Dan.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
better to get build
breakage, than potentially much worse breakage.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/26/2016 03:13 AM, Hou Tao wrote:
'nr_undestroyed_grps' in struct throtl_data was used to count
the number of throtl_grp related with throtl_data, but now
throtl_grp is tracked by blkcg_gq, so it is useless anymore.
Thanks, applied.
--
Jens Axboe
--
To unsubscribe from this list: send
On 08/04/2016 01:59 PM, Mike Christie wrote:
On 08/04/2016 02:27 PM, Jens Axboe wrote:
On 08/04/2016 11:50 AM, kbuild test robot wrote:
Hi Mike,
[auto build test ERROR on linus/master]
[also build test ERROR on next-20160804]
[cannot apply to v4.7]
[if your patch is applied to the wrong git
nflict was
reduced. I just rebased the series on top of current master, and no new
->bi_rw usage has snuck in.
Please pull!
git://git.kernel.dk/linux-block.git for-linus
----
Jens Axboe (4):
block/mm: make bdev_ops->rw_page()
On 08/02/2016 05:32 AM, Christoph Hellwig wrote:
On Mon, Aug 01, 2016 at 01:55:36PM -0600, Jens Axboe wrote:
Set of three patches, where the target one is an actual bug fix...
Temporary branch, I'll rebase it once -rc1 is out, if more
changes/fixups need to be made in the next week until
On 08/15/2016 09:53 AM, Bart Van Assche wrote:
On 08/02/2016 10:21 AM, Jens Axboe wrote:
On 08/02/2016 06:58 AM, Jinpu Wang wrote:
Hi Jens,
I found in blk_mq_register_disk, we blk_mq_disable_hotplug which in
turn mutex_lock(_q_mutex);
queue_for_each_hw_ctx(q, hctx, i) {
ret
pos) == REQ_OP_SECURE_ERASE))
break;
This really should be a:
if (req_op(rq) != req_op(pos))
I'l lleave it up to Jens if he wants that in this patch or not, otherwise
I'll send an incremental patch.
Let's get a v2 with that fixed up, it makes a big readability
difference.
--
J
On 02/01/2017 02:40 PM, Dan Williams wrote:
> On Wed, Feb 1, 2017 at 2:35 PM, Jens Axboe <ax...@kernel.dk> wrote:
>> On 02/01/2017 02:05 PM, Dan Williams wrote:
>>> Warnings of the following form occur because scsi reuses a devt number
>>> while the block layer st
ister the bdi, blk_cleanup_queue().
>
> Thanks to Omar for the quick reproducer script [2]. This patch survives
> where an unmodified kernel fails in a few seconds.
What is the patch against? Doesn't seem to apply cleanly for me on
master, nor the 4.11 block tree.
--
Jens Axboe
--
To uns
>> fine to me.
>
> Yeah, probably it is not worth it. I'll remove it.
I agree on that, it should not be a hot path. Will you respin the series
after making this change? Would be great to get this queued up.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscrib
he removed blkg->q_node
> list node.
Thanks, applied.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/02/2017 02:15 PM, Paolo Valente wrote:
>
>> Il giorno 02 feb 2017, alle ore 16:30, Jens Axboe <ax...@fb.com> ha scritto:
>>
>> On 02/02/2017 02:19 AM, Paolo Valente wrote:
>>> The scheme is clear. One comment, in case it could make sense and
>>
commit/?h=for-4.11/next=e17354961bb50931ec7b33f59c0713dcf98ac7d2
It's caused by commit:
commit dc3b17cc8bf21307c7e076e7c778d5db756f7871
Author: Jan Kara <j...@suse.cz>
Date: Thu Feb 2 15:56:50 2017 +0100
block: Use pointer to backing_dev_info from request_queue
--
Jens Axboe
--
To
On 02/01/2017 01:11 PM, Josef Bacik wrote:
> To prepare for dynamically adding new nbd devices to the system switch
> from using an array for the nbd devices and instead use an idr. This
> copies what loop does for keeping track of its devices.
Applied for 4.11, thanks.
--
J
On 02/01/2017 01:11 PM, Josef Bacik wrote:
> Since we are in the memory reclaim path we need our recv work to be on a
> workqueue that has WQ_MEM_RECLAIM set so we can avoid deadlocks. Also
> set WQ_HIGHPRI since we are in the completion path for IO.
Applied for 4.11.
--
J
uest_queue *q = hctx->queue;
struct deadline_data *dd = q->elevator->elevator_data;
- int ret;
+ struct request *free = NULL;
+ bool ret;
spin_lock(>lock);
- ret = blk_mq_sched_try_merge(q, bio);
+ ret = blk_mq_sched_try_merge(q, bio, );
sistently
2) It has the same scope as the queue lock (the one you call the
scheduler lock)
mq-deadline sets up a per-queue structure, deadline_data, and it has a
lock embedded in that structure. This is what mq-deadline uses to
serialize access to its data structures, as well as those in the
On 02/03/2017 03:45 PM, Martin K. Petersen wrote:
>>>>>> "Jens" == Jens Axboe <ax...@kernel.dk> writes:
>
>>> I think we should fix sd.c to only send WRITE SAME if either of the
>>> variants are explicitly listed as supported through
On 01/31/2017 05:01 PM, Bart Van Assche wrote:
> On Tue, 2017-01-31 at 13:58 -0800, Jens Axboe wrote:
>> Interesting, I'll check this. Doesn't make any sense why the scheduler
>> would be implicated in that, given how we run completions now. But if
>> it complains, then
.
>
> - Interface cleanups for target implementations. Enables pblk to be
>simplified.
>
> - Fix memory leak on target creation failure.
>
> - Clean up end_io() path so that it follows the same approach as bio
> structures to end ios.
Applied for 4.11, thanks.
hrough
libata that would need to be added, before we can git rm drivers/ide/ ?
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/01/2017 08:46 AM, Bart Van Assche wrote:
> On Tue, 2017-01-31 at 22:38 -0800, Jens Axboe wrote:
>> I think this patch:
>>
>> http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.11/block=12d70958a2e8d587acaa51dafd5d6620e00b7543
>>
>> should fix it for yo
cache: enabled,
> supports DPO and FUA
> [6.647077] kobject (d5078ca4): tried to init an initialized object,
> something is seriously wrong.
So sda is probed twice, and hilarity ensues when we try to register it
twice. I can't reproduce this, using scsi_debug and with scsi_async
enabled.
This is running linux-next? What's your .config?
--
Jens Axboe
ccessfully and then the kernel
> hangs here.
>
> I believe something is broken recently, because I don't have any issue before
> Jan 31.
Can you try and bisect it?
--
Jens Axboe
On 02/08/2017 03:48 AM, Dexuan Cui wrote:
>> From: Jens Axboe [mailto:ax...@kernel.dk]
>> Sent: Wednesday, February 8, 2017 00:09
>> To: Dexuan Cui <de...@microsoft.com>; Bart Van Assche
>> <bart.vanass...@sandisk.com>; h...@suse.com; h...@suse.de
>> Cc:
):
block: don't try Write Same from __blkdev_issue_zeroout
block/blk-lib.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
--
Jens Axboe
omic_t for refcount
> * Get rid of free_on_put flag
Added for 4.11, thanks Jan!
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
structure, with the
> correct name, how could it have been created? Can't you save the dentry
> to the debugfs file in the structure that has the name?
The problem is that blktrace registers a trace name directory, which
can be either whole device or partition, depending on what you trace.
F
.
There should be no functional changes in this patch.
Signed-off-by: Jens Axboe <ax...@fb.com>
---
block/blk-merge.c | 31 ---
block/blk.h | 4 ++--
2 files changed, 18 insertions(+), 17 deletions(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
t worry about the IRQ disabling lock.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
them without any locks held, but for the case where we get
a successful request-to-request merge on the back of a bio-to-request
merge, we can invoke it with whatever lock the scheduler held when
it called blk_mq_sched_try_merge().
--
Jens Axboe
--
To unsubscribe from this list: send the line
problem of invoking parts of
the scheduler with an unknown lock state.
Reported-by: Paolo Valente <paolo.vale...@linaro.org>
Signed-off-by: Jens Axboe <ax...@fb.com>
---
block/blk-core.c | 12 +---
block/blk-merge.c| 15 ---
block/blk-mq-sched.c | 9 ++---
On 02/06/2017 12:53 PM, Omar Sandoval wrote:
> On Mon, Feb 06, 2017 at 12:39:57PM -0700, Jens Axboe wrote:
>> On 02/06/2017 12:24 PM, Omar Sandoval wrote:
>>> From: Omar Sandoval <osan...@fb.com>
>>>
>>> In blk_mq_sched_dispatch_requests(), we call blk_mq_
te Same from blkdev_issue_zeroout an don't try it
> at all from __blkdev_issue_zeroout as a non-invasive workaround.
Thanks, added for 4.10.
--
Jens Axboe
is is because we skip the initial
> elevator register/unregister when we don't have a ->request_fn(), but we
> should still do it for the ->mq_ops case.
Good catch Omar, applied.
--
Jens Axboe
> As the SCSI ioctl code is now optional, we really don't want to
> drag it in for DM, and the exception is not very useful anyway.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> Acked-by: Mike Snitzer <snit...@redhat.com>
Added, with the acks/reviews from Johannes and Pablo added.
--
Jens Axboe
On 02/03/2017 02:19 AM, Hou Tao wrote:
> If blkg_create fails, new_blkg passed as an argument will
> be freed by blkg_create, so there is no need to free it again.
Thanks, looks good to me. Applied.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe
iant of blkdev_issue_zeroout"). Before the commit, blkdev_issue_zeroout
> fell back to normal zero writing when WRITE SAME failed and it seems
> sd driver's heuristics depends on that behaviour.
CC Christoph and Chaitanya.
--
Jens Axboe
--
To unsubscribe from this list: send the line &
On 02/03/2017 09:12 AM, Christoph Hellwig wrote:
> On Fri, Feb 03, 2017 at 08:21:31AM -0700, Jens Axboe wrote:
>>> Error 121 (EREMOTEIO) was returned from blkdev_issue_zeroout().
>>> That came from sd driver because WRITE SAME was sent to the device
>>> which didn't s
ectories.
>
> I tested this with multiple configurations, so hopefully I didn't mess
> that up this time.
>
> Applies to for-4.11/block.
Applied with Greg's ack on the first patch, thanks Omar.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubsc
make life easier I also have a git
> tree available here:
>
> git://git.infradead.org/users/hch/block.git cmd_type
>
>
> http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/cmd_type
Looks good to me, applied for 4.11.
--
Jens Axboe
--
To unsubscri
> I'd gladly wrote one, getting tired of my current OSS work... :-)
Pretty sure I told Jeff originally that libata should only go into the
kernel, if there was a plan to make it independent of SCSI. A promise
was made that of course it would, but that promise was never held,
unfortunately.
--
On 02/01/2017 10:20 AM, Bart Van Assche wrote:
> Hello Jens,
>
> Please consider the four patches in this series for kernel v4.11.
Added, thanks Bart.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord
.
All three patches look good to me. Bjorn, to avoid complications, if
you can review/ack patch #2, then I will queue it up through the block
tree for 4.11.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.ker
On 02/01/2017 08:20 AM, Bart Van Assche wrote:
> Since __bio_map_user() and bio_map_user() have been removed, update
> the comments that still refer to these functions.
Applied, thanks Bart.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block&q
On 01/23/2017 08:49 AM, Alexander Potapenko wrote:
> On Mon, Jan 23, 2017 at 4:30 PM, Jens Axboe <ax...@fb.com> wrote:
>> On 01/23/2017 07:06 AM, Alexander Potapenko wrote:
>>> KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of
>>> unin
same clone and map method as the blk-mq version.
I'd like to get this in sooner rather than later, so I'll spend some
time reviewing and testing it start this week. I'm assuming you are
targeting 4.11 with this change, right?
--
Jens Axboe
--
To unsubscribe from this list: send the line &q
The onus is on the submitter here, not the reviewer.
As I said in the previous email, don't bother sending these types of
patches for the block layer again. They are just going to be ignored.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body
've used that in a few places in blk-mq, and in mm/filemap.c
as well:
commit 7fcbbaf18392f0b17c95e2f033c8ccf87eecde1d
Author: Jens Axboe <ax...@fb.com>
Date: Thu May 22 11:54:16 2014 -0700
mm/filemap.c: avoid always dirtying mapping->flags on O_DIRECT
the test_and_* functions always
arkus, don't bother sending those patches again for the block layer
or drivers, I'm not going to take them.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
tialized struct cfq_queue is created by kmem_cache_alloc_node()
> and then passed to cfq_init_cfqq(), which accesses cfqq->ioprio_class
> before it's initialized.
Patch looks fine to me, thanks. Is this a new warning? We don't seem
to have changed this path in a while, yet I wonder why
lls;
> looks like they're related to the 'stonewall' statement in fio.
I think you are heading down the wrong path. Your patch will cause
the symptoms to be a bit different, but you'll still run into cases
where we fail giving out the tag and then stall.
--
Jens Axboe
--
To unsubscribe from this list: se
ed to
shared tag maps, which I don't have anything that uses here. I'll see
if we are leaking it, you should be able to check that by reading the
'active' file in the sysfs directory.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body o
On 01/24/2017 11:49 AM, Hannes Reinecke wrote:
> On 01/24/2017 05:09 PM, Jens Axboe wrote:
>> On 01/24/2017 08:54 AM, Hannes Reinecke wrote:
>>> Hi Jens,
>>>
>>> I'm trying to debug a queue stall with your blk-mq-sched branch; with my
>>> latest mpt3s
On 01/24/2017 12:55 PM, Jens Axboe wrote:
> Try this patch. We only want to bump it for the driver tags, not the
> scheduler side.
More complete version, this one actually tested. I think this should fix
your issue, let me know.
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index a
On 01/26/2017 09:35 AM, Hannes Reinecke wrote:
> On 01/25/2017 11:27 PM, Jens Axboe wrote:
>> On 01/25/2017 10:42 AM, Jens Axboe wrote:
>>> On 01/25/2017 10:03 AM, Jens Axboe wrote:
>>>> On 01/25/2017 09:57 AM, Hannes Reinecke wrote:
>>>>> On 01/25/201
On 01/25/2017 10:42 AM, Jens Axboe wrote:
> On 01/25/2017 10:03 AM, Jens Axboe wrote:
>> On 01/25/2017 09:57 AM, Hannes Reinecke wrote:
>>> On 01/25/2017 04:52 PM, Jens Axboe wrote:
>>>> On 01/25/2017 04:10 AM, Hannes Reinecke wrote:
>>> [ .. ]
>>>
XEN_PAGE_SIZE != PAGE_SIZE (4KB vs 64KB
> on ARM for example) mishandling while the other is fixing
> the accounting for the configuration changes.
Pulled, thanks.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message
. If that happens, it's not enough to
mark the hardware queue as needing a restart, we need to bubble
that up to the higher level queue as well.
Signed-off-by: Jens Axboe <ax...@fb.com>
---
block/blk-mq-sched.c | 28
block/blk-mq-sched.h | 15 +--
We'll use the same criteria for whether we need to run the queue sync
or async when we have a scheduler, as we do without one.
Signed-off-by: Jens Axboe <ax...@fb.com>
---
block/blk-mq.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/blk-mq.c b/block/bl
;
> Jens, any opinion on just removing the printout of the SCSI CDB
> for blktrace?
Kill it with fire, I don't think there's much value to having it
there to begin with.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to
Once we mark the queue as needing a restart, re-check if we can
get a driver tag. This fixes a theoretical issue where the needed
IO completes _after_ blk_mq_get_driver_tag() fails, but before we
manage to set the restart bit.
Signed-off-by: Jens Axboe <ax...@fb.com>
---
block/blk-mq
On 01/26/2017 11:52 AM, Bart Van Assche wrote:
> On Thu, 2017-01-26 at 11:44 -0700, Jens Axboe wrote:
>> I think this may be my bug - does the below help?
>
> Hello Jens,
>
> What tree has that patch been generated against? It does not apply
> cleanly on top of Chri
On 01/26/2017 09:42 AM, Jens Axboe wrote:
> On 01/26/2017 09:35 AM, Hannes Reinecke wrote:
>> On 01/25/2017 11:27 PM, Jens Axboe wrote:
>>> On 01/25/2017 10:42 AM, Jens Axboe wrote:
>>>> On 01/25/2017 10:03 AM, Jens Axboe wrote:
>>>>> On 01/25/2017 09:
UA);
struct blk_plug *plug;
unsigned int request_count = 0;
- struct blk_mq_alloc_data data;
+ struct blk_mq_alloc_data data = { 0, };
struct request *rq;
blk_qc_t cookie;
unsigned int wb_acct;
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/26/2017 12:48 PM, Jens Axboe wrote:
> Once we mark the queue as needing a restart, re-check if we can
> get a driver tag. This fixes a theoretical issue where the needed
> IO completes _after_ blk_mq_get_driver_tag() fails, but before we
> manage to set the restart bit.
>
ow to sleep inside the queuecommand() callback
> function.
udelay() is a busy loop, so it's not sleeping. That said, it's obviously
NOT a great idea. We want to fix the reordering due to requeues, not
introduce random busy delays to work around it.
--
Jens Axboe
--
To unsubscribe fro
On 01/30/2017 11:28 AM, Kashyap Desai wrote:
>> -Original Message-
>> From: Jens Axboe [mailto:ax...@kernel.dk]
>> Sent: Monday, January 30, 2017 10:03 PM
>> To: Bart Van Assche; osan...@osandov.com; kashyap.de...@broadcom.com
>> Cc: linux-s...@vger.kernel.org
> On Jan 30, 2017, at 5:12 PM, Bart Van Assche <bart.vanass...@sandisk.com>
> wrote:
>
>> On Fri, 2017-01-27 at 09:56 -0700, Jens Axboe wrote:
>>> On 01/27/2017 09:52 AM, Bart Van Assche wrote:
>>> [ 215.724452] general protection fault:
On 01/30/2017 05:38 PM, Jens Axboe wrote:
>
>
>> On Jan 30, 2017, at 5:12 PM, Bart Van Assche <bart.vanass...@sandisk.com>
>> wrote:
>>
>>> On Fri, 2017-01-27 at 09:56 -0700, Jens Axboe wrote:
>>>> On 01/27/2017 09:52 AM, Bart Van Assche wrote:
;all.
>
> Fix the stub definitions and add a CONFIG_BLK_DEBUG_FS Kconfig option.
Thanks, added.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
(atomic_long_inc_not_zero(>count) != 0);
> }
Fix looks good to me, but let's drop the extraneous parentheses:
ret = atomic_long_inc_not_zero(>count) != 0;
in both spots. With that, you can add my
Reviewed-by: Jens Axboe <ax...@fb.com>
and let's fast-track this into 4.10.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/25/2017 04:10 AM, Hannes Reinecke wrote:
> On 01/25/2017 09:07 AM, Hannes Reinecke wrote:
>> On 01/25/2017 08:39 AM, Hannes Reinecke wrote:
>>> On 01/24/2017 11:06 PM, Jens Axboe wrote:
>>>> On 01/24/2017 12:55 PM, Jens Axboe wrote:
>>>
On 01/25/2017 10:03 AM, Jens Axboe wrote:
> On 01/25/2017 09:57 AM, Hannes Reinecke wrote:
>> On 01/25/2017 04:52 PM, Jens Axboe wrote:
>>> On 01/25/2017 04:10 AM, Hannes Reinecke wrote:
>> [ .. ]
>>>> Bah.
>>>>
>>>> Not quite. I'm s
On Fri, Jan 20 2017, Paolo Valente wrote:
>
> > Il giorno 20 gen 2017, alle ore 14:14, Paolo Valente
> > <paolo.vale...@linaro.org> ha scritto:
> >
> >>
> >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe <ax...@fb.com> ha
> >>
deletions(-)
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/26/2017 01:25 PM, Omar Sandoval wrote:
> On Thu, Jan 26, 2017 at 12:48:17PM -0700, Jens Axboe wrote:
>> If we have both multiple hardware queues and shared tag map between
>> devices, we need to ensure that we propagate the hardware queue
>> restart bit higher up. This
On 01/26/2017 11:59 AM, h...@lst.de wrote:
> On Thu, Jan 26, 2017 at 11:57:36AM -0700, Jens Axboe wrote:
>> It's against my for-4.11/block, which you were running under Christoph's
>> patches. Maybe he's using an older version? In any case, should be
>> pretty trivial for yo
On 01/26/2017 01:54 PM, Omar Sandoval wrote:
> On Thu, Jan 26, 2017 at 12:48:18PM -0700, Jens Axboe wrote:
>> When we invoke dispatch_requests(), the scheduler empties everything
>> into the passed in list. This isn't always a good thing, since it
>> means that we remove ite
On 01/26/2017 06:22 PM, Jens Axboe wrote:
> On 01/26/2017 06:15 PM, Bart Van Assche wrote:
>> On Thu, 2017-01-26 at 17:41 -0700, Jens Axboe wrote:
>>> On 01/26/2017 05:38 PM, Bart Van Assche wrote:
>>>> I see similar behavior with the blk-mq-sched branch of
>>&g
On 01/26/2017 11:40 PM, Jens Axboe wrote:
> On 01/26/2017 06:22 PM, Jens Axboe wrote:
>> On 01/26/2017 06:15 PM, Bart Van Assche wrote:
>>> On Thu, 2017-01-26 at 17:41 -0700, Jens Axboe wrote:
>>>> On 01/26/2017 05:38 PM, Bart Van Assche wrote:
>>>>>
On 01/27/2017 05:10 AM, Hannes Reinecke wrote:
> On 01/26/2017 08:48 PM, Jens Axboe wrote:
>> I've been diving into the problems that Hannes reported, both the
>> stalls related to shared tag maps and multiple hardware queues,
>> but also the cases where we g
hat we often want but don't
>have when debugging a live system.
Thanks Omar, applied for 4.11. The series has already been helpful in
root causing a stall.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to maj
mall cleanup in dm-rq
I've queued this up for 4.11. Since some of the patches had dependencies
on changes in master since for-4.11/block was forked, they are sitting
in a separate branch that has both for-4.11/block and v4.10-rc5 pulled
in first. for-next has everything, as usual.
--
Jens Axb
On 01/27/2017 09:23 AM, Christoph Hellwig wrote:
> On Fri, Jan 27, 2017 at 09:21:46AM -0700, Jens Axboe wrote:
>> On 01/27/2017 09:17 AM, Christoph Hellwig wrote:
>>> On Fri, Jan 27, 2017 at 09:11:14AM -0700, Jens Axboe wrote:
>>>> I've queued this up for 4.11.
On 01/27/2017 09:17 AM, Christoph Hellwig wrote:
> On Fri, Jan 27, 2017 at 09:11:14AM -0700, Jens Axboe wrote:
>> I've queued this up for 4.11. Since some of the patches had dependencies
>> on changes in master since for-4.11/block was forked, they are sitting
>> in a separate
h and Martin,
>
> How about using the function names alloc_full_request() / free_full_request()
> together with a comment that mentions that cmd_size is set by the LLD?
Since we use pdu in other places, how about alloc_request_pdu() or
alloc_request_with_pdu()?
And since it's all queued up, any bike
On 01/27/2017 09:34 AM, Christoph Hellwig wrote:
> On Fri, Jan 27, 2017 at 09:27:02AM -0700, Jens Axboe wrote:
>> Feel free to repost it, I have no problem rebasing that branch as it's
>> standalone for now.
>
> Ok, I'll repost what I have right now, which is on top of a
On 01/26/2017 06:15 PM, Bart Van Assche wrote:
> On Thu, 2017-01-26 at 17:41 -0700, Jens Axboe wrote:
>> On 01/26/2017 05:38 PM, Bart Van Assche wrote:
>>> I see similar behavior with the blk-mq-sched branch of
>>> git://git.kernel.dk/linux-block.git (git commit ID
On 01/26/2017 01:47 PM, Bart Van Assche wrote:
> On 01/26/2017 11:01 AM, Jens Axboe wrote:
>> On 01/26/2017 11:59 AM, h...@lst.de wrote:
>>> On Thu, Jan 26, 2017 at 11:57:36AM -0700, Jens Axboe wrote:
>>>> It's against my for-4.11/block, which you were running under C
On 01/26/2017 04:50 PM, Jens Axboe wrote:
> On 01/26/2017 04:47 PM, Bart Van Assche wrote:
>> On Thu, 2017-01-26 at 16:26 -0700, Jens Axboe wrote:
>>> What device is stuck? Is it running with an mq scheduler attached, or
>>> with "none"?
>>>
>>&
On 01/26/2017 05:38 PM, Bart Van Assche wrote:
> On Thu, 2017-01-26 at 16:50 -0700, Jens Axboe wrote:
>> Clearly we are missing some requests. How do I setup dm similarly to
>> you?
>>
>> Does it reproduce without Christoph's patchset?
>
> Hello Jens,
>
>
*q,
rq = __blk_mq_alloc_request(data, op);
} else {
rq = __blk_mq_alloc_request(data, op);
- data->hctx->tags->rqs[rq->tag] = rq;
+ if (rq)
+ data->hctx->tags->rqs[rq->tag] = rq;
}
back to const
> Cleaned up opal_lock_unlock
>
> v1->v2:
> Moved misplaced code from 5/5 to 4/5
Guys, where are we at with this? I'm shipping off some more fixes
for -rc1 soon, and I'd really like to get this wrapped up sooner
rather than later.
--
Jens Axboe
efault for blk-mq
managed block devices with a single queue.
--
Jens Axboe
On 02/20/2017 09:16 AM, Bart Van Assche wrote:
> On 02/19/2017 11:35 PM, Christoph Hellwig wrote:
>> On Sun, Feb 19, 2017 at 06:15:41PM -0700, Jens Axboe wrote:
>>> That said, we will look into this again, of course. Christoph, any idea?
>>
>> No idea really - this s
On 02/20/2017 08:41 AM, James Bottomley wrote:
> On Mon, 2017-02-20 at 08:15 -0700, Jens Axboe wrote:
>> On 02/20/2017 04:16 AM, Elena Reshetova wrote:
>>> Now when new refcount_t type and API are finally merged
>>> (see include/linux/refcount.h), the following
ere is
it merged? Don't send code like this without the necessary
infrastructure being in mainline.
--
Jens Axboe
1 - 100 of 2703 matches
Mail list logo
