Since commit 3942d2991852 ("mm/slab_common: allow NULL cache
pointer in kmem_cache_destroy()"), the kmem_cache_destroy()
function has been able to handle null pointers. Remove NULL
check against e->icq_cache in elv_register(), simplifying the code.
Signed-off-by: John Pittma
Ha! Ok, thanks for reviewing Jens.
On Thu, Aug 30, 2018 at 4:00 PM, Jens Axboe wrote:
> On 8/30/18 1:56 PM, John Pittman wrote:
>> Since commit 3942d2991852 ("mm/slab_common: allow NULL cache
>> pointer in kmem_cache_destroy()"), the kmem_cache_destroy()
>> functi
NUMA_NO_NODE.
Signed-off-by: John Pittman
---
drivers/block/null_blk_main.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
index 417a9f15c116..c7fb7a133c8d 100644
--- a/drivers/block/null_blk_main.c
+++ b/drivers/block
i, Apr 5, 2019 at 6:22 PM Jens Axboe wrote:
>
> On 4/5/19 3:42 PM, John Pittman wrote:
> > At module load, if the selected home_node value is greater than
> > the available numa nodes, the system will crash in
> > __alloc_pages_nodemask() due to a bad paging request. Preve
Yep, yours works better. :) Thanks a lot Jens.
On Sat, Apr 6, 2019 at 12:50 PM Jens Axboe wrote:
>
> On 4/6/19 8:47 AM, John Pittman wrote:
> > Hi Jens, I got some unexpected results with this patch this morning.
> > When loading null_blk with no arguments, I got the
While troubleshooting issues where cloned request limits have been
exceeded, it is often beneficial to know the actual values that
have been breached. Print these values, assisting in ease of
identification of root cause of the breach.
Signed-off-by: John Pittman
---
block/blk-core.c | 7
#x27;s from an admin or script setting
bad stacking values.
On Thu, May 23, 2019 at 9:58 PM Ming Lei wrote:
>
> On Fri, May 24, 2019 at 5:50 AM John Pittman wrote:
> >
> > While troubleshooting issues where cloned request limits have been
> > exceeded, it is often benefi
printk(KERN_ERR "%s: over max segments limit. (%hu > %hu)\n",
>
> In either case,
>
> Reviewed-by: Chaitanya Kulkarni .
>
> On 5/23/19 2:49 PM, John Pittman wrote:
> > While troubleshooting issues where cloned request limits have been
> >
Hi Jens. Does this patch seem reasonable?
On Fri, May 24, 2019 at 12:51 PM Chaitanya Kulkarni
wrote:
>
> Let's leave it to Jens.
>
> On 5/24/19 5:19 AM, John Pittman wrote:
> > Thanks Chaitanya for the review. I was not sure what Jens would think
> > about the che
he failure, additionally adding to the documentation
that CONFIG_BLK_DEV_ZONED is needed for zoned=1.
Signed-off-by: John Pittman
---
Documentation/block/null_blk.txt | 3 ++-
drivers/block/null_blk.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/block/null
he failure, additionally adding to the documentation
that CONFIG_BLK_DEV_ZONED is needed for zoned=1.
Signed-off-by: John Pittman
---
Documentation/block/null_blk.txt | 3 ++-
drivers/block/null_blk.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/block/null
level driver would have to hook
in and enable these features manually. Thanks for your time and any
information.
John
On Fri, Jan 4, 2019 at 11:47 AM Bart Van Assche wrote:
>
> On Fri, 2019-01-04 at 10:42 -0500, John Pittman wrote:
> > static inline int null_zone_init
Thanks Bart, I appreciate it.
On Fri, Jan 4, 2019 at 3:49 PM Bart Van Assche wrote:
>
> On Fri, 2019-01-04 at 15:37 -0500, John Pittman wrote:
> > Thanks Bart; I made the changes and sent them in as a v2, I'm sure you
> > already saw. I have a quick, unrelated questi
On Fri, Jan 4, 2019 at 4:49 PM Bart Van Assche wrote:
>
> On Fri, 2019-01-04 at 12:06 -0500, John Pittman wrote:
> > If the kernel is built without CONFIG_BLK_DEV_ZONED, a modprobe
> > of the null_blk driver with zoned=1 fails with 'Invalid argument'.
> >
Support for discard was added to the null_blk driver in 'commit
306eb6b4ad4f ("nullb: support discard")'. For ease of use in
benchmarking and target testing, enable this support by default.
Signed-off-by: John Pittman
---
drivers/block/null_blk_main.c | 1 +
1 file
Of the tunables available for the bfq I/O scheduler,
the only one missing from the documentation in
'Documentation/block/bfq-iosched.txt' is slice_idle_us.
Add this tunable to the documentation and a short
explanation of its purpose.
Signed-off-by: John Pittman
---
Documentation
Thanks; noted.
On Wed, Jan 9, 2019 at 9:39 AM Jens Axboe wrote:
>
> On 1/8/19 2:56 PM, John Pittman wrote:
> > Of the tunables available for the bfq I/O scheduler,
> > the only one missing from the documentation in
> > 'Documentation/block/bfq-iosched.txt' is s
ING: Prefer 'unsigned int *' to bare use of 'unsigned *'
Fixed 64 total warnings.
Signed-off-by: John Pittman
---
block/badblocks.c| 4 ++--
block/bio-integrity.c| 4 ++--
block/bio.c | 8
block/blk-core.c | 2 +-
18 matches
Mail list logo
