On Thu, 2018-05-10 at 15:16 +, Bart Van Assche wrote:
> On Fri, 2018-05-04 at 16:42 -0400, Laurence Oberman wrote:
> > I was never able to reproduce Barts original issue using his tree
> > and
> > actual mlx5/cx4 hardware and ibsrp
> > I enabled BFQ with no other s
On Thu, 2018-05-10 at 18:28 +0800, Ming Lei wrote:
> On Sat, May 05, 2018 at 07:11:33PM -0400, Laurence Oberman wrote:
> > On Sat, 2018-05-05 at 21:58 +0800, Ming Lei wrote:
> > > Hi,
> > >
> > > The 1st patch introduces blk_quiesce_timeout() and
> >
gt; block/blk-mq-sched.c | 14 --
> block/blk-mq.c | 44 --
> --
> include/linux/blk-mq.h | 3 ++-
> 4 files changed, 51 insertions(+), 19 deletions(-)
>
> Cc: Kashyap Desai
> Cc: Laurence Oberman
> Cc: Omar Sandoval
> Cc: Christoph Hellwig
&g
t; if (ret)
> goto cleanup;
> } else {
> + zero_fill_bio(bio);
> iov_iter_advance(iter, bio->bi_iter.bi_size);
> }
>
Straightforward, looks good from my view.
Reviewed-by:
Laurence Oberman
On Thu, 2018-11-08 at 08:42 -0700, Jens Axboe wrote:
> +static bool blk_mq_check_busy(struct blk_mq_hw_ctx *hctx, struct
> request *rq,
> + void *priv, bool reserved)
> +{
> + bool *busy = (bool *) priv;
> +
> + /*
> + * If we find a request, we know t
LK_STS_OK if one of these functions is called. This
> > > patch
> > > avoids that blk_mq_dispatch_rq_list() crashes when using dm-
> > > mpath.
> > >
> > > Cc: Christoph Hellwig
> > > Cc: Hannes Reinecke
> > > Cc: James Smart
&
On Thu, 2019-04-04 at 08:28 -0700, Bart Van Assche wrote:
> On Thu, 2019-04-04 at 11:09 -0400, Laurence Oberman wrote:
> > When I bisected and got to that commit I was unable to revert it to
> > test without it.
> > I showed that in an earlier update, had merge issues.
> &g
On Thu, 2019-04-04 at 08:28 -0700, Bart Van Assche wrote:
> On Thu, 2019-04-04 at 11:09 -0400, Laurence Oberman wrote:
> > When I bisected and got to that commit I was unable to revert it to
> > test without it.
> > I showed that in an earlier update, had merge issues.
> &g
27;false' in
> > blk_mq_sched_insert_requests") # v5.0.
> > * 7f556a44e61d ("blk-mq: refactor the code of issue request
> > directly") # v5.0.
>
> I am fine to revert them now.
>
> However, could you revert them one by one so that they can be
> reviewed
On Fri, 2019-04-05 at 08:06 +0200, Christoph Hellwig wrote:
> On Thu, Apr 04, 2019 at 10:08:43AM -0700, Bart Van Assche wrote:
> > blk_mq_try_issue_directly() can return BLK_STS*_RESOURCE for
> > requests that
> > have been queued. If that happens when blk_mq_try_issue_directly()
> > is called
> >
please test this patch to see whether the issue could be
> fixed ?
>
> Thanks
> Jianchao
> >
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index a9c1816..a3394f2 100644
> > --- a/block/blk-mq.c
> > +++ b/block/blk-mq.c
> > @@ -1813,7 +1813,7
On Fri, 2018-11-16 at 14:28 -0500, Mike Snitzer wrote:
> On Fri, Nov 16 2018 at 5:17am -0500,
> Christoph Hellwig wrote:
>
> > On Fri, Nov 16, 2018 at 11:06:32AM +0100, Hannes Reinecke wrote:
> > > Ok, so would you be happy with making ANA support configurable?
> >
> > I've looked a bit over th
On Mon, 2018-12-10 at 12:17 +0100, Christoph Hellwig wrote:
> On Sun, Dec 09, 2018 at 07:08:14PM -0800, Bart Van Assche wrote:
> > According to what I found in
> > https://bugzilla.kernel.org/show_bug.cgi?id=201935 patch "block:
> > Clear
> > kernel memory before copying to user" broke tape access.
On Mon, 2018-12-10 at 08:36 -0700, Jens Axboe wrote:
> On 12/10/18 8:32 AM, Keith Busch wrote:
> > On Sun, Dec 09, 2018 at 07:08:14PM -0800, Bart Van Assche wrote:
> > > According to what I found in
> > > https://bugzilla.kernel.org/show_bug.cgi?id=201935 patch "block:
> > > Clear
> > > kernel memo
uffer: 1
[ 103.199711] st 2:0:0:0: [st0] Block size: 0, buffer size: 4096 (1
blocks).
[ 104.109081] st 2:0:0:0: [st0] Rewinding tape.
Tested and works fine.
Thanks All
Tested-by: Laurence Oberman
On Wed, 2019-01-02 at 15:29 +, Sitsofe Wheeler wrote:
> (Also trying linux-ide list)
>
> On Wed, 2 Jan 2019 at 15:25, Sitsofe Wheeler
> wrote:
> >
> > Hi,
> >
> > I recently purchased a SATA Samsung 860 EVO SSD and put it in an
> > old
> > HP microserver (which has an AMD N36L). By default,
On Wed, 2019-01-02 at 11:10 -0500, Laurence Oberman wrote:
> On Wed, 2019-01-02 at 15:29 +, Sitsofe Wheeler wrote:
> > (Also trying linux-ide list)
> >
> > On Wed, 2 Jan 2019 at 15:25, Sitsofe Wheeler
> > wrote:
> > >
> > > Hi,
> > >
On Thu, 2019-01-03 at 13:28 -0500, Laurence Oberman wrote:
> On Wed, 2019-01-02 at 11:10 -0500, Laurence Oberman wrote:
> > On Wed, 2019-01-02 at 15:29 +, Sitsofe Wheeler wrote:
> > > (Also trying linux-ide list)
> > >
> > > On Wed, 2 Jan 2019 at
On Thu, 2019-01-03 at 22:24 +, Sitsofe Wheeler wrote:
> Hi,
>
> On Thu, 3 Jan 2019 at 20:47, Laurence Oberman
> wrote:
> >
> > Hello
> >
> > I put the 860 in an enclosure (MSA50) driven by a SAS HBA
> > (megaraid)sas)
> >
> > The b
ed\n");
> return -EINVAL;
> }
> static inline void null_zone_exit(struct nullb_device *dev) {}
Looks good to me, useful change in my opinion.
Reviewed-by: Laurence Oberman
On Fri, 2019-01-04 at 08:46 -0800, Bart Van Assche wrote:
> On Fri, 2019-01-04 at 10:42 -0500, John Pittman wrote:
> > static inline int null_zone_init(struct nullb_device *dev)
> > {
> > + pr_info("CONFIG_BLK_DEV_ZONED not enabled\n");
> > return -EINVAL;
> > }
>
> Have you considered to
; --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Hello
I took Bart's latest patches from his tree and tested all
- Original Message -
> From: "Bart Van Assche"
> To: "Jens Axboe"
> Cc: "Christoph Hellwig" , "James Bottomley"
> , "Martin K. Petersen"
> , "Mike Snitzer" , "Doug
> Ledford" , "Keith
&g
On Wed, 2017-11-08 at 10:57 -0700, Jens Axboe wrote:
> On 11/08/2017 09:41 AM, Bart Van Assche wrote:
> > On Tue, 2017-11-07 at 20:06 -0700, Jens Axboe wrote:
> > > At this point, I have no idea what Bart's setup looks like. Bart,
> > > it
> > > would be REALLY helpful if you could tell us how you
On Fri, 2018-01-12 at 20:57 +, Bart Van Assche wrote:
> On Tue, 2018-01-09 at 08:29 -0800, Tejun Heo wrote:
> > Currently, blk-mq timeout path synchronizes against the usual
> > issue/completion path using a complex scheme involving atomic
> > bitflags, REQ_ATOM_*, memory barriers and subtle me
On Mon, 2018-01-15 at 18:43 +0100, Thomas Gleixner wrote:
> On Tue, 16 Jan 2018, Ming Lei wrote:
> > These two patches fixes IO hang issue reported by Laurence.
> >
> > 84676c1f21 ("genirq/affinity: assign vectors to all possible CPUs")
> > may cause one irq vector assigned to all offline CPUs, th
On Tue, 2018-01-16 at 12:25 +0100, Thomas Gleixner wrote:
> On Tue, 16 Jan 2018, Ming Lei wrote:
>
> > On Mon, Jan 15, 2018 at 09:40:36AM -0800, Christoph Hellwig wrote:
> > > On Tue, Jan 16, 2018 at 12:03:43AM +0800, Ming Lei wrote:
> > > > Hi,
> > > >
> > > > These two patches fixes IO hang iss
On Tue, 2018-01-16 at 15:22 +, Don Brace wrote:
> > -Original Message-
> > From: Laurence Oberman [mailto:lober...@redhat.com]
> > Sent: Tuesday, January 16, 2018 7:29 AM
> > To: Thomas Gleixner ; Ming Lei > .com>
> > Cc: Christoph Hellwi
On Wed, 2018-01-17 at 23:31 +, Bart Van Assche wrote:
> On Wed, 2018-01-17 at 11:58 -0500, Mike Snitzer wrote:
> > On Wed, Jan 17 2018 at 11:50am -0500,
> > Jens Axboe wrote:
> >
> > > On 1/17/18 9:25 AM, Mike Snitzer wrote:
> > > > Hi Jens,
> > > >
> > > > Think this finally takes care of i
On Wed, 2018-01-17 at 23:53 +, Bart Van Assche wrote:
> On Wed, 2018-01-17 at 18:43 -0500, Laurence Oberman wrote:
> > On Wed, 2018-01-17 at 23:31 +, Bart Van Assche wrote:
> > > On Wed, 2018-01-17 at 11:58 -0500, Mike Snitzer wrote:
> > > > On Wed
t, and
> > what we need to do is to return the queue busy info to caller, so
> > that caller can deal with it well.
> >
> > Fixes: 396eaf21ee ("blk-mq: improve DM's blk-mq IO merging via
> > blk_insert_cloned_request feedback")
> > Rep
On Thu, 2018-01-18 at 16:23 -0500, Mike Snitzer wrote:
> On Thu, Jan 18 2018 at 3:58P -0500,
> Bart Van Assche wrote:
>
> > On Thu, 2018-01-18 at 15:48 -0500, Mike Snitzer wrote:
> > > For Bart's test the underlying scsi-mq driver is what is
> > > regularly
> > > hitting this case in __blk_mq_tr
On Thu, 2018-01-18 at 17:01 -0500, Mike Snitzer wrote:
> On Thu, Jan 18 2018 at 4:39pm -0500,
> Bart Van Assche wrote:
>
> > On Thu, 2018-01-18 at 16:23 -0500, Mike Snitzer wrote:
> > > On Thu, Jan 18 2018 at 3:58P -0500,
> > > Bart Van Assche wrote:
> > >
> > > > On Thu, 2018-01-18 at 15:48
On Thu, 2018-01-18 at 22:24 +, Bart Van Assche wrote:
> On Thu, 2018-01-18 at 17:18 -0500, Laurence Oberman wrote:
> > OK, I ran 5 at once of 5 separate mount points.
> > I am using 4k block sizes
> > Its solid consistent for me. No stalls no gaps.
>
> Hi Laurence,
; srpt_handle_new_iu+0x61e/0x7f0 [ib_srpt]
> __ib_process_cq+0x55/0xa0 [ib_core]
> ib_cq_poll_work+0x1b/0x60 [ib_core]
> process_one_work+0x141/0x340
> worker_thread+0x47/0x3e0
> kthread+0xf5/0x130
> ret_from_fork+0x1f/0x30
>
> Fixes: e80a0af4759a ("lib/scatterlist: In
On Tue, 2018-01-23 at 09:44 -0500, Mike Snitzer wrote:
> On Tue, Jan 23 2018 at 9:27am -0500,
> Ming Lei wrote:
>
> > Hello Martin,
> >
> > On Tue, Jan 23, 2018 at 08:30:41AM -0500, Martin K. Petersen wrote:
> > >
> > > Ming,
> > >
> > > > + * Block layer and block driver specific status, whi
On Sun, 2018-01-28 at 16:57 +, Bart Van Assche wrote:
> On Sat, 2018-01-27 at 23:58 -0500, Mike Snitzer wrote:
> > On Sat, Jan 27 2018 at 10:00pm -0500,
> > Bart Van Assche wrote:
> >
> > > On Sat, 2018-01-27 at 21:03 -0500, Mike Snitzer wrote:
> > > > You cannot even be forthcoming about the
On Tue, 2018-01-30 at 09:52 -0800, Bart Van Assche wrote:
> On 01/30/18 06:24, Mike Snitzer wrote:
> > + *
> > + * If driver returns BLK_STS_RESOURCE and
> > SCHED_RESTART
> > + * bit is set, run queue after a delay to avoid IO
> > stalls
> > + * that cou
; Cc: Don Brace
> Cc: Kashyap Desai
> Cc: Peter Rivera
> Cc: Paolo Bonzini
> Cc: Mike Snitzer
> Tested-by: Laurence Oberman
> Signed-off-by: Ming Lei
> ---
> drivers/scsi/hpsa.c | 51 ++-
>
> 1 file changed, 3
On 07/07/2017 11:03 AM, Jens Axboe wrote:
On 07/07/2017 09:00 AM, Christoph Hellwig wrote:
On Thu, Jul 06, 2017 at 12:55:04PM +0300, Meelis Roos wrote:
Also we're trying to move people away from the cciss driver, can you
check if the hpsa SCSI driver works for you as well?
I have older adap
On 07/07/2017 02:08 PM, Christoph Hellwig wrote:
On Fri, Jul 07, 2017 at 11:42:38AM -0400, Laurence Oberman wrote:
What happens when hpsa_allow_any=1 with the Smart Array 64xx
It should probe.
But only if it has a HP vendor ID as far as I can tell. We'd
still need to add the compaq i
fine for me. I did uncover another issue that is
unrelated to these patches and also exists in 4.13-RC3 generic that I am
still debugging.
For what its worth:
Tested-by: Laurence Oberman
On 08/07/2017 11:27 AM, Bart Van Assche wrote:
On Mon, 2017-08-07 at 08:48 -0400, Laurence Oberman wrote:
I tested this series using Ming's tests as well as my own set of tests
typically run against changes to upstream code in my SRP test-bed.
My tests also include very large seque
On 08/07/2017 01:29 PM, Laurence Oberman wrote:
On 08/07/2017 11:27 AM, Bart Van Assche wrote:
On Mon, 2017-08-07 at 08:48 -0400, Laurence Oberman wrote:
I tested this series using Ming's tests as well as my own set of tests
typically run against changes to upstream code in my SRP tes
On 08/07/2017 02:46 PM, Laurence Oberman wrote:
On 08/07/2017 01:29 PM, Laurence Oberman wrote:
On 08/07/2017 11:27 AM, Bart Van Assche wrote:
On Mon, 2017-08-07 at 08:48 -0400, Laurence Oberman wrote:
I tested this series using Ming's tests as well as my own set of tests
typicall
On 08/08/2017 09:41 AM, Ming Lei wrote:
Hi Laurence and Guys,
On Mon, Aug 07, 2017 at 06:06:11PM -0400, Laurence Oberman wrote:
On Mon, Aug 7, 2017 at 8:48 AM, Laurence Oberman
wrote:
Hello
I need to retract my Tested-by:
While its valid that the patches do not introduce performance
On Tue, 2017-08-08 at 22:17 +0800, Ming Lei wrote:
> Hi Guys,
>
> Laurence and I see a system lockup issue when running concurrent
> big buffered write(4M bytes) to IB SRP on v4.13-rc3.
>
> 1 how to reproduce
>
> 1) setup IB_SRR & multi path
>
> #./start_opensm.sh
> #./start_srp.sh
On Tue, 2017-08-08 at 20:11 -0400, Laurence Oberman wrote:
> > On Tue, 2017-08-08 at 22:17 +0800, Ming Lei wrote:
> > > > Hi Guys,
> > > >
> > > > Laurence and I see a system lockup issue when running
> > concurrent
> > > > big buffere
On 08/08/2017 10:28 PM, Laurence Oberman wrote:
On Tue, 2017-08-08 at 20:11 -0400, Laurence Oberman wrote:
On Tue, 2017-08-08 at 22:17 +0800, Ming Lei wrote:
Hi Guys,
Laurence and I see a system lockup issue when running
concurrent
big buffered write(4M bytes) to IB SRP on v4.13-rc3
On Wed, 2018-02-28 at 23:21 +0800, Ming Lei wrote:
> On Wed, Feb 28, 2018 at 08:28:48PM +0530, Kashyap Desai wrote:
> > Ming -
> >
> > Quick testing on my setup - Performance slightly degraded (4-5%
> > drop)for
> > megaraid_sas driver with this patch. (From 1610K IOPS it goes to
> > 1544K)
> > I
lwig ; Mike Snitzer
> > Cc: linux-s...@vger.kernel.org; Hannes Reinecke ;
> > Arun Easi
> > ; Omar Sandoval ; Martin K .
> > Petersen ; James Bottomley
> > ; Christoph Hellwig > .de>;
> > Don Brace ; Kashyap Desai
> > ; Peter Rivera > om>;
> > Laurenc
On Thu, 2018-03-01 at 14:01 -0500, Laurence Oberman wrote:
> On Thu, 2018-03-01 at 16:18 +, Don Brace wrote:
> > > -Original Message-
> > > From: Ming Lei [mailto:ming@redhat.com]
> > > Sent: Tuesday, February 27, 2018 4:08 AM
> > > To: J
et above
All functional I/O tests and boot tests passed with multiple concurrent
fio runs.
Original HPSA booting issue is also resolved and its important or we
will have to revert original genirq commit
commit 84676c1f21e8ff54befe985f4f14dc1edc10046b
Tested-by: Laurence Oberman
Thanks
Laurence
On Fri, 2018-03-02 at 10:16 +0800, Ming Lei wrote:
> On Thu, Mar 01, 2018 at 04:19:34PM -0500, Laurence Oberman wrote:
> > On Thu, 2018-03-01 at 14:01 -0500, Laurence Oberman wrote:
> > > On Thu, 2018-03-01 at 16:18 +, Don Brace wrote:
> > > > > -Original
On Fri, 2018-03-02 at 15:03 +, Don Brace wrote:
> > -Original Message-
> > From: Laurence Oberman [mailto:lober...@redhat.com]
> > Sent: Friday, March 02, 2018 8:09 AM
> > To: Ming Lei
> > Cc: Don Brace ; Jens Axboe > k>;
> > linux-block@vge
/8 from the V3 series.
No issues running workload and no issues booting on the DL380G7.
Don can you ack this so we can at least get this one in.
Against: 4.16.0-rc4.v31of8+ on an x86_64
Tested-by: Laurence Oberman
Thanks
Laurence
On Thu, 2018-03-08 at 21:42 +0800, Ming Lei wrote:
> On Wed, Mar 07, 2018 at 09:11:37AM -0500, Laurence Oberman wrote:
> > On Tue, 2018-03-06 at 14:24 -0500, Martin K. Petersen wrote:
> > > Ming,
> > >
> > > > Given both Don and Laurence have verified that p
ding regression.
>
> Reported-by: Laurence Oberman
> Cc: Ewan Milne
> Cc: Stefan Haberland
> Cc: Christian Borntraeger
> Cc: Christoph Hellwig
> Cc: Sagi Grimberg
> Signed-off-by: Ming Lei
> ---
> block/blk-mq.c | 34 +++---
>
On Fri, 2018-04-27 at 15:48 +, Bart Van Assche wrote:
> On Fri, 2018-04-27 at 09:39 -0600, Jens Axboe wrote:
> > blk_mq_tagset_busy_iter(&shost->tag_set, scsi_host_check_in_flight,
> > &in_flight);
> > return in_flight.cnt + atomic_read(&shost->host_busy);
> >
> > The atomi
On Fri, 2018-05-04 at 22:11 +0200, Paolo Valente wrote:
> > Il giorno 30 mar 2018, alle ore 18:57, Bart Van Assche > c...@wdc.com> ha scritto:
> >
> > On Fri, 2018-03-30 at 10:23 +0200, Paolo Valente wrote:
> > > Still 4.16-rc1, being that the version for which you reported
> > > this
> > > issue
+-
> drivers/nvme/host/nvme.h | 5 +
> drivers/nvme/host/pci.c | 304
> ---
> include/linux/blkdev.h | 13 ++
> 7 files changed, 356 insertions(+), 47 deletions(-)
>
> Cc: Jianchao Wang
> Cc: Christoph Hellwig
> Cc: Sa
On Sat, 2018-05-05 at 19:11 -0400, Laurence Oberman wrote:
> On Sat, 2018-05-05 at 21:58 +0800, Ming Lei wrote:
> > Hi,
> >
> > The 1st patch introduces blk_quiesce_timeout() and
> > blk_unquiesce_timeout()
> > for NVMe, meantime fixes blk_sync_queue().
> >
On Sat, 2018-05-05 at 19:31 -0400, Laurence Oberman wrote:
> On Sat, 2018-05-05 at 19:11 -0400, Laurence Oberman wrote:
> > On Sat, 2018-05-05 at 21:58 +0800, Ming Lei wrote:
> > > Hi,
> > >
> > > The 1st patch introduces blk_quiesce_timeout() and
> >
- Original Message -
> From: "Jan Kara"
> To: "Johannes Weiner"
> Cc: "Hugh Dickins" , "Linus Torvalds"
> , "Dave Chinner"
> , "Chris Leech" , "Linux Kernel
> Mailing List"
> , "Lee Duncan" ,
> open-is...@googlegroups.com, "Linux SCSI List"
> , linux-block@vger.kernel.org, "Christoph
- Original Message -
> From: "Laurence Oberman"
> To: "Jan Kara"
> Cc: "Johannes Weiner" , "Hugh Dickins"
> , "Linus Torvalds"
> , "Dave Chinner" , "Chris
> Leech" , "Linux
> Kernel
. It
is therefore not going to
be released to the general public. When it's finished, and it isn't at
the moment, it's hopefully going to be part of your future processors.
"
Regards
Laurence Oberman
66 matches
Mail list logo
