It is possible to call fsync on a read-only handle (for example, fsck.ext2
does it when doing read-only check), and this call results in kernel
warning. This bug was introduced by the commit 721c7fc701c7 "block: fail
op_is_write() requests to read-only partitions".
Signed-off-b
On Wed, 22 Aug 2018, Jens Axboe wrote:
> On 8/22/18 10:23 AM, Mikulas Patocka wrote:
> > It is possible to call fsync on a read-only handle (for example, fsck.ext2
> > does it when doing read-only check), and this call results in kernel
> > warning. This bug was int
The loop that frees all the pages can take unbounded amount of time, so
add cond_resched() to it.
Signed-off-by: Mikulas Patocka
---
drivers/block/brd.c |2 ++
1 file changed, 2 insertions(+)
Index: linux-4.19.41/drivers/block/brd.c
On Thu, 9 May 2019, Jens Axboe wrote:
> On 5/9/19 10:54 AM, Mikulas Patocka wrote:
> > The loop that frees all the pages can take unbounded amount of time, so
> > add cond_resched() to it.
>
> Looks fine to me, would be nice with a comment on why the cond_resched
erm branch?
Or should we backport all the subsequent patches on the top of it?
Signed-off-by: Mikulas Patocka
Reported-by: Zdenek Kabelac
Fixes: ba5d73851e71 ("block: cleanup __blkdev_issue_discard()")
Fixes: 744889b7cbb5 ("block: don't deal with discard limit in
blkdev_issue_dis
On Wed, 14 Nov 2018, Christoph Hellwig wrote:
> On Thu, Nov 08, 2018 at 12:07:01PM -0500, Mike Snitzer wrote:
> > Discussed doing that with Jens and reported as much here:
> >
> > https://www.redhat.com/archives/dm-devel/2018-November/msg00068.html
> >
> > And Jens gave additional context for
On Wed, 7 Nov 2018, Jens Axboe wrote:
> On 11/7/18 3:47 PM, Mikulas Patocka wrote:
> >
> > I'd like to know - which kernel part needs to sum the percpu IO counters
> > frequently?
> >
> > My impression was that the counters need to be summed only when
Use percpu inflight counters to avoid cache line bouncing and improve
performance.
Signed-off-by: Mikulas Patocka
---
drivers/md/dm-core.h |5 +
drivers/md/dm.c | 50 ++
2 files changed, 39 insertions(+), 16 deletions(-)
Index
jiffy, the value is as exact
as the previous value. If the I/Os take more than a jiffy, the value may
lag behind the previous value.
Signed-off-by: Mikulas Patocka
---
block/blk-core.c |7 ++-
block/blk-settings.c |6 ++
block/genhd.c | 12 +
Make sure that the statistics are not updated while the device is
suspended. So, we move statistics update before generic_end_io_acct.
Signed-off-by: Mikulas Patocka
---
drivers/md/dm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Index: linux-dm/drivers/md/dm.c
Hi
These are the device mapper percpu counter patches.
They are on the top of
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-4.21
Mikulas
On Fri, 16 Nov 2018, Jens Axboe wrote:
> On 11/16/18 6:55 AM, Mike Snitzer wrote:
> > On Fri, Nov 16 2018 at 4:11am -0500,
> > Christoph Hellwig wrote:
> >
> >> On Fri, Nov 16, 2018 at 01:04:19AM +0100, Mikulas Patocka wrote:
> >>> Device mapper was
These are the patches for per-cpu in_flight counters.
Mikulas
interrupt, but the
corruption only results in slight counter skew - the in_flight counter
must be exact, so it needs local_t.
Signed-off-by: Mikulas Patocka
---
block/bio.c |4 ++--
block/blk-core.c |4 ++--
block/blk-merge.c |2 +-
block/genhd.c | 47
started
or ended and the jiffies value has changed. If the I/Os take less than a
jiffy, the value is as exact as the previously calculated value. If the
I/Os take more than a jiffy, io_ticks can drift behind the previously
calculated value.
Signed-off-by: Mikulas Patocka
---
block/bio.c
;s no functional change.
Signed-off-by: Mikulas Patocka
---
block/blk-mq.c|6 --
block/blk-mq.h|3 +--
block/genhd.c | 32 +++-
block/partition-generic.c |6 +++---
include/linux/genhd.h |3 +--
5 files change
On Thu, 29 Nov 2018, Mike Snitzer wrote:
> On Tue, Nov 27 2018 at 7:42pm -0500,
> Mikulas Patocka wrote:
>
> > Now when part_round_stats is gone, we can switch to per-cpu in-flight
> > counters.
> >
> > We use the local-atomic type local_t,
On Sun, 30 Dec 2018, Christoph Hellwig wrote:
> On Thu, Dec 27, 2018 at 11:09:44AM -0500, Mike Snitzer wrote:
> > - Fix various DM targets to check for device sector overflow if
> > CONFIG_LBDAF is not set.
>
> Question to Jens and Linus:
>
> is there any good reason to keep the CONFIG_LBDA
On Thu, 18 Aug 2016, Eric Wheeler wrote:
> > On Wed, Jun 01 2016 at 9:44am -0400, Christoph Hellwig
> > wrote:
> >
> > > > > be dm-crypt.c. Maybe you've identified some indirect use of
> > > > > BIO_MAX_SIZE?
> > > >
> > > > I mean the recently introduced BIO_MAX_SIZE in -next tree:
> > > >
On Fri, 26 Aug 2016, Mike Snitzer wrote:
> On Thu, Aug 25 2016 at 4:13pm -0400,
> Jens Axboe wrote:
>
> > On 08/25/2016 12:34 PM, Mikulas Patocka wrote:
> > >
> > >Device mapper can't split the bio in generic_make_request - it frees the
> > >
On Mon, 29 Aug 2016, Ming Lei wrote:
> On Sat, Aug 27, 2016 at 11:09 PM, Mikulas Patocka wrote:
> >
> >
> > On Fri, 26 Aug 2016, Mike Snitzer wrote:
> >
> >> On Thu, Aug 25 2016 at 4:13pm -0400,
> >> Jens Axboe wrote:
> >>
On Mon, 29 Aug 2016, Mike Snitzer wrote:
> On Sat, Aug 27 2016 at 11:09am -0400,
> Mikulas Patocka wrote:
>
> >
> >
> > On Fri, 26 Aug 2016, Mike Snitzer wrote:
> >
> > > On Thu, Aug 25 2016 at 4:13pm -0400,
> > > Jens Axboe wrote:
>
On Tue, 30 Aug 2016, Ming Lei wrote:
> On Tue, Aug 30, 2016 at 5:57 AM, Mikulas Patocka wrote:
> >
> >
> > On Mon, 29 Aug 2016, Ming Lei wrote:
> >
> >> On Sat, Aug 27, 2016 at 11:09 PM, Mikulas Patocka
> >> wrote:
> >>
On Tue, 30 Aug 2016, Mike Snitzer wrote:
> On Tue, Aug 30 2016 at 8:19P -0400,
> Mikulas Patocka wrote:
>
> >
> >
> > On Tue, 30 Aug 2016, Ming Lei wrote:
> >
> > > On Tue, Aug 30, 2016 at 5:57 AM, Mikulas Patocka
> > > wrote:
> >
mount the filesystem without "-o discard".
Signed-off-by: Mikulas Patocka
---
drivers/block/brd.c | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
Index: linux-2.6/drivers/block/brd.c
==
: Mikulas Patocka
---
drivers/block/brd.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
Index: linux-2.6/drivers/block/brd.c
===
--- linux-2.6.orig/drivers/block/brd.c
+++ linux-2.6/drivers/block/brd.c
The brd driver refuses misaligned discard requests with an error. However,
this is suboptimal, misaligned requests could be handled by discarding a
part of the request that is aligned on a page boundary. This patch changes
the code so that it handles misaligned requests.
Signed-off-by: Mikulas
On Tue, 25 Oct 2016, Jens Axboe wrote:
> On 10/25/2016 08:37 AM, Mike Snitzer wrote:
> > On Tue, Oct 25 2016 at 9:07P -0400,
> > Christoph Hellwig wrote:
> >
> > > I think the right fix is to kill off the BLKFLSBUF special case in
> > > brd. Yes, it break compatibility - but in this case the
supposed to race with
discard.
Signed-off-by: Mikulas Patocka
---
drivers/block/brd.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/block/brd.c
===
--- linux-2.6.orig/drivers
On Wed, 26 Oct 2016, Bart Van Assche wrote:
> On 10/26/2016 01:26 PM, Mikulas Patocka wrote:
> > The brd driver refuses misaligned discard requests with an error. However,
> > this is suboptimal, misaligned requests could be handled by discarding a
> > part of the request
On Wed, 26 Oct 2016, Bart Van Assche wrote:
> On 10/26/2016 02:46 PM, Mikulas Patocka wrote:
> > I don't like the idea of complicating the code by turning discards into
> > writes.
>
> That's not what my patch series does. The only writes added by my patch
On Wed, 26 Oct 2016, Christoph Hellwig wrote:
> On Wed, Oct 26, 2016 at 05:46:11PM -0400, Mikulas Patocka wrote:
> > I think the proper thing would be to move "discard_zeroes_data" flag into
> > the bio itself - there would be REQ_OP_DISCARD and REQ_OP_DISCARD_ZERO
On Fri, 28 Oct 2016, Bart Van Assche wrote:
> On 10/28/2016 04:39 AM, Mikulas Patocka wrote:
> > On Wed, 26 Oct 2016, Bart Van Assche wrote:
> > > On 10/26/2016 02:46 PM, Mikulas Patocka wrote:
> > > > I think the proper thing would be to move "discard_zeroes_
On Fri, 28 Oct 2016, Christoph Hellwig wrote:
> [adding Chaitanya to Cc]
>
> On Fri, Oct 28, 2016 at 07:43:41AM -0400, Mikulas Patocka wrote:
> > We could detect if the REQ_OP_WRITE_SAME command contains all zeroes and
> > if it does, turn it into "Write Zeroes"
Hi
I need the function bio_kmap_irq in the driver that I am developing, but
it doesn't return the size of the mapped data. I've made this patch to fix
it.
Mikulas
From: Mikulas Patocka
The function bio_kmap_irq is not usable because it does not return the
size of the mapped
On Wed, 8 Nov 2017, Christoph Hellwig wrote:
> On Tue, Nov 07, 2017 at 04:45:17PM -0500, Mikulas Patocka wrote:
> > Hi
> >
> > I need the function bio_kmap_irq in the driver that I am developing, but
> > it doesn't return the size of the mapped data. I&#
Remove unused mutex brd_mutex. It is unused since the commit ff26956875c2
("brd: remove support for BLKFLSBUF").
Signed-off-by: Mikulas Patocka
---
drivers/block/brd.c |1 -
1 file changed, 1 deletion(-)
Index: linux-2.6/drivers/b
On Tue, 21 Nov 2017, Mike Snitzer wrote:
> On Tue, Nov 21 2017 at 7:43am -0500,
> Mike Snitzer wrote:
>
> > Decided it a better use of my time to review and then hopefully use the
> > block-core's bio splitting infrastructure in DM. Been meaning to do
> > that for quite a while anyway. Thi
On Tue, 21 Nov 2017, Mike Snitzer wrote:
> On Tue, Nov 21 2017 at 4:23pm -0500,
> Mikulas Patocka wrote:
>
> > This is not correct:
> >
> >2206 static void dm_wq_work(struct work_struct *work)
> >2207 {
> >2208 struct mapped
Remove useless assignment to the variable "split" because the variable is
unconditionally assigned later.
Signed-off-by: Mikulas Patocka
---
block/bio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/b
On Wed, 22 Nov 2017, NeilBrown wrote:
> On Tue, Nov 21 2017, Mikulas Patocka wrote:
>
> > On Tue, 21 Nov 2017, Mike Snitzer wrote:
> >
> >> On Tue, Nov 21 2017 at 4:23pm -0500,
> >> Mikulas Patocka wrote:
> >>
> >> > This is not corr
On Sat, 25 Nov 2017, Ingo Molnar wrote:
>
> * Mikulas Patocka wrote:
>
> > On Fri, 24 Nov 2017, Ingo Molnar wrote:
> >
> > > > + return unlikely(plug != NULL) &&
> > > > (!list_empty(&plug->
o that only REQ_OP_READ
requests are counted in the read bucket. The patch improves SATA
write+flush throughput from 130MB/s to 350MB/s.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org # v4.12+
---
block/blk-wbt.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
I
On Mon, 5 Feb 2018, Jens Axboe wrote:
> On 2/5/18 12:22 PM, Jens Axboe wrote:
> > On 2/5/18 12:11 PM, Mikulas Patocka wrote:
> >> I have a workload where one process sends many asynchronous write bios
> >> (without waiting for them) and another process sends synchron
d be
reverted and it should be reworked for the next merge window, so that it
calls bio_integrity_verify_fn only for the lowest level.
Mikulas
From: Mikulas Patocka
The patch 7c20f11680a441df09de7235206f70115fbf6290 ("bio-integrity: stop
abusing bi_end_io") changes the code
On Sat, 5 Aug 2017, Christoph Hellwig wrote:
>
> On Thu, Aug 03, 2017 at 10:10:55AM -0400, Mikulas Patocka wrote:
> > That dm-crypt commit that uses bio integrity payload came 3 months before
> > 7c20f11680a441df09de7235206f70115fbf6290 and it was already present in
>
On Sat, 5 Aug 2017, Martin K. Petersen wrote:
> Mikulas,
>
> > The sector number in the integrity tag must match the physical sector
> > number. So, it must be verified at the bottom.
>
> The ref tag seed matches the submitter block number (typically block
> layer sector for the top device) a
On Wed, 9 Aug 2017, h...@lst.de wrote:
> Does commit 615d22a51c04856efe62af6e1d5b450aaf5cc2c0
> "block: Fix __blkdev_issue_zeroout loop" fix the issue for you?
>
> --
> dm-devel mailing list
> dm-de...@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
I think that patch is incorrec
On Mon, 14 Aug 2017, Damien Le Moal wrote:
> On Sun, 2017-08-13 at 22:47 -0400, Mikulas Patocka wrote:
> >
> > On Wed, 9 Aug 2017, h...@lst.de wrote:
> >
> > > Does commit 615d22a51c04856efe62af6e1d5b450aaf5cc2c0
> > > "block: Fix __blkd
multiplication by the
number of sectors per page.
Signed-off-by: Mikulas Patocka
Fixes: 1647b9b959c7 ("brd: add dax_operations support")
Cc: sta...@vger.kernel.org # 4.12+
---
drivers/block/brd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-4.13/drivers/b
e on Alpha and if we are compiling for a processor that doesn't have
the byte-word-extension.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org # 4.13+
---
include/linux/blk_types.h |5 +
1 file changed, 5 insertions(+
I'm getting a slab named "biovec-(1<<(21-12))". It is caused by unintended
expansion of the macro BIO_MAX_PAGES. This patch renames it to biovec-max.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org # v4.14+
---
block/bio.c |4 ++--
1 file change
On Wed, 21 Mar 2018, Jens Axboe wrote:
> On 3/21/18 10:42 AM, Mikulas Patocka wrote:
> > Early alpha processors cannot write a single byte or word; they read 8
> > bytes, modify the value in registers and write back 8 bytes.
> >
> > The type blk_status_t is defin
Enable compat ioctl LOOP_SET_DIRECT_IO.
Signed-off-by: Mikulas Patocka
Fixes: ab1cb278bc70 ("block: loop: introduce ioctl command of
LOOP_SET_DIRECT_IO")
Cc: sta...@vger.kernel.org # v4.4+
---
drivers/block/loop.c |2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6/dri
Enable compat ioctl LOOP_SET_BLOCK_SIZE.
Signed-off-by: Mikulas Patocka
Fixes: 89e4fdecb51c ("loop: add ioctl for changing logical block size")
Cc: sta...@vger.kernel.org # v4.14+
---
drivers/block/loop.c |1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/drivers/bl
On Wed, 4 Jan 2017, Mike Snitzer wrote:
> On Wed, Jan 04 2017 at 12:12am -0500,
> NeilBrown wrote:
>
> > On Tue, Jan 03 2017, Jack Wang wrote:
> >
> > > 2016-12-23 12:45 GMT+01:00 Lars Ellenberg :
> > >> On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote:
> > >>> Dear Maintainers
>
On Fri, 6 Jan 2017, Mikulas Patocka wrote:
>
>
> On Wed, 4 Jan 2017, Mike Snitzer wrote:
>
> > On Wed, Jan 04 2017 at 12:12am -0500,
> > NeilBrown wrote:
> >
> > > > Suggested-by: NeilBrown
> > > > Signed-off-by:
llocates a structure
dm_snap_tracked_chunk and adds it to tracked_chunk_hash) and then remaps
the bio to the underlying device and exits with DM_MAPIO_REMAPPED.
4) The remapped bio is submitted with generic_make_request, but it isn't
issued - it is added to current->bio_list inst
On Fri, 10 Mar 2017, Mike Snitzer wrote:
> On Fri, Mar 10 2017 at 7:34am -0500,
> Lars Ellenberg wrote:
>
> > > --- a/block/blk-core.c
> > > +++ b/block/blk-core.c
> > > @@ -1975,7 +1975,14 @@ generic_make_request_checks(struct bio *bio)
> > > */
> > > blk_qc_t generic_make_request(struct
5afcc0] lo_rw_aio at a0377042 [loop]
#21 [88272f5afd70] loop_queue_work at a0377c3b [loop]
#22 [88272f5afe60] kthread_worker_fn at 810a8a0c
#23 [88272f5afec0] kthread at 810a8428
#24 [88272f5aff50] ret_from_fork at 81745242
Signed-off-by: Miku
60 matches
Mail list logo
