Re: [PATCH] block: fix a comment typo in req_opf

2017-11-28 Thread Minwoo Im
Hello Bart, Thanks to you for your review. I'll keep that in mind for next time. Thanks, On Tue, Nov 28, 2017 at 3:06 AM, Bart Van Assche <bart.vanass...@wdc.com> wrote: > On Fri, 2017-11-24 at 23:26 +0900, Minwoo Im wrote: >> a tiny comment typo fixed. > > Patch de

[PATCH] block: fix a comment typo in req_opf

2017-11-24 Thread Minwoo Im
a tiny comment typo fixed. Signed-off-by: Minwoo Im <minwoo.im@gmail.com> --- include/linux/blk_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index a1e628e..eca5bf6 100644 --- a/include/linux/blk_t

[PATCH] null_blk: fix default values in documentation

2017-11-07 Thread Minwoo Im
null_blk.c has initial value of (1) nr_devices as 1. (2) completion_nsec as 10,000ns, not 10.000ns. documentation should be updated for fixes above. Signed-off-by: Minwoo Im <minwoo.im@gmail.com> --- Documentation/block/null_blk.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH] null_blk: add an usage for shared tags in documentation

2017-11-07 Thread Minwoo Im
add usage explanation for a shared_tags of commit 82f402fefa50f1675bf918bcd009981bd6b30ac8 ("null_blk: add support for shared tags") to this documentation. Signed-off-by: Minwoo Im <minwoo.im@gmail.com> --- Documentation/block/null_blk.txt | 5 + 1 file changed, 5 ins

[PATCH] block: fix a comment typo in req_opf

2017-12-02 Thread Minwoo Im
fix a comment typo in "struct req_opf". replace "seset" with "reset". Signed-off-by: Minwoo Im <minwoo.im@gmail.com> Reviewed-by: Bart Van Assche <bart.vanass...@wdc.com> --- include/linux/blk_types.h | 2 +- 1 file changed, 1 insertion(+),

[PATCH] blk-mq: fix typo in a function comment

2018-06-30 Thread Minwoo Im
Fix typo in a function blk_mq_alloc_tag_set() comment. if if it too large -> if it's too large. Signed-off-by: Minwoo Im --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index b429d51..706f35e 100644 --- a/block/blk-m

Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map

2018-07-02 Thread Minwoo Im
Hi Johannes, Thanks for you kindly comment. On Mon, 2018-07-02 at 10:15 +0200, Johannes Thumshirn wrote: > On Sun, Jul 01, 2018 at 01:21:39AM +0900, Minwoo Im wrote: > > > > set->mq_map is now currently cleared if something goes wrong when > > establishing a queue ma

Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map

2018-07-02 Thread Minwoo Im
Hi Johannes, I appreciate your kindly response. On Mon, 2018-07-02 at 15:02 +0200, Johannes Thumshirn wrote: > On Mon, Jul 02, 2018 at 09:55:57PM +0900, Minwoo Im wrote: > > > > No 2nd follow-up patch will be there.  I thought these two parts are > > using a same unit-func

Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map

2018-07-02 Thread Minwoo Im
On Mon, 2018-07-02 at 15:27 +0200, Johannes Thumshirn wrote: > On Mon, Jul 02, 2018 at 10:20:03PM +0900, Minwoo Im wrote: > [...] > > > > > > > > You could still evaluate if it isn't worth to make it: > > > +static void blk_mq_clear_mq_map(struct blk_mq

[PATCH V2] blk-mq: code clean-up by adding an API to clear set->mq_map

2018-07-02 Thread Minwoo Im
set->mq_map is now currently cleared if something goes wrong when establishing a queue map in blk-mq-pci.c. It's also cleared before updating a queue map in blk_mq_update_queue_map(). This patch provides an API to clear set->mq_map to make it clear. Signed-off-by: Minwoo Im --- block/

[PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map

2018-06-30 Thread Minwoo Im
set->mq_map is now currently cleared if something goes wrong when establishing a queue map in blk-mq-pci.c. It's also cleared before updating a queue map in blk_mq_update_queue_map(). This patch provides an API to clear set->mq_map to make it clear. Signed-off-by: Minwoo Im --- block/

Re: [PATCH V2] blk-mq: code clean-up by adding an API to clear set->mq_map

2018-07-02 Thread Minwoo Im
On Mon, 2018-07-02 at 08:31 -0600, Jens Axboe wrote: > On 7/2/18 7:45 AM, Minwoo Im wrote: > > > > set->mq_map is now currently cleared if something goes wrong when > > establishing a queue map in blk-mq-pci.c.  It's also cleared before > > updating a queue

[PATCH V3] blk-mq: code clean-up by adding an API to clear set->mq_map

2018-07-02 Thread Minwoo Im
set->mq_map is now currently cleared if something goes wrong when establishing a queue map in blk-mq-pci.c. It's also cleared before updating a queue map in blk_mq_update_queue_map(). This patch provides an API to clear set->mq_map to make it clear. Signed-off-by: Minwoo Im --- block/

[PATCH] block: fix a typo in comment of BLK_MQ_POLL_STATS_BKTS

2018-02-15 Thread Minwoo Im
Update comment typo _consisitent_ to _consistent_ from following commit. commit 0206319fdfee ("blk-mq: Fix poll_stat for new size-based bucketing.") Cc: Jens Axboe <ax...@kernel.dk> Signed-off-by: Minwoo Im <minwoo.im@gmail.com> --- include/linux/blkdev.h | 2 +- 1 fil