Re: [PATCH] loop: fix LOOP_GET_STATUS lock imbalance

2018-04-07 Thread Dmitry Vyukov
On Sat, Apr 7, 2018 at 9:27 AM, Tetsuo Handa wrote: > Omar Sandoval wrote: >> From: Omar Sandoval >> >> Commit 2d1d4c1e591f made loop_get_status() drop lo_ctx_mutex before >> returning, but the loop_get_status_old(), loop_get_status64(), and >>

Re: [PATCH] loop: fix LOOP_GET_STATUS lock imbalance

2018-04-07 Thread Tetsuo Handa
Omar Sandoval wrote: > From: Omar Sandoval > > Commit 2d1d4c1e591f made loop_get_status() drop lo_ctx_mutex before > returning, but the loop_get_status_old(), loop_get_status64(), and > loop_get_status_compat() wrappers don't call loop_get_status() if the > passed argument is

Re: [PATCH] loop: fix LOOP_GET_STATUS lock imbalance

2018-04-06 Thread Jens Axboe
On 4/6/18 10:57 AM, Omar Sandoval wrote: > From: Omar Sandoval > > Commit 2d1d4c1e591f made loop_get_status() drop lo_ctx_mutex before > returning, but the loop_get_status_old(), loop_get_status64(), and > loop_get_status_compat() wrappers don't call loop_get_status() if the >

Re: [PATCH] loop: fix LOOP_GET_STATUS lock imbalance

2018-04-06 Thread Omar Sandoval
On Fri, Apr 06, 2018 at 09:57:03AM -0700, Omar Sandoval wrote: > From: Omar Sandoval > > Commit 2d1d4c1e591f made loop_get_status() drop lo_ctx_mutex before > returning, but the loop_get_status_old(), loop_get_status64(), and > loop_get_status_compat() wrappers don't call

[PATCH] loop: fix LOOP_GET_STATUS lock imbalance

2018-04-06 Thread Omar Sandoval
From: Omar Sandoval Commit 2d1d4c1e591f made loop_get_status() drop lo_ctx_mutex before returning, but the loop_get_status_old(), loop_get_status64(), and loop_get_status_compat() wrappers don't call loop_get_status() if the passed argument is NULL. The callers expect that the