Re: [PATCH 01/10] pktcdvd: remove the call to blk_queue_bounce

2017-06-19 Thread Ming Lei
On Mon, Jun 19, 2017 at 11:18 PM, Christoph Hellwig wrote: > On Mon, Jun 19, 2017 at 11:13:46PM +0800, Ming Lei wrote: >> On Mon, Jun 19, 2017 at 11:00 PM, Christoph Hellwig wrote: >> > On Mon, Jun 19, 2017 at 10:34:36PM +0800, Ming Lei wrote: >> >>

Re: [PATCH 01/10] pktcdvd: remove the call to blk_queue_bounce

2017-06-19 Thread Christoph Hellwig
On Mon, Jun 19, 2017 at 11:13:46PM +0800, Ming Lei wrote: > On Mon, Jun 19, 2017 at 11:00 PM, Christoph Hellwig wrote: > > On Mon, Jun 19, 2017 at 10:34:36PM +0800, Ming Lei wrote: > >> blk_queue_make_request() sets bounce for any highmem page for long time, > >> and in theory this

Re: [PATCH 01/10] pktcdvd: remove the call to blk_queue_bounce

2017-06-19 Thread Ming Lei
On Mon, Jun 19, 2017 at 11:00 PM, Christoph Hellwig wrote: > On Mon, Jun 19, 2017 at 10:34:36PM +0800, Ming Lei wrote: >> blk_queue_make_request() sets bounce for any highmem page for long time, >> and in theory this patch might cause regression on 32bit arch, when >> the controller

Re: [PATCH 01/10] pktcdvd: remove the call to blk_queue_bounce

2017-06-19 Thread Ming Lei
On Mon, Jun 19, 2017 at 3:26 PM, Christoph Hellwig wrote: > pktcdvd is a make_request based stacking driver and thus doesn't have any > addressing limits on it's own. It also doesn't use bio_data() or > page_address(), so it doesn't need a lowmem bounce either. > > Signed-off-by:

[PATCH 01/10] pktcdvd: remove the call to blk_queue_bounce

2017-06-19 Thread Christoph Hellwig
pktcdvd is a make_request based stacking driver and thus doesn't have any addressing limits on it's own. It also doesn't use bio_data() or page_address(), so it doesn't need a lowmem bounce either. Signed-off-by: Christoph Hellwig --- drivers/block/pktcdvd.c | 2 -- 1 file