Re: [PATCH V4 0/2] blk-mq: fix race between completion and BLK_EH_RESET_TIMER

2018-04-23 Thread Martin Steigerwald
Hello Ming. Ming Lei - 18.04.18, 18:46: > On Mon, Apr 16, 2018 at 03:12:30PM +0200, Martin Steigerwald wrote: > > Ming Lei - 16.04.18, 02:45: > > > On Sun, Apr 15, 2018 at 06:31:44PM +0200, Martin Steigerwald wrote: > > > > Hi Ming. > > > > > > > > Ming Lei - 15.04.18, 17:43: > > > > > Hi Jens,

Re: [PATCH V4 0/2] blk-mq: fix race between completion and BLK_EH_RESET_TIMER

2018-04-18 Thread Ming Lei
On Mon, Apr 16, 2018 at 03:12:30PM +0200, Martin Steigerwald wrote: > Ming Lei - 16.04.18, 02:45: > > On Sun, Apr 15, 2018 at 06:31:44PM +0200, Martin Steigerwald wrote: > > > Hi Ming. > > > > > > Ming Lei - 15.04.18, 17:43: > > > > Hi Jens, > > > > > > > > This two patches fixes the recently

Re: [PATCH V4 0/2] blk-mq: fix race between completion and BLK_EH_RESET_TIMER

2018-04-16 Thread jianchao.wang
Hi bart Thanks for your kindly response. I have sent out the patch. Please refer to https://marc.info/?l=linux-block=152393666517449=2 Thanks Jianchao On 04/17/2018 08:15 AM, Bart Van Assche wrote: > On Tue, 2018-04-17 at 00:04 +0800, jianchao.wang wrote: >> diff --git a/block/blk-mq.c

Re: [PATCH V4 0/2] blk-mq: fix race between completion and BLK_EH_RESET_TIMER

2018-04-16 Thread Bart Van Assche
On Tue, 2018-04-17 at 00:04 +0800, jianchao.wang wrote: > diff --git a/block/blk-mq.c b/block/blk-mq.c > index 16e83e6..be9b435 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -2077,6 +2077,7 @@ static int blk_mq_init_request(struct blk_mq_tag_set > *set, struct request *rq, > >

Re: [PATCH V4 0/2] blk-mq: fix race between completion and BLK_EH_RESET_TIMER

2018-04-16 Thread Martin Steigerwald
Ming Lei - 16.04.18, 02:45: > On Sun, Apr 15, 2018 at 06:31:44PM +0200, Martin Steigerwald wrote: > > Hi Ming. > > > > Ming Lei - 15.04.18, 17:43: > > > Hi Jens, > > > > > > This two patches fixes the recently discussed race between > > > completion > > > and BLK_EH_RESET_TIMER. > > > > > >

Re: [PATCH V4 0/2] blk-mq: fix race between completion and BLK_EH_RESET_TIMER

2018-04-15 Thread Ming Lei
On Sun, Apr 15, 2018 at 06:31:44PM +0200, Martin Steigerwald wrote: > Hi Ming. > > Ming Lei - 15.04.18, 17:43: > > Hi Jens, > > > > This two patches fixes the recently discussed race between completion > > and BLK_EH_RESET_TIMER. > > > > Israel & Martin, this one is a simpler fix on this issue

Re: [PATCH V4 0/2] blk-mq: fix race between completion and BLK_EH_RESET_TIMER

2018-04-15 Thread Martin Steigerwald
Hi Ming. Ming Lei - 15.04.18, 17:43: > Hi Jens, > > This two patches fixes the recently discussed race between completion > and BLK_EH_RESET_TIMER. > > Israel & Martin, this one is a simpler fix on this issue and can > cover the potencial hang of MQ_RQ_COMPLETE_IN_TIMEOUT request, could > you

[PATCH V4 0/2] blk-mq: fix race between completion and BLK_EH_RESET_TIMER

2018-04-15 Thread Ming Lei
Hi Jens, This two patches fixes the recently discussed race between completion and BLK_EH_RESET_TIMER. Israel & Martin, this one is a simpler fix on this issue and can cover the potencial hang of MQ_RQ_COMPLETE_IN_TIMEOUT request, could you test V4 and see if your issue can be fixed? Thanks,