Re: [PATCH v4 1/6] block/loop: Delete gendisk before cleaning up the request queue

[Joseph Qi]

On 18/2/23 09:08, Bart Van Assche wrote:
> Remove the disk, partition and bdi sysfs attributes before cleaning up
> the request queue associated with the disk.
> 
> Signed-off-by: Bart Van Assche 
> Cc: Josef Bacik 
> Cc: Shaohua Li 
> Cc: Omar Sandoval 
> Cc: Hannes Reinecke 
> Cc: Ming Lei 

Looks good.
Reviewed-by: Joseph Qi 

Re: [PATCH v4 1/6] block/loop: Delete gendisk before cleaning up the request queue

[Johannes Thumshirn]

Looks good,
Reviewed-by: Johannes Thumshirn 
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[PATCH v4 1/6] block/loop: Delete gendisk before cleaning up the request queue

[Bart Van Assche]

Remove the disk, partition and bdi sysfs attributes before cleaning up
the request queue associated with the disk.

Signed-off-by: Bart Van Assche 
Cc: Josef Bacik 
Cc: Shaohua Li 
Cc: Omar Sandoval 
Cc: Hannes Reinecke 
Cc: Ming Lei 
---
 drivers/block/loop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index d5fe720cf149..8b693fdd08dc 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1864,8 +1864,8 @@ static int loop_add(struct loop_device **l, int i)
 
 static void loop_remove(struct loop_device *lo)
 {
-   blk_cleanup_queue(lo->lo_queue);
del_gendisk(lo->lo_disk);
+   blk_cleanup_queue(lo->lo_queue);
blk_mq_free_tag_set(>tag_set);
put_disk(lo->lo_disk);
kfree(lo);
-- 
2.16.2