Re: [PATCH 01/10] block: move existing elevator ops to union
On Fri, Jan 13 2017, Christoph Hellwig wrote: > On Wed, Jan 11, 2017 at 02:39:54PM -0700, Jens Axboe wrote: > > Prep patch for adding MQ ops as well, since doing anon unions with > > named initializers doesn't work on older compilers. > > My gut feeling tells me MQ schedulers shouldn't share elevator_type. > I'll play around a bit with the code later to see if my gut was right. It's crazy to re-invent a new framework just for MQ schedulers, imho. So you're going to have to come up with something better than a gut feeling. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/10] block: move existing elevator ops to union
On Wed, Jan 11, 2017 at 02:39:54PM -0700, Jens Axboe wrote: > Prep patch for adding MQ ops as well, since doing anon unions with > named initializers doesn't work on older compilers. My gut feeling tells me MQ schedulers shouldn't share elevator_type. I'll play around a bit with the code later to see if my gut was right. -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/10] block: move existing elevator ops to union
On Wed, 2017-01-11 at 14:39 -0700, Jens Axboe wrote: > Prep patch for adding MQ ops as well, since doing anon unions with > named initializers doesn't work on older compilers. Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/10] block: move existing elevator ops to union
On Wed, Jan 11, 2017 at 02:39:54PM -0700, Jens Axboe wrote: > Prep patch for adding MQ ops as well, since doing anon unions with > named initializers doesn't work on older compilers. > > Signed-off-by: Jens Axboe > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
