Re: [PATCH 01/14] blk-mq: kill q->mq_map

2018-10-29 Thread jianchao.wang
On 10/29/18 11:00 AM, Jens Axboe wrote: > On 10/28/18 8:40 PM, jianchao.wang wrote: >> >> >> On 10/29/18 10:02 AM, jianchao.wang wrote: >>> Hi Jens >>> >>> On 10/28/18 12:52 AM, Jens Axboe wrote: On 10/27/18 10:48 AM, Jens Axboe wrote: > On 10/27/18 8:19 AM, jianchao.wang wrote: >>

Re: [PATCH 01/14] blk-mq: kill q->mq_map

2018-10-29 Thread Hannes Reinecke
On 10/25/18 11:16 PM, Jens Axboe wrote: It's just a pointer to set->mq_map, use that instead. Signed-off-by: Jens Axboe --- block/blk-mq.c | 13 - block/blk-mq.h | 4 +++- include/linux/blkdev.h | 2 -- 3 files changed, 7 insertions(+), 12 deletions(-)

Re: [PATCH 01/14] blk-mq: kill q->mq_map

2018-10-28 Thread Jens Axboe
On 10/28/18 8:40 PM, jianchao.wang wrote: > > > On 10/29/18 10:02 AM, jianchao.wang wrote: >> Hi Jens >> >> On 10/28/18 12:52 AM, Jens Axboe wrote: >>> On 10/27/18 10:48 AM, Jens Axboe wrote: On 10/27/18 8:19 AM, jianchao.wang wrote: > Hi Jens > > On 10/26/18 5:16 AM, Jens Axboe

Re: [PATCH 01/14] blk-mq: kill q->mq_map

2018-10-28 Thread jianchao.wang
On 10/29/18 10:02 AM, jianchao.wang wrote: > Hi Jens > > On 10/28/18 12:52 AM, Jens Axboe wrote: >> On 10/27/18 10:48 AM, Jens Axboe wrote: >>> On 10/27/18 8:19 AM, jianchao.wang wrote: Hi Jens On 10/26/18 5:16 AM, Jens Axboe wrote: > It's just a pointer to set->mq_map, use

Re: [PATCH 01/14] blk-mq: kill q->mq_map

2018-10-28 Thread jianchao.wang
Hi Jens On 10/28/18 12:52 AM, Jens Axboe wrote: > On 10/27/18 10:48 AM, Jens Axboe wrote: >> On 10/27/18 8:19 AM, jianchao.wang wrote: >>> Hi Jens >>> >>> On 10/26/18 5:16 AM, Jens Axboe wrote: It's just a pointer to set->mq_map, use that instead. >>> Instead of using the set->mq_map and

Re: [PATCH 01/14] blk-mq: kill q->mq_map

2018-10-28 Thread Christoph Hellwig
On Thu, Oct 25, 2018 at 03:16:13PM -0600, Jens Axboe wrote: > static inline struct blk_mq_hw_ctx *blk_mq_map_queue(struct request_queue *q, > int cpu) > { > - return q->queue_hw_ctx[q->mq_map[cpu]]; > + struct blk_mq_tag_set *set = q->tag_set; > + > + return

Re: [PATCH 01/14] blk-mq: kill q->mq_map

2018-10-27 Thread Jens Axboe
On 10/27/18 10:48 AM, Jens Axboe wrote: > On 10/27/18 8:19 AM, jianchao.wang wrote: >> Hi Jens >> >> On 10/26/18 5:16 AM, Jens Axboe wrote: >>> It's just a pointer to set->mq_map, use that instead. >> Instead of using the set->mq_map and then a two-dimensional set->mq_map, >> how about migrate the

Re: [PATCH 01/14] blk-mq: kill q->mq_map

2018-10-27 Thread Jens Axboe
On 10/27/18 8:19 AM, jianchao.wang wrote: > Hi Jens > > On 10/26/18 5:16 AM, Jens Axboe wrote: >> It's just a pointer to set->mq_map, use that instead. > Instead of using the set->mq_map and then a two-dimensional set->mq_map, > how about migrate the mq_map from per-set to per-cpuctx ? >

Re: [PATCH 01/14] blk-mq: kill q->mq_map

2018-10-27 Thread jianchao.wang
Hi Jens On 10/26/18 5:16 AM, Jens Axboe wrote: > It's just a pointer to set->mq_map, use that instead. Instead of using the set->mq_map and then a two-dimensional set->mq_map, how about migrate the mq_map from per-set to per-cpuctx ? something like: q->queue_hw_ctx[ctx->map[type]] Thanks