This opportunistic poll is pretty bogus now as we never set the HIPRI
flag and it should probably be removed in a prep patch. We should then
later try to use a scheme similar to your aio polling for the nvme
target as well.
I'll kill it in a pre-patch.
Agreed..
On 11/19/18 1:05 AM, Christoph Hellwig wrote:
>> -bool blk_poll(struct request_queue *q, blk_qc_t cookie)
>> +bool blk_poll(struct request_queue *q, blk_qc_t cookie, bool spin)
>
> I find the paramter name a little confusing. Maybe wait_for_request,
> although I don't particularly like that one
> -bool blk_poll(struct request_queue *q, blk_qc_t cookie)
> +bool blk_poll(struct request_queue *q, blk_qc_t cookie, bool spin)
I find the paramter name a little confusing. Maybe wait_for_request,
although I don't particularly like that one either. But we really need
to document the parameter
