Re: [PATCH 7/7] block: use GFP_KERNEL for allocations from blk_get_request

2018-04-10 Thread Hannes Reinecke
On Mon, 9 Apr 2018 17:39:16 +0200 Christoph Hellwig wrote: > blk_get_request is used for pass-through style I/O and thus doesn't > need GFP_NOIO. > > Signed-off-by: Christoph Hellwig > --- > block/blk-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH 7/7] block: use GFP_KERNEL for allocations from blk_get_request

2018-04-09 Thread Christoph Hellwig
On Mon, Apr 09, 2018 at 09:52:03AM -0700, Matthew Wilcox wrote: > On Mon, Apr 09, 2018 at 05:39:16PM +0200, Christoph Hellwig wrote: > > blk_get_request is used for pass-through style I/O and thus doesn't need > > GFP_NOIO. > > Obviously GFP_KERNEL is a big improvement over GFP_NOIO! But can we

Re: [PATCH 7/7] block: use GFP_KERNEL for allocations from blk_get_request

2018-04-09 Thread Matthew Wilcox
On Mon, Apr 09, 2018 at 05:39:16PM +0200, Christoph Hellwig wrote: > blk_get_request is used for pass-through style I/O and thus doesn't need > GFP_NOIO. Obviously GFP_KERNEL is a big improvement over GFP_NOIO! But can we take it all the way to GFP_USER, if this is always done in the ioctl path