Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Thu, 2018-03-08 at 21:42 +0800, Ming Lei wrote: > On Wed, Mar 07, 2018 at 09:11:37AM -0500, Laurence Oberman wrote: > > On Tue, 2018-03-06 at 14:24 -0500, Martin K. Petersen wrote: > > > Ming, > > > > > > > Given both Don and Laurence have verified that patch 1 and > > > > patch 2 > > > > does

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Thu, 2018-03-08 at 09:41 +0100, Hannes Reinecke wrote: > IE the _entire_ request set is allocated as _one_ array, making it quite > hard to handle from the lower-level CPU caches. > Also the 'node' indicator doesn't really help us here, as the requests > have to be access by all CPUs in the

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Wed, Mar 07, 2018 at 09:11:37AM -0500, Laurence Oberman wrote: > On Tue, 2018-03-06 at 14:24 -0500, Martin K. Petersen wrote: > > Ming, > > > > > Given both Don and Laurence have verified that patch 1 and patch 2 > > > does fix IO hang, could you consider to merge the two first? > > > > Oh,

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Thu, Mar 08, 2018 at 09:41:16AM +0100, Hannes Reinecke wrote: > On 03/08/2018 09:15 AM, Ming Lei wrote: > > On Thu, Mar 08, 2018 at 08:50:35AM +0100, Christoph Hellwig wrote: > >>> +static void hpsa_setup_reply_map(struct ctlr_info *h) > >>> +{ > >>> + const struct cpumask *mask; > >>> +

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On 03/08/2018 09:15 AM, Ming Lei wrote: > On Thu, Mar 08, 2018 at 08:50:35AM +0100, Christoph Hellwig wrote: >>> +static void hpsa_setup_reply_map(struct ctlr_info *h) >>> +{ >>> + const struct cpumask *mask; >>> + unsigned int queue, cpu; >>> + >>> + for (queue = 0; queue < h->msix_vectors;

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Thu, Mar 08, 2018 at 08:50:35AM +0100, Christoph Hellwig wrote: > > +static void hpsa_setup_reply_map(struct ctlr_info *h) > > +{ > > + const struct cpumask *mask; > > + unsigned int queue, cpu; > > + > > + for (queue = 0; queue < h->msix_vectors; queue++) { > > + mask =

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

> +static void hpsa_setup_reply_map(struct ctlr_info *h) > +{ > + const struct cpumask *mask; > + unsigned int queue, cpu; > + > + for (queue = 0; queue < h->msix_vectors; queue++) { > + mask = pci_irq_get_affinity(h->pdev, queue); > + if (!mask) > +

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Tue, 2018-03-06 at 14:24 -0500, Martin K. Petersen wrote: > Ming, > > > Given both Don and Laurence have verified that patch 1 and patch 2 > > does fix IO hang, could you consider to merge the two first? > > Oh, and I would still need a formal Acked-by: from Don and Tested-by: > from

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

Ming, > Please consider 2/8 too since it is still a fix. I still need the driver maintainer to ack the change. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Tue, Mar 06, 2018 at 02:24:25PM -0500, Martin K. Petersen wrote: > > Ming, > > > Given both Don and Laurence have verified that patch 1 and patch 2 > > does fix IO hang, could you consider to merge the two first? > > Oh, and I would still need a formal Acked-by: from Don and Tested-by: >

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

Ming, > Given both Don and Laurence have verified that patch 1 and patch 2 > does fix IO hang, could you consider to merge the two first? Oh, and I would still need a formal Acked-by: from Don and Tested-by: from Laurence. Also, for 4.16/scsi-fixes I would prefer verification to be done with

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

Hi Ming, > Given both Don and Laurence have verified that patch 1 and patch 2 > does fix IO hang, could you consider to merge the two first? I'm not going to merge the MR patch until Kashyap acks it. -- Martin K. Petersen Oracle Linux Engineering

RE: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

rtin K . > Petersen <martin.peter...@oracle.com>; James Bottomley > <james.bottom...@hansenpartnership.com>; Christoph Hellwig <h...@lst.de>; > Peter Rivera <peter.riv...@broadcom.com>; Meelis Roos <mr...@linux.ee> > Subject: RE: [PATCH V3 1/8] s

RE: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

ecke; Arun Easi; Omar Sandoval; > Martin K . Petersen; James Bottomley; Christoph Hellwig; Kashyap Desai; > Peter > Rivera; Meelis Roos > Subject: Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue > > On Fri, 2018-03-02 at 15:03 +, Don Brace wrote: > > > -Or

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

t; > Bottomley <james.bottom...@hansenpartnership.com>; Christoph > > > Hellwig > > > <h...@lst.de>; Kashyap Desai <kashyap.de...@broadcom.com>; Peter > > > Rivera > > > <peter.riv...@broadcom.com>; Meelis Roos <mr...@linux.ee> >

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

run Easi <arun.e...@cavium.com>; Omar Sandoval > > <osan...@fb.com>; Martin K . Petersen <martin.peter...@oracle.com>; > > James > > Bottomley <james.bottom...@hansenpartnership.com>; Christoph > > Hellwig > > <h...@lst.de>; Kashyap Desai <kashyap.d

RE: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

gt;; James > Bottomley <james.bottom...@hansenpartnership.com>; Christoph Hellwig > <h...@lst.de>; Kashyap Desai <kashyap.de...@broadcom.com>; Peter Rivera > <peter.riv...@broadcom.com>; Meelis Roos <mr...@linux.ee> > Subject: Re: [PATCH V3 1/8] scsi: hpsa:

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Fri, 2018-03-02 at 10:16 +0800, Ming Lei wrote: > On Thu, Mar 01, 2018 at 04:19:34PM -0500, Laurence Oberman wrote: > > On Thu, 2018-03-01 at 14:01 -0500, Laurence Oberman wrote: > > > On Thu, 2018-03-01 at 16:18 +, Don Brace wrote: > > > > > -Original Message- > > > > > From: Ming

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Thu, Mar 01, 2018 at 04:19:34PM -0500, Laurence Oberman wrote: > On Thu, 2018-03-01 at 14:01 -0500, Laurence Oberman wrote: > > On Thu, 2018-03-01 at 16:18 +, Don Brace wrote: > > > > -Original Message- > > > > From: Ming Lei [mailto:ming@redhat.com] > > > > Sent: Tuesday,

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

Hi Don, Thanks for your test! On Thu, Mar 01, 2018 at 04:18:17PM +, Don Brace wrote: > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Tuesday, February 27, 2018 4:08 AM > > To: Jens Axboe ; linux-block@vger.kernel.org; Christoph > >

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Thu, 2018-03-01 at 14:01 -0500, Laurence Oberman wrote: > On Thu, 2018-03-01 at 16:18 +, Don Brace wrote: > > > -Original Message- > > > From: Ming Lei [mailto:ming@redhat.com] > > > Sent: Tuesday, February 27, 2018 4:08 AM > > > To: Jens Axboe ;

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Thu, 2018-03-01 at 16:18 +, Don Brace wrote: > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Tuesday, February 27, 2018 4:08 AM > > To: Jens Axboe ; linux-block@vger.kernel.org; > > Christoph > > Hellwig ; Mike

RE: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Tuesday, February 27, 2018 4:08 AM > To: Jens Axboe ; linux-block@vger.kernel.org; Christoph > Hellwig ; Mike Snitzer > Cc: linux-s...@vger.kernel.org;