Re: [PATCH V4 11/15] blk-throttle: add interface to configure think time threshold

2016-11-28 Thread Shaohua Li
On Mon, Nov 28, 2016 at 05:08:18PM -0500, Tejun Heo wrote: > Hello, Shaohua. > > On Wed, Nov 23, 2016 at 05:06:30PM -0800, Shaohua Li wrote: > > > Shouldn't this be a per-cgroup setting along with latency target? > > > These two are the parameters which define how the cgroup should be > > >

Re: [PATCH V4 11/15] blk-throttle: add interface to configure think time threshold

2016-11-28 Thread Tejun Heo
Hello, Shaohua. On Wed, Nov 23, 2016 at 05:06:30PM -0800, Shaohua Li wrote: > > Shouldn't this be a per-cgroup setting along with latency target? > > These two are the parameters which define how the cgroup should be > > treated time-wise. > > It should be easy to make it per-cgroup. Just not

Re: [PATCH V4 11/15] blk-throttle: add interface to configure think time threshold

2016-11-23 Thread Tejun Heo
On Mon, Nov 14, 2016 at 02:22:18PM -0800, Shaohua Li wrote: > Add interface to configure the threshold > > Signed-off-by: Shaohua Li > --- > block/blk-sysfs.c| 7 +++ > block/blk-throttle.c | 25 + > block/blk.h | 4 > 3 files