Re: [PATCH rfc 01/30] nvme: Add admin connect request queue

2017-06-19 Thread Hannes Reinecke
On 06/19/2017 09:49 AM, Sagi Grimberg wrote: > >>> In case we reconnect with inflight admin IO we >>> need to make sure that the connect comes before >>> the admin command. This can be only achieved by >>> using a seperate request queue for admin connects. >> >> Use up a few more lines of the

Re: [PATCH rfc 01/30] nvme: Add admin connect request queue

2017-06-19 Thread Christoph Hellwig
On Mon, Jun 19, 2017 at 10:49:15AM +0300, Sagi Grimberg wrote: > However, you raise a valid point, I think I added this before we > had the queue_is_ready protection, which will reject the command > if the queue is not LIVE (unless its a connect). I think the reason > its still in is that I tested

Re: [PATCH rfc 01/30] nvme: Add admin connect request queue

2017-06-19 Thread Sagi Grimberg
In case we reconnect with inflight admin IO we need to make sure that the connect comes before the admin command. This can be only achieved by using a seperate request queue for admin connects. Use up a few more lines of the available space for your lines? :) I warned in the cover-letter

Re: [PATCH rfc 01/30] nvme: Add admin connect request queue

2017-06-19 Thread Christoph Hellwig
On Sun, Jun 18, 2017 at 06:21:35PM +0300, Sagi Grimberg wrote: > In case we reconnect with inflight admin IO we > need to make sure that the connect comes before > the admin command. This can be only achieved by > using a seperate request queue for admin connects. Use up a few more lines of the