Re: [PATCH rfc 29/30] nvme: add sed-opal ctrl manipulation in admin configuration

2017-06-19 Thread Christoph Hellwig 
On Mon, Jun 19, 2017 at 11:03:36AM +0300, Sagi Grimberg wrote:
>
>> The subject sounds odd and it could use a changelog.  But I'd love to
>> pick this change up ASAP as it's the right thing to do..
>
> How? where would you place it? there is no nvme_configure_admin_queue in
> nvme-core.

Doh.  Yeah, let's keep it where it is.

Re: [PATCH rfc 29/30] nvme: add sed-opal ctrl manipulation in admin configuration

2017-06-19 Thread Sagi Grimberg 



The subject sounds odd and it could use a changelog.  But I'd love to
pick this change up ASAP as it's the right thing to do..


How? where would you place it? there is no nvme_configure_admin_queue in
nvme-core.

I suppose we could get it in nvme_init_ctrl?

Re: [PATCH rfc 29/30] nvme: add sed-opal ctrl manipulation in admin configuration

2017-06-19 Thread Christoph Hellwig 
On Sun, Jun 18, 2017 at 06:22:03PM +0300, Sagi Grimberg wrote:
> Signed-off-by: Sagi Grimberg 

The subject sounds odd and it could use a changelog.  But I'd love to
pick this change up ASAP as it's the right thing to do..