Re: [PATCH v3 07/49] bcache: comment on direct access to bvec table

2017-10-19 Thread Ming Lei
On Thu, Aug 10, 2017 at 04:26:03AM -0700, Christoph Hellwig wrote: > I think all this bcache code needs bigger attention. For one > bio_alloc_pages is only used in bcache, so we should move it in there. Looks a good idea. > > Second the way bio_alloc_pages is currently written looks

Re: [PATCH v3 07/49] bcache: comment on direct access to bvec table

2017-08-10 Thread Christoph Hellwig
I think all this bcache code needs bigger attention. For one bio_alloc_pages is only used in bcache, so we should move it in there. Second the way bio_alloc_pages is currently written looks potentially dangerous for multi-page biovecs, so we should think about a better calling convention. The