Re: [PATCH v3 09/49] block: comment on bio_iov_iter_get_pages()

2017-10-19 Thread Ming Lei
On Thu, Aug 10, 2017 at 04:28:05AM -0700, Christoph Hellwig wrote: > > + * The hacking way of using bvec table as page pointer array is safe > > + * even after multipage bvec is introduced because that space can be > > + * thought as unused by bio_add_page(). > > I'm not sure what value this comme

Re: [PATCH v3 09/49] block: comment on bio_iov_iter_get_pages()

2017-08-10 Thread Christoph Hellwig
> + * The hacking way of using bvec table as page pointer array is safe > + * even after multipage bvec is introduced because that space can be > + * thought as unused by bio_add_page(). I'm not sure what value this comment adds. Note that once we have multi-page biovecs this could should change