Re: [PATCH v5] blk-throttle: fix race between blkcg_bio_issue_check() and cgroup_rmdir()

2018-03-19 Thread Jens Axboe
On 3/19/18 8:45 AM, Tejun Heo wrote: > Hello, > > On Thu, Mar 15, 2018 at 09:18:55AM +0800, Joseph Qi wrote: >>> This is pure bike-shedding but offlined reads kinda weird to me, maybe >>> just offline would read better? Other than that, >>> >> Do I need to resend a new version for this? > > No

Re: [PATCH v5] blk-throttle: fix race between blkcg_bio_issue_check() and cgroup_rmdir()

2018-03-19 Thread Tejun Heo
Hello, On Thu, Mar 15, 2018 at 09:18:55AM +0800, Joseph Qi wrote: > > This is pure bike-shedding but offlined reads kinda weird to me, maybe > > just offline would read better? Other than that, > > > Do I need to resend a new version for this? No idea, Jens's call. He can fix it up if he

Re: [PATCH v5] blk-throttle: fix race between blkcg_bio_issue_check() and cgroup_rmdir()

2018-03-14 Thread Joseph Qi
Hello Tejun, Thanks for your quick response. On 18/3/14 22:09, Tejun Heo wrote: > Hello, > > On Wed, Mar 14, 2018 at 02:18:04PM +0800, Joseph Qi wrote: >> Fixes: ae1188963611 ("blkcg: consolidate blkg creation in >> blkcg_bio_issue_check()") >> Reported-by: Jiufei Xue

Re: [PATCH v5] blk-throttle: fix race between blkcg_bio_issue_check() and cgroup_rmdir()

2018-03-14 Thread Tejun Heo
Hello, On Wed, Mar 14, 2018 at 02:18:04PM +0800, Joseph Qi wrote: > Fixes: ae1188963611 ("blkcg: consolidate blkg creation in > blkcg_bio_issue_check()") > Reported-by: Jiufei Xue > Cc: sta...@vger.kernel.org #4.3+ I'm a bit nervous about tagging it for -stable.