Re: [PATCH v6 08/12] block, scsi: Introduce blk_pm_runtime_exit()

2018-08-13 Thread Bart Van Assche
On Mon, 2018-08-13 at 17:24 +0800, jianchao.wang wrote: > I'm afraid this will not work. Since this patch fixes a bug that nobody has reported so far and since no later patches rely on this patch, I will leave it out. Thanks, Bart.

Re: [PATCH v6 08/12] block, scsi: Introduce blk_pm_runtime_exit()

2018-08-13 Thread jianchao.wang
Hi Bart On 08/11/2018 12:17 AM, Bart Van Assche wrote: > void blk_pm_runtime_exit(struct request_queue *q) > { > if (!q->dev) > return; > > pm_runtime_get_sync(q->dev); > blk_freeze_queue(q); > q->dev = NULL; > blk_unfreeze_queue(q); > } I'm afraid thi

Re: [PATCH v6 08/12] block, scsi: Introduce blk_pm_runtime_exit()

2018-08-10 Thread Bart Van Assche
On Fri, 2018-08-10 at 15:27 +, Bart Van Assche wrote: > On Fri, 2018-08-10 at 10:39 +0800, jianchao.wang wrote: > > On 08/10/2018 03:41 AM, Bart Van Assche wrote: > > > +void blk_pm_runtime_exit(struct request_queue *q) > > > +{ > > > + if (!q->dev) > > > + return; > > > + > > > + pm_ru

Re: [PATCH v6 08/12] block, scsi: Introduce blk_pm_runtime_exit()

2018-08-10 Thread Bart Van Assche
On Fri, 2018-08-10 at 10:39 +0800, jianchao.wang wrote: > On 08/10/2018 03:41 AM, Bart Van Assche wrote: > > +void blk_pm_runtime_exit(struct request_queue *q) > > +{ > > + if (!q->dev) > > + return; > > + > > + pm_runtime_get_sync(q->dev); > > + q->dev = NULL; > > +} > > +EXPORT_SY

Re: [PATCH v6 08/12] block, scsi: Introduce blk_pm_runtime_exit()

2018-08-09 Thread jianchao.wang
Hi Bart On 08/10/2018 03:41 AM, Bart Van Assche wrote: > +void blk_pm_runtime_exit(struct request_queue *q) > +{ > + if (!q->dev) > + return; > + > + pm_runtime_get_sync(q->dev); > + q->dev = NULL; > +} > +EXPORT_SYMBOL(blk_pm_runtime_exit); > + > /** > * blk_pre_runtime