Re: [PATCHSET v2] Add support for write life time hints

2017-06-16 Thread Jens Axboe
On 06/16/2017 09:52 AM, Christoph Hellwig wrote: > On Fri, Jun 16, 2017 at 08:40:11AM -0600, Jens Axboe wrote: >> On 06/16/2017 07:58 AM, Christoph Hellwig wrote: >From my perspective, all I really care about is the 4 hints. It's a simple enough interface that applications can understand

Re: [PATCHSET v2] Add support for write life time hints

2017-06-16 Thread Christoph Hellwig
On Fri, Jun 16, 2017 at 08:40:11AM -0600, Jens Axboe wrote: > On 06/16/2017 07:58 AM, Christoph Hellwig wrote: > >> >From my perspective, all I really care about is the 4 hints. It's a > >> simple enough interface that applications can understand and use it, and > >> we don't need any management

Re: [PATCHSET v2] Add support for write life time hints

2017-06-16 Thread Jens Axboe
On 06/16/2017 07:58 AM, Christoph Hellwig wrote: >> >From my perspective, all I really care about is the 4 hints. It's a >> simple enough interface that applications can understand and use it, and >> we don't need any management of actual stream IDs. I think that has the >> highest chance of

Re: [PATCHSET v2] Add support for write life time hints

2017-06-16 Thread Christoph Hellwig
> >From my perspective, all I really care about is the 4 hints. It's a > simple enough interface that applications can understand and use it, and > we don't need any management of actual stream IDs. I think that has the > highest chance of success. Modifying an application to use it is > trivial,

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Jens Axboe
On 06/14/2017 09:57 PM, Jens Axboe wrote: > On 06/14/2017 09:53 PM, Andreas Dilger wrote: >> On Jun 14, 2017, at 9:26 PM, Jens Axboe wrote: >>> On Wed, Jun 14, 2017 at 5:39 PM, Andreas Dilger wrote: On Jun 14, 2017, at 10:04 AM, Martin K. Petersen

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Andreas Dilger
On Jun 14, 2017, at 9:26 PM, Jens Axboe wrote: > On Wed, Jun 14, 2017 at 5:39 PM, Andreas Dilger wrote: >> On Jun 14, 2017, at 10:04 AM, Martin K. Petersen >> wrote: >>> Christoph, >>> I think what Martin wants (or at least

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Jens Axboe
On 06/14/2017 09:53 PM, Andreas Dilger wrote: > On Jun 14, 2017, at 9:26 PM, Jens Axboe wrote: >> On Wed, Jun 14, 2017 at 5:39 PM, Andreas Dilger wrote: >>> On Jun 14, 2017, at 10:04 AM, Martin K. Petersen >>> wrote:

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Jens Axboe
On Wed, Jun 14, 2017 at 5:39 PM, Andreas Dilger wrote: > On Jun 14, 2017, at 10:04 AM, Martin K. Petersen > wrote: >> Christoph, >> >>> I think what Martin wants (or at least what I'd want him to want) is >>> to define a few REQ_* bits that mirror

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Andreas Dilger
On Jun 14, 2017, at 10:04 AM, Martin K. Petersen wrote: > Christoph, > >> I think what Martin wants (or at least what I'd want him to want) is >> to define a few REQ_* bits that mirror the RWF bits, use that to >> transfer the information down the stack, and then

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Jens Axboe
On 06/14/2017 10:04 AM, Martin K. Petersen wrote: > > Christoph, > >> I think what Martin wants (or at least what I'd want him to want) is >> to define a few REQ_* bits that mirror the RWF bits, use that to >> transfer the information down the stack, and then only translate it >> to stream ids

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Jens Axboe
On 06/14/2017 10:04 AM, Martin K. Petersen wrote: > > Christoph, > >> I think what Martin wants (or at least what I'd want him to want) is >> to define a few REQ_* bits that mirror the RWF bits, use that to >> transfer the information down the stack, and then only translate it >> to stream ids

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Martin K. Petersen
Christoph, > I think what Martin wants (or at least what I'd want him to want) is > to define a few REQ_* bits that mirror the RWF bits, use that to > transfer the information down the stack, and then only translate it > to stream ids in the driver. Yup. If we have enough space in the existing

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Jens Axboe
On 06/14/2017 10:00 AM, Martin K. Petersen wrote: > > Jens, > >> So how about we just call it "write_hint"? It sounds mostly like a >> naming issue to me, as you would then map that to some specific stream >> in your driver. You're free to do that right now. They are all flags, >> it's just

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Jens Axboe
On 06/14/2017 10:01 AM, Christoph Hellwig wrote: > On Wed, Jun 14, 2017 at 09:53:05AM -0600, Jens Axboe wrote: >> So how about we just call it "write_hint"? It sounds mostly like a >> naming issue to me, as you would then map that to some specific stream >> in your driver. You're free to do that

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Christoph Hellwig
On Wed, Jun 14, 2017 at 09:53:05AM -0600, Jens Axboe wrote: > So how about we just call it "write_hint"? It sounds mostly like a > naming issue to me, as you would then map that to some specific stream > in your driver. You're free to do that right now. They are all flags, > it's just packed as a

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Martin K. Petersen
Jens, > So how about we just call it "write_hint"? It sounds mostly like a > naming issue to me, as you would then map that to some specific stream > in your driver. You're free to do that right now. They are all flags, > it's just packed as a value to not waste too much space. Sure, that's

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Jens Axboe
On 06/14/2017 09:45 AM, Martin K. Petersen wrote: > > Jens, > >> A new iteration of this patchset, previously known as write streams. >> As before, this patchset aims at enabling applications split up >> writes into separate streams, based on the perceived life time >> of the data written. This

Re: [PATCHSET v2] Add support for write life time hints

2017-06-14 Thread Martin K. Petersen
Jens, > A new iteration of this patchset, previously known as write streams. > As before, this patchset aims at enabling applications split up > writes into separate streams, based on the perceived life time > of the data written. This is useful for a variety of reasons: > > - With NVMe 1.3