Re: [PATCH] Btrfs-progs: add support for mixed data+metadata block groups

2011-04-08 Thread liubo
On 12/10/2010 02:31 AM, Josef Bacik wrote: So alot of crazy people (I'm looking at you Meego) want to use btrfs on phones and such with small devices. Unfortunately the way we split out metadata/data chunks it makes space usage inefficient for volumes that are smaller than 1gigabyte. So add

[PATCH] Btrfs: fix easily get into ENOSPC in mixed case

2011-04-08 Thread liubo
When a btrfs disk is created by mixed data metadata option, it will have no pure data or pure metadata space info. In btrfs's for-linus branch, commit 78b1ea13838039cd88afdd62519b40b344d6c920 (Btrfs: fix OOPS of empty filesystem after balance) initializes space infos at the very beginning. The

btrfs-control: no such device

2011-04-08 Thread Helmut Hullen
Hallo, linux-btrfs, when I run balance or delete and /dev/btrfs-control doesn't exist or is nor properly designed (I don't use udev) then the program shows an error message and then continiues its work; the result is garbage. The programs (or program options) which use a wellformed device

scanning cdrom and floppy

2011-04-08 Thread Helmut Hullen
Hallo, linux-btrfs, is the patch mentionend in http://article.gmane.org/gmane.comp.file-systems.btrfs/7473 included now? I still get error messages related to floppy when I run balance, when I run show then btrfs still tries many non existing devices (I don't use udev). Kernel

Re: [PATCH v4 1/8] btrfs: Balance progress monitoring

2011-04-08 Thread David Sterba
Hi, a missing check ... On Thu, Apr 07, 2011 at 06:06:08PM +0100, Hugo Mills wrote: This patch introduces a basic form of progress monitoring for balance operations, by counting the number of block groups remaining. The information is exposed to userspace by an ioctl. Signed-off-by: Hugo

Re: [PATCH] Btrfs-progs: add support for mixed data+metadata block groups

2011-04-08 Thread Josef Bacik
On 04/08/2011 03:31 AM, liubo wrote: On 12/10/2010 02:31 AM, Josef Bacik wrote: So alot of crazy people (I'm looking at you Meego) want to use btrfs on phones and such with small devices. Unfortunately the way we split out metadata/data chunks it makes space usage inefficient for volumes that

Re: [PATCH v4 1/8] btrfs: Balance progress monitoring

2011-04-08 Thread David Sterba
Hi, sorry for separate mail, just noticed a kfree inside a spinlock below On Thu, Apr 07, 2011 at 06:06:08PM +0100, Hugo Mills wrote: diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c @@ -2115,10 +2162,20 @@ int btrfs_balance(struct btrfs_root *dev_root)

Re: 2.6.29-rc2 oops and assertion failure...

2011-04-08 Thread Josef Bacik
On 04/07/2011 10:26 PM, Daniel J Blueman wrote: Hi Josef, Chris, On 8 April 2011 00:23, Josef Bacikjo...@redhat.com wrote: On 04/07/2011 03:21 AM, Daniel J Blueman wrote: When running a practical stress-test on 2.6.29-rc2 trying to reproduce an older (extent refcounting) issue, I am

Re: [PATCH v4 1/8] btrfs: Balance progress monitoring

2011-04-08 Thread Hugo Mills
Hi, Li, Thanks for the comments. On Fri, Apr 08, 2011 at 10:26:17AM +0800, Li Zefan wrote: 01:06, Hugo Mills wrote: This patch introduces a basic form of progress monitoring for balance operations, by counting the number of block groups remaining. The information is exposed to

Re: [PATCH v4 1/8] btrfs: Balance progress monitoring

2011-04-08 Thread Hugo Mills
On Fri, Apr 08, 2011 at 03:37:15PM +0200, David Sterba wrote: Hi, sorry for separate mail, just noticed a kfree inside a spinlock below On Thu, Apr 07, 2011 at 06:06:08PM +0100, Hugo Mills wrote: diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c @@ -2115,10 +2162,20 @@ int

Re: btrfs-control: no such device

2011-04-08 Thread Felix Blanke
Hi, nope. All patches to the btrfs-progs aren't yet in the git. I think it's up to chris to push all the patches. Regards, Felix Am 08 Apr 2011 14:00:00 +0200 schrieb Helmut Hullen hul...@t-online.de: Hallo, linux-btrfs, when I run balance or delete and /dev/btrfs-control doesn't exist

Re: 2.6.39-rc1: btrfs WARNING: at fs/btrfs/inode.c:2177

2011-04-08 Thread Josef Bacik
On 04/08/2011 01:53 AM, Jeff Wu wrote: Hi , I applied the patch to 2.6.39-rc1,took the following steps to compile it:make make modules_install make install mkinitramfs but , it seam that it don't run to WARN_ON(block_rsv == root-orphan_block_rsv); i attached the codes and logs at the below:

Re: [PATCH v4 1/8] btrfs: Balance progress monitoring

2011-04-08 Thread David Sterba
a missing check ... ah, forget it, On Fri, Apr 08, 2011 at 03:12:21PM +0200, David Sterba wrote: diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 5fdb2ab..a8fbb07 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -2375,6 +2375,38 @@ static noinline long

[PATCH] Btrfs: check for duplicate iov_base's when doing dio reads

2011-04-08 Thread Josef Bacik
Apparently it is ok to submit a read to an IDE device with the same target page for different offsets. This is what Windows does under qemu. The problem is under DIO we expect them to be different buffers for checksumming reasons, and so this sort of thing will result in checksum errors, when in

O_DIRECT and Btrfs == checksumming nightmare

2011-04-08 Thread Josef Bacik
Hello, So I've been trying to track down checksumming errors Eric Paris was getting while running Windows 7 in qemu. Turns out we had one valid problem (we don't deal well with reading with an iovec with two iov_base's that are the same), and we have a problem with the pages being changed

Re: [PATCH] Btrfs: fix easily get into ENOSPC in mixed case

2011-04-08 Thread Sergei Trofimovich
On Fri, 08 Apr 2011 16:44:37 +0800 liubo liubo2...@cn.fujitsu.com wrote: When a btrfs disk is created by mixed data metadata option, it will have no pure data or pure metadata space info. In btrfs's for-linus branch, commit 78b1ea13838039cd88afdd62519b40b344d6c920 (Btrfs: fix OOPS of

Re: [PATCH] Btrfs: fix easily get into ENOSPC in mixed case

2011-04-08 Thread Sergei Trofimovich
When a btrfs disk is created by mixed data metadata option, it will have no pure data or pure metadata space info. In btrfs's for-linus branch, commit 78b1ea13838039cd88afdd62519b40b344d6c920 (Btrfs: fix OOPS of empty filesystem after balance) initializes space infos at the

Re: [PATCH] Btrfs: fix easily get into ENOSPC in mixed case

2011-04-08 Thread Sergei Trofimovich
In btrfs's for-linus branch, commit 78b1ea13838039cd88afdd62519b40b344d6c920 (Btrfs: fix OOPS of empty filesystem after balance) initializes space infos at the very beginning. The problem is this initialization does not take the mixed case into account, which will cause

[PATCH] Btrfs: cleanup btrfs_alloc_path()'s caller code

2011-04-08 Thread Yoshinori Sano
This patch checks return value of btrfs_alloc_path() and removes BUG_ON(). Signed-off-by: Yoshinori Sano yoshinori.s...@gmail.com --- fs/btrfs/dir-item.c|2 ++ fs/btrfs/extent-tree.c | 12 fs/btrfs/file-item.c |6 -- fs/btrfs/file.c|3 ++-

[PATCH] Btrfs: fix memory leaks in btrfs_new_inode()

2011-04-08 Thread Yoshinori Sano
This patch fixes memory leaks in btrfs_new_inode(). Signed-off-by: Yoshinori Sano yoshinori.s...@gmail.com --- fs/btrfs/inode.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index aa116dc..d8c93c1 100644 --- a/fs/btrfs/inode.c

switching balance into background

2011-04-08 Thread Helmut Hullen
Hallo, linux-btrfs, I can't switch a running btrfs filesystem balance ... via ctrl z bg into the background, with other jobs this way works. The stopping command ctrl z doesn't work. (may be on other keyboards it's ctrl y) What goes wrong? Viele Gruesse! Helmut -- To