Re: [PATCH] btrfs: fix directory offsets for '.' and '..' entries

2011-09-11 Thread Grazvydas Ignotas
On Mon, Sep 12, 2011 at 12:06 AM, Christoph Hellwig wrote: > On Sun, Sep 11, 2011 at 11:33:36PM +0300, Grazvydas Ignotas wrote: >> Currently getdents syscall returns wrong offset for '.' directory entry, >> which confuses some programs like wine. This can be observed with an >> example program get

[PATCH] xfstests: add new getdents test

2011-09-11 Thread Grazvydas Ignotas
The test checks if no duplicate d_off values are returned and that those values are seekable to the right inodes. Signed-off-by: Grazvydas Ignotas --- 257 | 56 +++ 257.out |2 + group |1 + src/Makefile|2 +- sr

Re: [PATCH] btrfs: fix directory offsets for '.' and '..' entries

2011-09-11 Thread Tsutomu Itoh
The same patch has been posted about one month ago. http://marc.info/?l=linux-btrfs&m=131363399500506&w=2 Thanks, Tsutomu (2011/09/12 5:33), Grazvydas Ignotas wrote: > Currently getdents syscall returns wrong offset for '.' directory entry, > which confuses some programs like wine. This can b

Re: [PATCH] btrfs: fix directory offsets for '.' and '..' entries

2011-09-11 Thread Christoph Hellwig
On Sun, Sep 11, 2011 at 11:33:36PM +0300, Grazvydas Ignotas wrote: > Currently getdents syscall returns wrong offset for '.' directory entry, > which confuses some programs like wine. This can be observed with an > example program getdents(2) manpage: Can you submit a patch to add your testcase to

[PATCH] btrfs: fix directory offsets for '.' and '..' entries

2011-09-11 Thread Grazvydas Ignotas
Currently getdents syscall returns wrong offset for '.' directory entry, which confuses some programs like wine. This can be observed with an example program getdents(2) manpage: $ ./a.out /testfs/ --- nread=96 --- i-node# file type d_reclen d_off d_name 256 dire

Re: graceful handling of removing a plugable storage device that is being written to

2011-09-11 Thread Martin Steigerwald
Am Sonntag, 11. September 2011 schrieb Geert Uytterhoeven: > On Sun, Sep 11, 2011 at 18:53, Martin Steigerwald wrote: > > Frankly, I never tried this on AmigaOS. I know that AmigaOS expects > > the exact same floppy disk to be inserted again. Only the same name > > isn´t enough. But I have no ide

Re: graceful handling of removing a plugable storage device that is being written to

2011-09-11 Thread Geert Uytterhoeven
On Sun, Sep 11, 2011 at 18:53, Martin Steigerwald wrote: > Frankly, I never tried this on AmigaOS. I know that AmigaOS expects the > exact same floppy disk to be inserted again. Only the same name isn´t > enough. But I have no idea, what AmigaOS would have done, when I inserted Are you sure the v

Re: graceful handling of removing a plugable storage device that is being written to

2011-09-11 Thread Martin Steigerwald
Am Sonntag, 11. September 2011 schrieb Hin-Tak Leung: > --- On Sun, 11/9/11, Martin Steigerwald wrote: > > Cc to BTRFS mailinglist as it > > triggered the idea of mine again. > > > > > > Hi! > > > > Today I did it again and removed a BTRFS partition that is > > written too. > > That BTRFS as of

Re: graceful handling of removing a plugable storage device that is being written to

2011-09-11 Thread Hin-Tak Leung
--- On Sun, 11/9/11, Martin Steigerwald wrote: > Cc to BTRFS mailinglist as it > triggered the idea of mine again. > > > Hi! > > Today I did it again and removed a BTRFS partition that is > written too. > That BTRFS as of Kernel 3.0.3 (debian package) does not > like very much. I > think tha

graceful handling of removing a plugable storage device that is being written to

2011-09-11 Thread Martin Steigerwald
Cc to BTRFS mailinglist as it triggered the idea of mine again. Hi! Today I did it again and removed a BTRFS partition that is written too. That BTRFS as of Kernel 3.0.3 (debian package) does not like very much. I think thats a known issue and I wrote a mail to BTRFS mailing list about it. I

btrfs crashes after removing drive that is written to and failed mount until btrfs-zero-log afterwards

2011-09-11 Thread Martin Steigerwald
Hi! Has a developer fixed this issue in the meanwhile? I did it just again today. I overlooked Dolphin´s "device is busy" message and unplugged it again. I had to reboot, a mount attempt failed, I had to reboot another time, after btrfs-zero-log it worked. I have traces available but I think t