subvolumes: default and IDs

2012-07-30 Thread Florian Lindner
Hey! I recently starting playing with btrfs and subvolume, but it has left me puzzled: Distribution is Archlinux, Kernel is 3.4.6. root@horus /mnt # mkfs.btrfs -L test /dev/sdb1 WARNING! - Btrfs Btrfs v0.19 IS EXPERIMENTAL WARNING! - see http://btrfs.wiki.kernel.org before using fs created

[patch] Btrfs: fix some endian bugs handling the root times

2012-07-30 Thread Dan Carpenter
trans-transid is cpu endian but we want to store the data as little endian. item-ctime.nsec is only 32 bits, not 64. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Applies to linux-next. diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 43f0012..a1fbca0 100644 ---

[patch 1/2] Btrfs: checking for NULL instead of IS_ERR

2012-07-30 Thread Dan Carpenter
add_qgroup_rb() never returns NULL, only error pointers. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Applies to linux-next. diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index bc424ae..b650155 100644 --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c @@ -1364,8 +1364,10 @@ int

[patch 2/2] Btrfs: fix some error codes in btrfs_qgroup_inherit()

2012-07-30 Thread Dan Carpenter
These are returning zero when it should be returning a negative error code. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Applies to linux-next. diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index b650155..38b42e7 100644 --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c @@ -1371,8

Re: severe hardlink bug

2012-07-30 Thread Arnd Hannemann
Am 29.07.2012 21:13, schrieb C Anthony Risinger: On Sun, Jul 29, 2012 at 2:02 PM, Konstantin Dmitriev ksee.zelga...@gmail.com wrote: Dipl.-Ing. Michael Niederle mniederle at gmx.at writes: I reinstalled over 700 packages - plt-scheme beeing the only one failing due to the btrfs link

[PATCH v2] xfstests: add btrfs snapshot function test

2012-07-30 Thread zhoubo
From: Zhou Bo zhoub-f...@cn.fujitsu.com This patch adds btrfs snapshot function test to xfstests Signed-off-by: Zhou Bo zhoub-f...@cn.fujitsu.com --- v2: address comments from David Sterba 285 | 387 +++ 285.out |2 + group

Re: severe hardlink bug

2012-07-30 Thread C Anthony Risinger
On Mon, Jul 30, 2012 at 4:36 AM, Arnd Hannemann a...@arndnet.de wrote: Am 29.07.2012 21:13, schrieb C Anthony Risinger: On Sun, Jul 29, 2012 at 2:02 PM, Konstantin Dmitriev ksee.zelga...@gmail.com wrote: Dipl.-Ing. Michael Niederle mniederle at gmx.at writes: I reinstalled over 700 packages

Re: [PATCH 2/2] Btrfs: fix the snapshot that should not exist

2012-07-30 Thread Miao Xie
On fri, 27 Jul 2012 16:52:21 +0900, Hidetoshi Seto wrote: # ll /mnt/1/snap0/1 total 0 [None] # cd /mnt/1/snap0/1/snap0 [Enter a unexisted directory successfully...] I confirmed that mkdir snap0 failed with File exists and that rmdir can remove the directory snap0. So it is a kind of

Re: severe hardlink bug

2012-07-30 Thread Helmut Hullen
Hallo, Arnd, Du meintest am 30.07.12: btrfs only fails when you have hundreds of hardlinks to the same file in the *same* directory ... certainly not a standard use case. Actually, hundreds of hardlinks is certainly over optimistic. In my testing 15 links in the same directory were enough

Re: [PATCH 2/2] Btrfs: fix the snapshot that should not exist

2012-07-30 Thread Miao Xie
On fri, 27 Jul 2012 14:29:57 +0200, David Sterba wrote: On Fri, Jul 27, 2012 at 04:52:21PM +0900, Hidetoshi Seto wrote: (2012/07/26 15:57), Miao Xie wrote: btrfs_abort_transaction(trans, root, ret); goto fail; } @@ -1386,13 +1408,13 @@ int btrfs_commit_transaction(struct

Re: subvolumes: default and IDs

2012-07-30 Thread Calvin Walton
On Mon, 2012-07-30 at 09:56 +0200, Florian Lindner wrote: Hey! I recently starting playing with btrfs and subvolume, but it has left me puzzled: root@horus /mnt/test # btrfs subvolume get-default . ID 256 top level 5 path sv1 ID 259 top level 5 path sv2 What is the default subvolume

Re: subvolumes: default and IDs

2012-07-30 Thread Liu Bo
On 07/30/2012 03:56 PM, Florian Lindner wrote: Hey! I recently starting playing with btrfs and subvolume, but it has left me puzzled: Distribution is Archlinux, Kernel is 3.4.6. root@horus /mnt # mkfs.btrfs -L test /dev/sdb1 WARNING! - Btrfs Btrfs v0.19 IS EXPERIMENTAL WARNING! - see

Re: subvolumes: default and IDs

2012-07-30 Thread Swâmi Petaramesh
Le 30/07/2012 13:29, Calvin Walton a écrit : It looks like there's currently a bug in btrfs-progs - the 'get-default' command is actually doing a 'list' instead of printing the default. With any luck it's just a little error in the command-line parsing and should be easy to fix... I've fallen

Re: [PATCH 0/1] Btrfs: Explicitly include vmalloc.h in send.c

2012-07-30 Thread Josef Bacik
On Sat, Jul 28, 2012 at 04:20:02PM -0600, Mitch Harder wrote: When compiling without SMP and generic x86_64, I encountered the following errors due to vmalloc.h not being implicitly included: CC fs/btrfs/send.o fs/btrfs/send.c: In function ‘fs_path_free’: fs/btrfs/send.c:185:4:

Re: [PATCH 0/8] Set bi_rw when alloc bio before call bio_add_page.

2012-07-30 Thread Konrad Rzeszutek Wilk
On Mon, Jul 30, 2012 at 03:14:28PM +0800, majianpeng wrote: When exec bio_alloc, the bi_rw is zero.But after calling bio_add_page, What about submit_bio? That sets the bi_rw as well? it will use bi_rw. Fox example, in functiion __bio_add_page,it will call merge_bvec_fn(). function. The

Re: btrfs send/receive: if new inode ino is less than its new directory ino, incorrect path is sent

2012-07-30 Thread Alex Lyakas
Hi, I did not apply the patch but instead added a check for dir != tmp_dir only. The reason to not check for gen is that I have a rule in my mind: I only pass the generation number to functions where I want to know the *current* state. is_first_ref is for permanent state, the return value

Re: severe hardlink bug

2012-07-30 Thread Martin Steigerwald
Am Sonntag, 24. Januar 2010 schrieb Michael Niederle: I'm using btrfs with a kernel 2.6.32.2 (builtin) as the root file system of a Gentoo Linux installation. Upgrade your kernel! This kernel is wy to old for any production use of BTRFS. Heck, upstream still did not

segfault on mounting second device

2012-07-30 Thread Zbigniew Jędrzejewski-Szmek
Hi, I was trying to mount two-disk btrfs without the first disk (the setup is RAID1 data metadata on two disks). Kernel is 3.5.0-6-generic from Ubuntu. [ 977.061470] device label HOME devid 2 transid 24686 /dev/sda3 [ 977.062992] btrfs: allowing degraded mounts [ 977.063300] btrfs: disk

Re: segfault on mounting second device

2012-07-30 Thread Josef Bacik
On Mon, Jul 30, 2012 at 12:25:01PM -0600, Zbigniew Jędrzejewski-Szmek wrote: Hi, I was trying to mount two-disk btrfs without the first disk (the setup is RAID1 data metadata on two disks). Kernel is 3.5.0-6-generic from Ubuntu. [ 977.061470] device label HOME devid 2 transid 24686

Re: btrfs send/receive: if new inode ino is less than its new directory ino, incorrect path is sent

2012-07-30 Thread Alexander Block
On Mon, Jul 30, 2012 at 7:35 PM, Alex Lyakas alex.bolshoy.bt...@gmail.com wrote: Hi, I did not apply the patch but instead added a check for dir != tmp_dir only. The reason to not check for gen is that I have a rule in my mind: I only pass the generation number to functions where I want to

Re: subvolumes: default and IDs

2012-07-30 Thread Alexander Karbstein
Hi Florian, in case you would like to have some code references, to better understand how it works: 1. Why is the default subvolid=5? The trees in Btrfs all are referenced in the root tree by their OBJECTIDs. You can find the definitions(magic numbers) for the main trees in ctree.h: For example,

Re: subvolumes: default and IDs

2012-07-30 Thread Alexander Karbstein
Hi everybody, I believe Florian came across some odd behaviour of btrfs subvolume set-default which might still not be perfect in the current btrfs-progs: It does not seem to change the default subvolume to the original root fs tree if he does btrfs subvolume set-default 0 /path/to/fs. I am

[PATCH] Btrfs-progs: Enabled setting root subvolume with subvolid=0

2012-07-30 Thread Alexander Karbstein
The command btrfs subvolume set-default 0 /path/to/fs changed the default subvolume to whatever subvolume was currently mounted on /path/to/fs. This patch changes this behaviour to set the default subvolume to BTRFS_FS_TREE_OBJECTID in case the user asks for subvolid=0 Signed-off-by: Alexander

Re: Re: [PATCH 0/8] Set bi_rw when alloc bio before call bio_add_page.

2012-07-30 Thread Dave Chinner
On Tue, Jul 31, 2012 at 08:55:59AM +0800, majianpeng wrote: On 2012-07-31 05:42 Dave Chinner da...@fromorbit.com Wrote: On Mon, Jul 30, 2012 at 03:14:28PM +0800, majianpeng wrote: When exec bio_alloc, the bi_rw is zero.But after calling bio_add_page, it will use bi_rw. Fox example, in

Re: balance disables nodatacow

2012-07-30 Thread Liu Bo
On 07/31/2012 03:55 AM, Kyle Gates wrote: I have a 3 disk raid1 filesystem mounted with nodatacow. I have a folder in said filesystem with the 'C' NOCOW 'Z' Not_Compressed flags set for good measure. I then copy in a large file and proceed to make random modifications. Filefrag shows no

Re: balance disables nodatacow

2012-07-30 Thread Liu Bo
On 07/31/2012 12:35 PM, Kyle Gates wrote: On Mon, Jul 30, 2012 at 9:00 PM, Liu Bo liubo2...@cn.fujitsu.com wrote: On 07/31/2012 03:55 AM, Kyle Gates wrote: I have a 3 disk raid1 filesystem mounted with nodatacow. I have a folder in said filesystem with the 'C' NOCOW 'Z' Not_Compressed

Re: filesystem finder / fixer

2012-07-30 Thread Roman Mamedov
On Mon, 30 Jul 2012 23:26:42 -0400 (EDT) serial...@lavabit.com wrote: 1) is there a tool to help me recover data from my fs? I don't have a backup of my partition table and so I have about 500GB of space where a few partitionns might reside... GPT partitions mind you If you only lost the

[PATCH 1/3 RESEND] Btrfs-progs: search subvolumes with proper objectid

2012-07-30 Thread Liu Bo
Btrfs's subvolume/snapshot is limited to [BTRFS_FIRST_FREE_OBJECTID, BTRFS_LAST_FREE_OBJECTID], so just apply the range. Signed-off-by: Liu Bo liubo2...@cn.fujitsu.com --- btrfs-list.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/btrfs-list.c b/btrfs-list.c index

[PATCH 3/3] Btrfs-progs: list snapshots by generation

2012-07-30 Thread Liu Bo
The idea is that we usually use snapshot to backup/restore our data, and the common way can be a cron script which makes lots of snapshots, so we can end up with spending some time to find the latest snapshot to restore. This adds a feature for 'btrfs subvolume list' to let it list snapshots by

[PATCH 2/3 RESEND] Btrfs-progs: show generation in command btrfs subvol list

2012-07-30 Thread Liu Bo
This adds the ability to show root's modification generation when we use btrfs subvol list. NOTE: Like file's atime and ctime, root's generation also has 'creation generation' and 'modification generation'. The generation that we're going to show is 'modification generation', and the next patch