Re: [PATCH 00/26] Btrfs: Add device replace code

2012-11-09 Thread Michael Kjörling
On 8 Nov 2012 18:31 +0100, from sbehr...@giantdisaster.de (Stefan Behrens): btrfs device replace cancel path was the point when I gave up putting it below the device commands. IMO that's just too long, too much to type. How often is one going to type that? I like the idea of consistency with

Re: [PATCH 15/26] Btrfs: add a new source file with device replace code

2012-11-09 Thread Stefan Behrens
On Fri, 9 Nov 2012 08:44:01 +0800, Liu Bo wrote: On Thu, Nov 08, 2012 at 06:24:36PM +0100, Stefan Behrens wrote: On Thu, 8 Nov 2012 22:50:47 +0800, Liu Bo wrote: On Tue, Nov 06, 2012 at 05:38:33PM +0100, Stefan Behrens wrote: + trans = btrfs_start_transaction(root, 0); why a

RE: [PATCH 24/26] Btrfs: increase BTRFS_MAX_MIRRORS by one for dev replace

2012-11-09 Thread David Pottage
From: linux-btrfs-ow...@vger.kernel.org [mailto:linux-btrfs-ow...@vger.kernel.org] On Behalf Of Stefan Behrens Sent: 06 November 2012 16:39 To: linux-btrfs@vger.kernel.org Subject: [PATCH 24/26] Btrfs: increase BTRFS_MAX_MIRRORS by one for dev replace This change of the define is effective in

Re: [PATCH 24/26] Btrfs: increase BTRFS_MAX_MIRRORS by one for dev replace

2012-11-09 Thread Stefan Behrens
On Fri, 9 Nov 2012 10:47:39 +, David Pottage wrote: Are you assuming the user is only replacing one device at once? If the user is upgrading their disc array to increase the capacity (or speed), then it would make sense for them to replace all the drives in the array at once. Is that

Re: [PATCH 15/26] Btrfs: add a new source file with device replace code

2012-11-09 Thread Liu Bo
On Fri, Nov 09, 2012 at 11:19:17AM +0100, Stefan Behrens wrote: On Fri, 9 Nov 2012 08:44:01 +0800, Liu Bo wrote: On Thu, Nov 08, 2012 at 06:24:36PM +0100, Stefan Behrens wrote: On Thu, 8 Nov 2012 22:50:47 +0800, Liu Bo wrote: On Tue, Nov 06, 2012 at 05:38:33PM +0100, Stefan Behrens wrote:

Re: fs/btrfs/dev-replace.c:486:17: sparse: incompatible types in comparison expression (different address spaces)

2012-11-09 Thread Stefan Behrens
On Thu, 8 Nov 2012 15:35:41 +0800, Fengguang Wu wrote: Hi Stefan, FYI, there are new sparse warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git master head: c1014be59ba93855c31fda9d9cf4319cc6f9eeb1 commit: