[PATCH] Btrfs: fix a mismerge in btrfs_balance()

2013-03-06 Thread Ilya Dryomov
Raid56 merge (merge commit e942f88) had mistakenly removed a call to __cancel_balance(), which resulted in balance not cleaning up after itself after a successful finish. (Cleanup includes switching the state, removing the balance item and releasing mut_ex_op testnset lock.) Bring it back.

Re: [PATCH v2] btrfs: clean snapshots one by one

2013-03-06 Thread Ilya Dryomov
On Fri, Mar 01, 2013 at 05:30:57PM +0100, David Sterba wrote: The mail did not make it to the list on Monday, anyway, now I have a few testing results to share. The umount responsiveness is much improved, it took a few seconds when there were many roots to clean scheduled. With $ echo

Re: [PATCH] xfstests: Fix hang when mkfs.btrfs isn't present

2013-03-06 Thread Rich Johnston
This patch has been committed. Thanks --Rich commit 52f4953ac4a377f9f7fc870d2a81f30c3e5d3c7f Author: Eric Sandeen sand...@sandeen.net Date: Tue Mar 5 22:41:54 2013 + xfstests: Fix hang when mkfs.btrfs isn't present My earlier patch (xfstests: handle new mkfs.btrfs -f option

Re: [PATCH RFC] Btrfs: improve delalloc reservation

2013-03-06 Thread Josef Bacik
On Wed, Mar 06, 2013 at 04:01:09AM -0700, Liu Bo wrote: Although we already have over commit stuff, btrfs write performance still suffers from over reservation a lot. I'm getting ready to rip all of the reservation code out and put in a ENOSPC log for a buffer area for delalloc writes and

Re: [PATCH] Btrfs: improve the delayed inode throttling

2013-03-06 Thread Chris Mason
On Tue, Mar 05, 2013 at 07:45:34PM -0700, Miao Xie wrote: We re-queue the node just when there are some delayed items in the current node. But if the node still has delayed items after we deal with it, that is to say someone is accessing the node. So it is better to release it and deal with

[PATCH] btrfs: enhance superblock checks

2013-03-06 Thread David Sterba
The superblock checksum is not verified upon mount. awkward silence Add that check and also reorder existing checks to a more logical order. Current mkfs.btrfs does not calculate the correct checksum of super_block and thus a freshly created filesytem will fail to mount when this patch is

[PATCH] btrfs-progs: separate super_copy out of fs_info

2013-03-06 Thread David Sterba
Allocate fs_info::super_copy dynamically of full BTRFS_SUPER_INFO_SIZE and use it directly for saving superblock to disk. This fixes incorrect superblock checksum after mkfs. Signed-off-by: David Sterba dste...@suse.cz --- this is based on master 704a08cb8a so it could be merged asap

Re: [PATCH v2] btrfs: clean snapshots one by one

2013-03-06 Thread David Sterba
On Wed, Mar 06, 2013 at 11:08:57AM +0200, Ilya Dryomov wrote: On Fri, Mar 01, 2013 at 05:30:57PM +0100, David Sterba wrote: 3407 BUG_ON(fs_info-balance_ctl || atomic_read(fs_info-balance_running)); Were you by any chance running this on top of a for-linus that included a raid56

Re: [PATCH] btrfs: enhance superblock checks

2013-03-06 Thread Blair Zajac
On 03/06/2013 07:56 AM, David Sterba wrote: The superblock checksum is not verified upon mount. awkward silence Add that check and also reorder existing checks to a more logical order. Current mkfs.btrfs does not calculate the correct checksum of super_block and thus a freshly created

Re: [PATCH] btrfs: enhance superblock checks

2013-03-06 Thread David Sterba
On Wed, Mar 06, 2013 at 09:14:45AM -0800, Blair Zajac wrote: On 03/06/2013 07:56 AM, David Sterba wrote: /* + * Return 0 if the superblock checksum type matches the checksum value of that + * alghorithm. Pass the raw disk superblock data. I'm not familiar with the review policy on this

Re: [PATCH] btrfs: enhance superblock checks

2013-03-06 Thread Zach Brown
On Wed, Mar 06, 2013 at 04:56:40PM +0100, David Sterba wrote: The superblock checksum is not verified upon mount. awkward silence Hah! /* + * Return 0 if the superblock checksum type matches the checksum value of that + * alghorithm. Pass the raw disk superblock data. + */ +static int

Re: [PATCH] Btrfs: improve the delayed inode throttling

2013-03-06 Thread Miao Xie
On wed, 6 Mar 2013 09:53:28 -0500, Chris Mason wrote: On Tue, Mar 05, 2013 at 07:45:34PM -0700, Miao Xie wrote: We re-queue the node just when there are some delayed items in the current node. But if the node still has delayed items after we deal with it, that is to say someone is

Re: [PATCH] Btrfs: improve the delayed inode throttling

2013-03-06 Thread Miao Xie
On wed, 6 Mar 2013 09:53:28 -0500, Chris Mason wrote: [SNIP] static int btrfs_wq_run_delayed_node(struct btrfs_delayed_root *delayed_root, - struct btrfs_root *root, int all) + struct btrfs_root *root, int nr) { - struct

Re: [PATCH v2] btrfs: clean snapshots one by one

2013-03-06 Thread Chris Mason
On Wed, Mar 06, 2013 at 11:09:15AM -0700, David Sterba wrote: On Sat, Mar 02, 2013 at 11:32:07PM +0200, Alex Lyakas wrote: On Fri, Mar 1, 2013 at 6:17 PM, David Sterba dste...@suse.cz wrote: - btrfs_kill_all_delayed_nodes(root); + btrfs_kill_all_delayed_nodes(root);

Re: [PATCH] Btrfs: improve the delayed inode throttling

2013-03-06 Thread Miao Xie
On wed, 6 Mar 2013 22:06:50 -0500, Chris Mason wrote: On Wed, Mar 06, 2013 at 06:39:30PM -0700, Miao Xie wrote: On wed, 6 Mar 2013 09:53:28 -0500, Chris Mason wrote: [SNIP] + async_work-delayed_root = delayed_root; + async_work-work.func = btrfs_async_run_delayed_root; +