[PATCH] xfstests: remove recursive include in filter.btrfs

2013-04-21 Thread Eric Sandeen
Not sure how this happened, but filter.btrfs including itself leads to immense sadness for any file that includes it. (I got a segfault when I tried to run 307) Signed-off-by: Eric Sandeen sand...@redhat.com --- diff --git a/common/filter.btrfs b/common/filter.btrfs index b1aa733..99d04a6 100644

[PATCH] btrfs: move leak debug code to functions

2013-04-21 Thread Eric Sandeen
There was a time when sprinkling #ifdefs around was bad form. ;) We can clean up the code a bit by moving the leak-list adds/removes into functions and make things more readable. Signed-off-by: Eric Sandeen sand...@redhat.com --- p.s. maybe _debug_ should be in the function names? *shrug*

Re: [PATCH] btrfs-progs: update mkfs.btrfs help info for raid5/6

2013-04-21 Thread Zhi Yong Wu
I found this patch had been merged into David's unstable btrfs-progs git, but not into its master git, so don't know the reason. If it need me to send v2 based on your comments, please let me know, thanks. On Sun, Apr 21, 2013 at 5:33 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: I found this

Re: [PATCH 0/4] [RFC] btrfs: offline dedupe

2013-04-21 Thread Mark Fasheh
On Sat, Apr 20, 2013 at 05:49:25PM +0200, Gabriel de Perthuis wrote: Hi, The following series of patches implements in btrfs an ioctl to do offline deduplication of file extents. I am a fan of this patch, the API is just right. I just have a few tweaks to suggest to the argument checking.

[PATCH 0/2] btrfs-progs: standardize utility filenames and add default rules to Makefile

2013-04-21 Thread Eric Sandeen
2 patches here. The first renames the single .c files which are built into btrfs-$FOO commands - previously we built i.e. btrfs-calc-size from calc-size.c IMHO this helps separate out which files are main command-type files, and which are not. (Eventually I hope to move things into subdirs to

[PATCH 2/2] btrfs-progs: Add default rules to Makefile

2013-04-21 Thread Eric Sandeen
Add a default rule for any btrfs-$FOO or btrfs-$FOO.static target, allowing it to be built from btrfs-$FOO.c along with all the normal userspace objects. This gets rid of a lot of the cut and pasted rules for each individual command, and as an added bonus makes it easy to build any btrfs-$FOO

[PATCH V2] xfstests: remove recursive include in filter.btrfs

2013-04-21 Thread Eric Sandeen
Not sure how this happened, but filter.btrfs including itself leads to immense sadness for any file that includes it. (I got a segfault when I tried to run 307) It should be including the common/filter not common/filter.btrfs Signed-off-by: Eric Sandeen sand...@redhat.com --- diff --git

[PATCH V3] xfstests: fix common filter include in filter.btrfs

2013-04-21 Thread Eric Sandeen
Not sure how this happened, but filter.btrfs including itself leads to immense sadness for any file that includes it. (I got a segfault when I tried to run 307) It should be including ./common/filter not ./common/filter.btrfs Signed-off-by: Eric Sandeen sand...@redhat.com --- cripes, I'm sorry

Re: [PATCH 2/2] Btrfs: use a lock to protect incompat/compat flag of the super block

2013-04-21 Thread Miao Xie
On thu, 18 Apr 2013 00:17:11 +0200, David Sterba wrote: On Thu, Apr 11, 2013 at 06:30:16PM +0800, Miao Xie wrote: In order to avoid this problem, we introduce a lock named super_lock into the btrfs_fs_info structure. If we want to update incompat/compat flags of the super block, we must

Re: [PATCH] btrfs: move leak debug code to functions

2013-04-21 Thread Roger Binns
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 20/04/13 23:32, Eric Sandeen wrote: +#define btrfs_leak_list_add(new, head) do {} while (0); +#define btrfs_leak_list_del(entry)do {} while (0); Shouldn't the trailing semi-colons be omitted? Roger -BEGIN PGP SIGNATURE-

[PATCH 1/2] btrfs-progs: set generation_v2 any time we write a new root

2013-04-21 Thread Eric Sandeen
With this integration branch commit in place: 2bd1169 btrfs-progs: root_item generation_v2 is out of sync after btrfsck I started seeing generation mismatch messages from the kernel at mount time, after a fresh mkfs(!): btrfs: mismatching generation and generation_v2 found in root item...

[PATCH 2/2] btrfs-progs: enlarge root item if needed in btrfs_update_root

2013-04-21 Thread Eric Sandeen
This addresses the same issue as did: 2bd1169 btrfs-progs: root_item generation_v2 is out of sync after btrfsck but rather than optionally updating generation_v2 based on the size of the existing item, increase the size of the item as needed, and unconditionally set generation_v2. This matches

[PATCH 2/2 V2] btrfs-progs: update generation_v2 in btrfs_update_root

2013-04-21 Thread Eric Sandeen
This addresses the same issue as did: 2bd1169 btrfs-progs: root_item generation_v2 is out of sync after btrfsck but rather than optionally updating generation_v2 based on the size of the existing item, increase the size of the item as needed, and unconditionally set generation_v2. This matches

[PATCH V2] btrfs: move leak debug code to functions

2013-04-21 Thread Eric Sandeen
There was a time when sprinkling #ifdefs around was bad form. We can clean up the code a bit by moving the leak-list adds/removes into functions and make things more readable. Signed-off-by: Eric Sandeen sand...@redhat.com --- V2: remove extra semicolons on no-op #defines, thanks Roger! p.s.