Re: [PATCH 1/2] btrfs-progs: fix the long lines

2013-07-15 Thread Stefan Behrens
On Mon, 15 Jul 2013 13:35:26 +0800, Anand Jain wrote: trivial: cmds-replace.c contains long lines fix it Signed-off-by: Anand Jain anand.j...@oracle.com --- cmds-replace.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/cmds-replace.c

Re: [PATCH 2/2] btrfs-progs: close_all_devices() declared in multiple files

2013-07-15 Thread Stefan Behrens
On Mon, 15 Jul 2013 13:35:27 +0800, Anand Jain wrote: close_all_devices() is declared once in disk-io.c and again in btrfs-find-root.c I see no reasons or is there any ? This patch will fix it. Signed-off-by: Anand Jain anand.j...@oracle.com --- btrfs-find-root.c | 17

[PATCH] btrfs-progs: close_all_devices() in btrfs-find-root.c does nothing

2013-07-15 Thread Anand Jain
close_all_devices() is declared once in disk-io.c and again in btrfs-find-root.c. The one in latter is completely useless so delete it. This patch will fix it. Signed-off-by: Anand Jain anand.j...@oracle.com --- btrfs-find-root.c | 17 + disk-io.c |3 +-- disk-io.h

Re: Need help mounting broken btrfs Fedora 19

2013-07-15 Thread Dave Barnum
Thanks Wang, This was the result: root@ubuntu:/downloads/btrfs-progs# ./btrfs chunk-recover /dev/sdc2 no recoverable chunk Recover the chunk tree successfully. Still unable to mount. On Sun, Jul 14, 2013 at 2:03 PM, Wang Shilong wangshilong1...@gmail.com wrote: Hello, You call pull from:

[PATCH] Btrfs-progs: fix closing of opendir()

2013-07-15 Thread Wang Shilong
From: Wang Shilong wangsl.f...@cn.fujitsu.com valgrind complains open_file_or_dir() causes a memory leak.That is because if we open a directoy by opendir(), and then we should call closedir() to free memory. Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com --- btrfs-fragments.c | 4 +++-

[PATCH 1/1] Btrfs: volume: Replace PTR_RET with PTR_ERR_OR_ZERO

2013-07-15 Thread Sachin Kamat
PTR_RET is now deprecated. Use PTR_ERR_OR_ZERO instead. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Compile tested and based on the following tree: git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git (PTR_RET) Dependent on [1] [1]

Re: Troublesome failure mode and recovery

2013-07-15 Thread Jérôme Carretero
On Sat, 13 Jul 2013 12:14:04 -0400 Jérôme Carretero cj...@zougloub.eu wrote: Within the UML instance with python, I cannot do `ls` (`os.listdir()`) on my home folder (`/home/cJ`), and btrfs-restore only restores a few dot files in there. But I can get inode numbers and read files or

Re: filebench varmail + scrubber = btrfs_update_root bug

2013-07-15 Thread Duncan
George Amvrosiadis posted on Mon, 15 Jul 2013 00:56:29 -0400 as excerpted: I'm trying to run the varmail personality in filebench, on a 50GB btrfs filesystem. I am also starting the scrubber at the same time. I have applied the latest patches for 3.8.13 (hoping to fix log tree issues). Every

Re: [PATCH 1/2] btrfs-progs: fix the long lines

2013-07-15 Thread Eric Sandeen
On 7/15/13 12:35 AM, Anand Jain wrote: trivial: cmds-replace.c contains long lines fix it I realize that this is total bikeshedding, so you can take or leave it, but: One downside to this is that it makes it a little harder to grep for strings when they get arbitrarily split across lines. One

[PATCH] Btrfs: update drop progress before stopping snapshot dropping

2013-07-15 Thread Josef Bacik
Alex pointed out a problem and fix that exists in the drop one snapshot at a time patch. If we decide we need to exit for whatever reason (umount for example) we will just exit the snapshot dropping without updating the drop progress. So the next time we go to resume we will BUG_ON() because we

Re: [PATCH v3] btrfs: clean snapshots one by one

2013-07-15 Thread Josef Bacik
On Sun, Jul 14, 2013 at 07:20:04PM +0300, Alex Lyakas wrote: Hi, On Thu, Jul 4, 2013 at 10:52 PM, Alex Lyakas alex.bt...@zadarastorage.com wrote: Hi David, On Thu, Jul 4, 2013 at 8:03 PM, David Sterba dste...@suse.cz wrote: On Thu, Jul 04, 2013 at 06:29:23PM +0300, Alex Lyakas wrote:

[PATCH] Btrfs: fix lock leak when resuming snapshot deletion

2013-07-15 Thread Josef Bacik
We aren't setting path-locks[level] when we resume a snapshot deletion which means we won't unlock the buffer when we free the path. This causes deadlocks if we happen to re-allocate the block before we've evicted the extent buffer from cache. Thanks, Reported-by: Alex Lyakas

Re: [PATCH 1/2] list: add list_del_each_entry

2013-07-15 Thread Jörn Engel
On Fri, 5 July 2013 23:38:01 +0100, Filipe David Manana wrote: +#define list_del_each_entry(pos, head, member) \ + while (list_empty(head) (pos = list_first_entry((head), \ + typeof(*pos), member), list_del((head)-next), 1)) + Shouldn't it be while

Re: [PATCH 4/4] btrfs: offline dedupe

2013-07-15 Thread Zach Brown
Josef asked that I check out the offline dedup patches. I hope that I found the most recent posting in my archives :). The first three patches seemed fine. I have questions about the read/compare/clone core: + addr = kmap(page); + memcpy(buffer + bytes_copied, addr,

Re: Linux Plumbers IO File System Micro-conference

2013-07-15 Thread Ric Wheeler
On 07/12/2013 01:42 PM, faibish, sorin wrote: Can we have a discussion on Lustre client in the kernel? Thanks ./Sorin I am not sure that we have that much to do for Lustre on the client side. Is this a topic that would be of broad enough interest to include people outside of the kernel

[PATCH v3] btrfs: Cleanup for using BTRFS_SETGET_STACK instead of raw convert

2013-07-15 Thread Qu Wenruo
Some codes still use the cpu_to_lexx instead of the BTRFS_SETGET_STACK_FUNCS declared in ctree.h. Also added some BTRFS_SETGET_STACK_FUNCS for btrfs_header btrfs_timespec and other structures. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com Reviewed-by: Miao Xie miao...@cn.fujitsu.com