[PATCH] btrfs: remove a FIXME in btrfs_get_acl()

2014-05-18 Thread Zhang Zhen
There is no function returns a value of -ENOENT, so the check is useless. Remove it, and the redundant braces. Signed-off-by: Zhang Zhen --- fs/btrfs/acl.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c index ff9b399..cae7480 100644 --

[PATCH] btrfs-image: Fix a data race in build_chunk_tree.

2014-05-18 Thread Adam Buchbinder
A mdrestore_struct was being written to without its mutex being held. This race was found with ThreadSanitizer; the relevant part of the report looks like this: WARNING: ThreadSanitizer: data race (pid=18828) Write of size 8 at 0x7fc3d088 by main thread: #0 build_chunk_tree .../btrfs-pro

Re: [PATCH 2/3] btrfs-progs: add missing help option for rescue super-recover

2014-05-18 Thread Gui Hecheng
On Fri, 2014-05-16 at 18:41 +0200, David Sterba wrote: > On Fri, May 16, 2014 at 06:37:27PM +0200, David Sterba wrote: > > On Thu, May 15, 2014 at 09:29:08AM +0800, Gui Hecheng wrote: > > > Add '-h' option for help for super-recover, > > > update the manpage at the same time. > > > > We don't have

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-18 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand. From: Hugo Mills To: Qu Wenruo Date: 2014年05月18日 20:05 On Sun, May 18, 2014 at 03:04:33PM +0800, Qu Wenruo wrote: Original Message S

Re: [RFC PATCH 5/5] Btrfs: fix broken free space cache after the system crashed

2014-05-18 Thread Chris Mason
On 01/15/2014 07:00 AM, Miao Xie wrote: > When we mounted the filesystem after the crash, we got the following > message: > BTRFS error (device xxx): block group 4315938816 has wrong amount of free > space > BTRFS error (device xxx): failed to load free space cache for block group > 431593881

Re: Can a snapshot become a parent subvolume when its parent is deleted?

2014-05-18 Thread Marc MERLIN
On Wed, May 14, 2014 at 12:09:38PM -0600, Chris Murphy wrote: > > On May 14, 2014, at 7:50 AM, Marc MERLIN wrote: > > > So, I had btrfs_pool1 that was trashed/lost as discussed here recently. > > > > I did btrfs send btrfs_pool2/root_ro.date | btrfs receive /mnt/btrfs_pool1 > > > > Then btrfs

Re: send/receive and bedup

2014-05-18 Thread Marc MERLIN
On Wed, May 14, 2014 at 11:36:03PM +0800, Scott Middleton wrote: > I read so much about BtrFS that I mistaked Bedup with Duperemove. > Duperemove is actually what I am testing. I'm currently using programs that find files that are the same, and hardlink them together: http://marc.merlins.org/perso

problem with degraded boot and systemd

2014-05-18 Thread Chris Murphy
Summary: It's insufficient to pass rootflags=degraded to get the system root to mount when a device is missing. It looks like when a device is missing, udev doesn't create the dev-disk-by-uuid linkage that then causes systemd to change the device state from dead to plugged. Only once plugged, w

btrfs send ioctl failed with -5: Input/output error

2014-05-18 Thread Michael Welsh Duggan
I am now getting the following error when trying to do a btrfs send: root@maru2:/usr/local/src/btrfs-progs# ./btrfs send /usr/local/snapshots/2014-05-15 > /backup/intermediate At subvol /usr/local/snapshots/2014-05-15 ERROR: send ioctl failed with -5: Input/output error I'm running a 3.14.4 kern

Help with crash on mount issue

2014-05-18 Thread Ross Skaliotis
I filed a bug for null pointer dereferences I started hitting: https://bugzilla.kernel.org/show_bug.cgi?id=76451 Noticing qgroup in the trace, I tried disabling/re-enabling quota support for the filesystem. That turned out to be a mistake. Now as soon as I mount, I'm getting an oops thanks to btr

What do the "wait_current_trans" messages mean I see on my raspberry pi?

2014-05-18 Thread Clemens Eisserer
Hi, Over the weekend I tried to copy one external usb drive (on ext4) to another one formatted with btrfs. Now I came back, and 48h later only ~300GB were copied and I found messages like the following on syslog: May 16 18:33:13 raspberrypi kernel: [ 8161.213142] btrfs-endio-wri D c0420f24 0

Re: RAID-1 - suboptimal write performance?

2014-05-18 Thread Brendan Hide
On 2014/05/16 11:36 PM, Austin S Hemmelgarn wrote: On 05/16/2014 04:41 PM, Tomasz Chmielewski wrote: On Fri, 16 May 2014 14:06:24 -0400 Calvin Walton wrote: No comment on the performance issue, other than to say that I've seen similar on RAID-10 before, I think. Also, what happens when the

Re: Hang while deleting file

2014-05-18 Thread Chris Murphy
On May 18, 2014, at 10:36 AM, Joshua McKinney wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=76421 > > Perceived issue: SABNZBD hangs, requires restart. > Diagnosis shows the following in my system log at the time of hang. > This happens more than once. > Log: > > [ 5883.464766] INFO: ta

Hang while deleting file

2014-05-18 Thread Joshua McKinney
https://bugzilla.kernel.org/show_bug.cgi?id=76421 Perceived issue: SABNZBD hangs, requires restart. Diagnosis shows the following in my system log at the time of hang. This happens more than once. Log: [ 5883.464766] INFO: task SABnzbd.py:994 blocked for more than 120 seconds. [ 5883.464906]

Re: ditto blocks on ZFS

2014-05-18 Thread Russell Coker
On Sat, 17 May 2014 13:50:52 Martin wrote: > On 16/05/14 04:07, Russell Coker wrote: > > https://blogs.oracle.com/bill/entry/ditto_blocks_the_amazing_tape > > > > Probably most of you already know about this, but for those of you who > > haven't the above describes ZFS "ditto blocks" which is a go

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-18 Thread Brendan Hide
On 2014/05/18 02:05 PM, Hugo Mills wrote: On Sun, May 18, 2014 at 03:04:33PM +0800, Qu Wenruo wrote: I don't have any real suggestions for alternatives coming from my experience, other than "not this". I've used docbook for man pages briefly, many years ago. Looking around on the web, reStruc

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-18 Thread Hugo Mills
On Sun, May 18, 2014 at 03:04:33PM +0800, Qu Wenruo wrote: > > Original Message > Subject: Re: [PATCH 00/27] Replace the old man page with asciidoc and man > page for each btrfs subcommand. > From: Hugo Mills > To: dste...@suse.cz, Qu Wenruo , > linux-btrfs@vger.kernel.org, c...

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-18 Thread Hugo Mills
On Sun, May 18, 2014 at 02:51:39PM +0800, Qu Wenruo wrote: > > Original Message > Subject: Re: [PATCH 00/27] Replace the old man page with asciidoc and man > page for each btrfs subcommand. > From: Hugo Mills > To: dste...@suse.cz, Qu Wenruo , > linux-btrfs@vger.kernel.org, c...

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-18 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand. From: Hugo Mills To: dste...@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org, c...@fb.com Date: 2014年05月18日 02:22 On Sat, May 17, 2014 at 06:43:15PM