Re: [PATCH v3] lib: add size unit t/p/e to memparse

2014-06-12 Thread Hugo Mills
On Fri, Jun 13, 2014 at 07:54:44AM +0200, Brendan Hide wrote: > On 12/06/14 23:15, Andrew Morton wrote: > >On Wed, 2 Apr 2014 16:54:37 +0800 Gui Hecheng > >wrote: > >>+ * %K (for kibibytes, or 1024 bytes), > >>+ * %M (for mebibytes, or 1048576 bytes), > >>+ * %G (for gibibytes, or 1073741824 byte

Re: Deadlock/high load

2014-06-12 Thread Alin Dobre
On 13/06/14 04:37, Liu Bo wrote: > The output of 'btrfs filesystem df' is appreciate, it can help determine if > the > FS has entered into 'almost full' situation, and that may cause a bug that > pages > are not marked with writeback tag and lead to processes's endless waiting. The output now (w

Re: Deadlock/high load

2014-06-12 Thread Alin Dobre
On 13/06/14 04:37, Liu Bo wrote: > The output of 'btrfs filesystem df' is appreciate, it can help determine if > the > FS has entered into 'almost full' situation, and that may cause a bug that > pages > are not marked with writeback tag and lead to processes's endless waiting. I'll send it as s

Re: [PATCH v4] lib: add size unit t/p/e to memparse

2014-06-12 Thread Gui Hecheng
On Fri, 2014-06-13 at 07:55 +0200, Brendan Hide wrote: > On 13/06/14 03:42, Gui Hecheng wrote: > > For modern filesystems such as btrfs, t/p/e size level operations > > are common. > > add size unit t/p/e parsing to memparse > > > > Signed-off-by: Gui Hecheng > > --- > > changelog > > v1->v2:

Re: [PATCH v4] lib: add size unit t/p/e to memparse

2014-06-12 Thread Brendan Hide
On 13/06/14 03:42, Gui Hecheng wrote: For modern filesystems such as btrfs, t/p/e size level operations are common. add size unit t/p/e parsing to memparse Signed-off-by: Gui Hecheng --- changelog v1->v2: replace kilobyte with kibibyte, and others v2->v3: add missing unit "bytes

Re: [PATCH v3] lib: add size unit t/p/e to memparse

2014-06-12 Thread Brendan Hide
On 12/06/14 23:15, Andrew Morton wrote: On Wed, 2 Apr 2014 16:54:37 +0800 Gui Hecheng wrote: For modern filesystems such as btrfs, t/p/e size level operations are common. add size unit t/p/e parsing to memparse Signed-off-by: Gui Hecheng --- changelog v1->v2: replace kilobyte with ki

Re: [PATCH] btrfs: When devices with same dev uuid occurs, only add the one with largest generation.

2014-06-12 Thread Anand Jain
Qu, Kindly note, device->generation is not updated when user scan the device for the first time. I have sent out patch: [PATCH 2/2] btrfs: check generation as replace duplicates devid+uuid Please feel free to add your Signed-off-by, if you think so. review comments are appreciated as

[PATCH 1/2 v3 RESEND] Btrfs: device_list_add() should not update list when mounted

2014-06-12 Thread Anand Jain
From: Anand Jain device_list_add() is called when user runs btrfs dev scan, which would add any btrfs device into the btrfs_fs_devices list. Now think of a mounted btrfs. And a new device which contains the a SB from the mounted btrfs devices. In this situation when user runs btrfs dev scan, th

[PATCH 2/2] btrfs: check generation as replace duplicates devid+uuid

2014-06-12 Thread Anand Jain
From: Anand Jain When FS in unmounted we need to check generation number as well since devid+uuid combination could match with the missing replaced disk when it reappears, and without this patch it might pair with the replaced disk again. device_list_add() function is called in the following th

Re: Deadlock/high load

2014-06-12 Thread Liu Bo
On Thu, Jun 12, 2014 at 04:15:27PM +0100, Alin Dobre wrote: > Hi all, > > I have a problem that triggers quite often on our production machines. I > don't really know what's triggering this or how to reproduce it, but the > machine enters in some sort of deadlock state, where it consumes all the >

[PATCH v3] btrfs-progs: Improve the parse_size() error message.

2014-06-12 Thread Qu Wenruo
When using parse_size(), even non-numeric value is passed, it will only give error message "ERROR: size value is empty", which is quite confusing for end users. This patch will introduce more meaningful error message for the following new cases 1) Invalid size string (non-numeric string) 2) Minus

[PATCH v4] lib: add size unit t/p/e to memparse

2014-06-12 Thread Gui Hecheng
For modern filesystems such as btrfs, t/p/e size level operations are common. add size unit t/p/e parsing to memparse Signed-off-by: Gui Hecheng --- changelog v1->v2: replace kilobyte with kibibyte, and others v2->v3: add missing unit "bytes" in comment v3->v4: remove idio

Re: [PATCH v3] lib: add size unit t/p/e to memparse

2014-06-12 Thread Gui Hecheng
On Thu, 2014-06-12 at 14:15 -0700, Andrew Morton wrote: > On Wed, 2 Apr 2014 16:54:37 +0800 Gui Hecheng > wrote: > > > For modern filesystems such as btrfs, t/p/e size level operations > > are common. > > add size unit t/p/e parsing to memparse > > > > Signed-off-by: Gui Hecheng > > --- > > ch

Re: [PATCH v2] btrfs-progs: Improve the parse_size() error message.

2014-06-12 Thread Qu Wenruo
Original Message Subject: Re: [PATCH v2] btrfs-progs: Improve the parse_size() error message. From: David Sterba To: Qu Wenruo Date: 2014年06月12日 18:15 On Thu, May 29, 2014 at 09:42:11AM +0800, Qu Wenruo wrote: When using parse_size(), even non-numeric value is passed, it wil

Re: R: Re: Slow startup of systemd-journal on BTRFS

2014-06-12 Thread Dave Chinner
On Thu, Jun 12, 2014 at 12:37:13PM +, Duncan wrote: > Goffredo Baroncelli posted on Thu, 12 Jun 2014 > 13:13:26 +0200 as excerpted: > > >>systemd has a very stupid journal write pattern. It checks if there is > >>space in the file for the write, and if not it fallocates the small > >>amount o

[PATCH] Properly size the leafsize field in the mdrestore_struct struct.

2014-06-12 Thread Adam Buchbinder
It's 32 bits as defined in ctree.h, but the struct had it as 64 bits. Found using MemorySanitizer. Signed-off-by: Adam Buchbinder --- btrfs-image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/btrfs-image.c b/btrfs-image.c index cf1fe2d..98d765a 100644 --- a/btrfs-image.c

Re: [PATCH v3] lib: add size unit t/p/e to memparse

2014-06-12 Thread Andrew Morton
On Wed, 2 Apr 2014 16:54:37 +0800 Gui Hecheng wrote: > For modern filesystems such as btrfs, t/p/e size level operations > are common. > add size unit t/p/e parsing to memparse > > Signed-off-by: Gui Hecheng > --- > changelog > v1->v2: replace kilobyte with kibibyte, and others > v2

[PATCH] Use sparse files for filesystem conversion tests.

2014-06-12 Thread Adam Buchbinder
On my system, this brings the FS conversion test suite's runtime from over ten seconds down to under two. Thanks to Julien Muchembled for the suggestion. Signed-off-by: Adam Buchbinder --- tests/convert-tests.sh | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --g

Re: [PATCH] Btrfs: fix qgroups sanity test crash or hang

2014-06-12 Thread Filipe David Manana
On Thu, Jun 12, 2014 at 1:35 AM, Chris Mason wrote: > On 06/11/2014 08:12 PM, Filipe David Borba Manana wrote: >> Often when running the qgroups sanity test, a crash or a hang happened. >> This is because the extent buffer the test uses for the root node doesn't >> have an header level explicitly

Deadlock/high load

2014-06-12 Thread Alin Dobre
Hi all, I have a problem that triggers quite often on our production machines. I don't really know what's triggering this or how to reproduce it, but the machine enters in some sort of deadlock state, where it consumes all the i/o and the load average goes very high in seconds (it even gets to ove

Re: [PATCH V2] btrfs-progs: add mount options to btrfs-mount.5

2014-06-12 Thread Eric Sandeen
On 6/12/14, 5:51 AM, David Sterba wrote: > On Wed, Jun 11, 2014 at 05:14:55PM -0500, Eric Sandeen wrote: >> This is a straight cut and paste from the util-linux >> mount manpage into btrfs-mount.5 >> >> It's pretty much impossible for util-linux to keep up >> with every filesystem out there, and Ka

Re: R: Re: Slow startup of systemd-journal on BTRFS

2014-06-12 Thread Duncan
Goffredo Baroncelli posted on Thu, 12 Jun 2014 13:13:26 +0200 as excerpted: >>systemd has a very stupid journal write pattern. It checks if there is >>space in the file for the write, and if not it fallocates the small >>amount of space it needs (it does *4 byte* fallocate calls!) and then >>does

R: Re: Slow startup of systemd-journal on BTRFS

2014-06-12 Thread Goffredo Baroncelli
>Da: da...@fromorbit.com >Data: 12/06/2014 3.21 >A: >Cc: "systemd Mailing List", "linux-btrfs" >Ogg: Re: Slow startup of systemd-journal on BTRFS > >On Wed, Jun 11, 2014 at 11:28:54PM +0200, Goffredo Baroncelli wrote: >> Hi all, >> >> I would like to share a my experience about a slowness of sys

R: Re: Slow startup of systemd-journal on BTRFS

2014-06-12 Thread Goffredo Baroncelli
>Messaggio originale >Da: russ...@coker.com.au >Data: 12/06/2014 3.18 >A: >Cc: "systemd Mailing List", "linux-btrfs" >Ogg: Re: Slow startup of systemd-journal on BTRFS > >On Wed, 11 Jun 2014 23:28:54 Goffredo Baroncelli wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=10063

R: Re: Slow startup of systemd-journal on BTRFS

2014-06-12 Thread Goffredo Baroncelli
>Messaggio originale >Da: li...@colorremedies.com >Data: 12/06/2014 2.40 >A: , "Goffredo Baroncelli" >Cc: "systemd Mailing List", "linux-btrfs" >Ogg: Re: Slow startup of systemd-journal on BTRFS > > >On Jun 11, 2014, at 3:28 PM, Goffredo Baroncelli wrote: >> >> If someone is able to su

Re: [PATCH V2] btrfs-progs: add mount options to btrfs-mount.5

2014-06-12 Thread David Sterba
On Wed, Jun 11, 2014 at 05:14:55PM -0500, Eric Sandeen wrote: > This is a straight cut and paste from the util-linux > mount manpage into btrfs-mount.5 > > It's pretty much impossible for util-linux to keep up > with every filesystem out there, and Karel has more than > once expressed a wish that

Re: [PATCH v2] btrfs-progs: Improve the parse_size() error message.

2014-06-12 Thread David Sterba
On Thu, May 29, 2014 at 09:42:11AM +0800, Qu Wenruo wrote: > When using parse_size(), even non-numeric value is passed, it will only > give error message "ERROR: size value is empty", which is quite > confusing for end users. > > This patch will introduce more meaningful error message for the > fo

Re: [PATCH] btrfs-progs: make pretty Documentation/ build match the rest

2014-06-12 Thread David Sterba
On Fri, May 30, 2014 at 11:27:14AM -0500, Eric Sandeen wrote: > This is the most important patch ever. ;) Oh it is :) > I found this to be less aesthetically pleasing than it was before: > > [CC] btrfstune.o > Making all in Documentation > ASCIIDOC btrfs-convert.xml > [LD]

Re: [PATCH] Add some simple end-to-end tests for btrfs-convert.

2014-06-12 Thread David Sterba
On Fri, May 30, 2014 at 08:26:02PM +0200, Julien Muchembled wrote: > Le 05/21/14 19:20, Adam Buchbinder a écrit : > > + # 256MB is the smallest acceptable btrfs image. > > + dd if=/dev/zero of=$here/test.img bs=1024 count=$((256*1024)) \ > > + >> convert-tests-results.txt 2>&1 || _fai

Re: [PATCH 0/8] Add support for LZ4 compression

2014-06-12 Thread David Sterba
On Wed, Jun 04, 2014 at 10:00:06AM -0400, Chris Mason wrote: > I have a slightly different reason for holding off on these. Disk > format changes are forever, and we need a really strong use case for > pulling them in. The format upgrade is inevitable for full bidirectional interoperability of fi

[PATCH v2 1/3] btrfs-progs: fix missing parity stripe for raid6 in chunk-recover

2014-06-12 Thread Gui Hecheng
When deal with the p & q stripes for data profile raid6, chunk-recover forgets to insert them into the chunk record. Just insert them back freely. Also wrap the insert procedure into a new function, fill_chunk_up. Signed-off-by: Gui Hecheng --- changelog: v1->v2: cleanup changelog, 'inert

Re: [PATCH 1/3] btrfs-progs: fix missing parity stripe for raid6 in chunk-recover

2014-06-12 Thread Gui Hecheng
On Thu, 2014-06-12 at 07:45 +, Duncan wrote: > Gui Hecheng posted on Thu, 12 Jun 2014 10:24:59 +0800 as excerpted: > > > When deal with the p & q stripes for data profile raid6, chunk-recover > > forgets to insert them into the chunk record. Just insert them back > > freely. > > Also wrap the

Re: [PATCH 1/3] btrfs-progs: fix missing parity stripe for raid6 in chunk-recover

2014-06-12 Thread Duncan
Gui Hecheng posted on Thu, 12 Jun 2014 10:24:59 +0800 as excerpted: > When deal with the p & q stripes for data profile raid6, chunk-recover > forgets to insert them into the chunk record. Just insert them back > freely. > Also wrap the inert procedure into a new function, fill_chunk_up. If there

[PATCH v2 2/2] btrfs-progs: Add human readable flags output for chunk/block group type.

2014-06-12 Thread Qu Wenruo
Current btrfs-debug-tree output chunk/block group type as numbers, which makes it hard to understand and need to check the source to understand the meaning. This patch will convert numberic type output to human readable strings. Signed-off-by: Qu Wenruo --- changlog: v2: allow mixed chunk. ---

[PATCH v2 1/2] btrfs-progs: Add human readable flags output string for extent flags.

2014-06-12 Thread Qu Wenruo
Current btrfs-debug-tree outputs extent flags as numbers, which makes it hard to understand and need to check the source to understand the meaning. This patch will convert numberic flags output to human readable strings. Signed-off-by: Qu Wenruo --- changlog: v2: none --- print-tree.c | 25