Hi Gui,
(2014/07/17 11:40), Gui Hecheng wrote:
o Return 0 to indicate success,
when detected errors were corrected during scrubbing.
P.s. This is also to facilitate scripting when return value
is to be checked.
o Warn the users if there are uncorrectable errors detected.
Hi Gui,
(2014/07/17 11:40), Gui Hecheng wrote:
The scrub_read_file function is always on a branch,
which has (fd = 0), so there is not need to judgment
the pasted in arg.
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
cmds-scrub.c | 3 ---
1 file changed, 3 deletions(-)
Hi Gui,
(2014/07/30 14:39), Gui Hecheng wrote:
On Wed, 2014-07-30 at 14:20 +0900, Satoru Takeuchi wrote:
Hi Gui,
(2014/07/17 11:40), Gui Hecheng wrote:
The -f option of scrub means to skip checking running scrub,
not to force checking.
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
Hi Gui,
(2014/07/30 15:03), Satoru Takeuchi wrote:
Hi Gui,
(2014/07/17 11:40), Gui Hecheng wrote:
o Return 0 to indicate success,
when detected errors were corrected during scrubbing.
P.s. This is also to facilitate scripting when return value
is to be checked.
o Warn
On 30 July 2014 04:25, Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com wrote:
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
There are many duplicated codes to check if the given string is
correct subvolume name. Introduce test_issubvolname() for this
purpose for simplicity.
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
If get_df() returns 0, sargs surely points to malloc'ed region.
So NULL check of sargs is not necessary.
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
cmds-filesystem.c | 2 +-
1 file changed, 1 insertion(+), 1
Hi Satoru, I just give a reply to the former 2 mails together here.
On Wed, 2014-07-30 at 15:36 +0900, Satoru Takeuchi wrote:
Hi Gui,
(2014/07/30 15:03), Satoru Takeuchi wrote:
Hi Gui,
(2014/07/17 11:40), Gui Hecheng wrote:
o Return 0 to indicate success,
when detected errors
The -f option of scrub means to
force starting new scrub even if a scrub is already running
*not*
force to check whether scrub has started or resumed in userspace
as described originally.
So replace the orignal description in the manpage and code.
Also, add description of the potential
On Fri, 25 Jul 2014 20:33:34 +0800, Anand Jain wrote:
After the seed device has been replaced the new target device
is no more a seed device. So we need to bring that state in
the fs_devices.
reproducer:
mount /dev/sdb /btrfs
btrfs dev add /dev/sdc /btrfs
btrfs rep start -B /dev/sdb
On Tue, Jul 29, 2014 at 11:54:20PM -0400, Nick Krause wrote:
Hey Guys ,
I am new to reading and writing kernel code.I got interested in
writing code for btrfs as it seems to
need more work then other file systems and this seems other then
drivers, a good use of time on my part.
I
At Mon, 28 Jul 2014 16:01:55 +0200,
Takashi Iwai wrote:
At Mon, 28 Jul 2014 15:48:41 +0200,
Takashi Iwai wrote:
At Mon, 28 Jul 2014 09:16:48 -0400,
Josef Bacik wrote:
On 07/28/2014 04:57 AM, Takashi Iwai wrote:
We've got bug reports that btrfs crashes when quota is enabled on
The crashes became more frequent. The time scale before lockup went
~12 days, ~7 days, ~2 days, ~6 hours, ~1 hour.
Then we upgraded to 3.15.7-031507-generic on the advice of
#ubuntu-kernel and #btrfs on IRC, and it has since been stable for
19.5 hours.
I dug around more in our logs and realised
Gui Hecheng posted on Wed, 30 Jul 2014 15:32:05 +0800 as excerpted:
Also, add description of the potential failure as follows
If a scrub is already running running, it fails.
Just a typo (running running?) in the description...
--
Duncan - List replies preferred. No HTML msgs.
Every
On 23.07.2014 22:56, David Sterba wrote:
Enhance the 'subvolume' subcommand to wait until a given list of
subvolumes or all currently scheduled for deletion are cleaned[…]
'wait' seemed too generic, 'sync' is not completely accurate but IMHO better,
I'm open to other suggestions
'receipt'
Not sure how this escaped many eyes so far
Signed-off-by: Anand Jain anand.j...@oracle.com
---
fs/btrfs/sysfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index 266e201..e815ab2 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -377,6 +377,9
All that uses BTRFS_ATTR want mode to be set at 0444 so just do
it at the define. And few spacing alignments.
Signed-off-by: Anand Jain anand.j...@oracle.com
---
fs/btrfs/sysfs.c | 14 +++---
fs/btrfs/sysfs.h | 11 +++
2 files changed, 14 insertions(+), 11 deletions(-)
diff
BTRFS_ATTR_RW could set the mode and be inline with BTRFS_ATTR
Signed-off-by: Anand Jain anand.j...@oracle.com
---
fs/btrfs/sysfs.c | 2 +-
fs/btrfs/sysfs.h | 7 ---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index 0524684..266e201
we have BTRFS_ATTR define to create sysfs RO file, use that.
Signed-off-by: Anand Jain anand.j...@oracle.com
---
fs/btrfs/sysfs.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index d9c3ec6..404ad66 100644
---
On Wed, 23 Jul 2014 22:56:13 +0200
David Sterba dste...@suse.cz wrote:
Enhance the 'subvolume' subcommand to wait until a given list of
subvolumes or all currently scheduled for deletion are cleaned
completely from the filesystem.
Signed-off-by: David Sterba dste...@suse.cz
---
'wait'
On Wed, Jul 30, 2014 at 10:38:21AM +0100, Hugo Mills wrote:
qemu/kvm is good for this, because it has a mode
that bypasses the BIOS and bootloader emulation, and just directly
runs a kernel from a file on the host machine. This is fast. You can
pass large sparse files to the VM to act as
On 07/30/2014 05:57 AM, Takashi Iwai wrote:
At Mon, 28 Jul 2014 16:01:55 +0200,
Takashi Iwai wrote:
At Mon, 28 Jul 2014 15:48:41 +0200,
Takashi Iwai wrote:
At Mon, 28 Jul 2014 09:16:48 -0400,
Josef Bacik wrote:
On 07/28/2014 04:57 AM, Takashi Iwai wrote:
We've got bug reports that btrfs
At Wed, 30 Jul 2014 10:29:46 -0400,
Josef Bacik wrote:
On 07/30/2014 05:57 AM, Takashi Iwai wrote:
At Mon, 28 Jul 2014 16:01:55 +0200,
Takashi Iwai wrote:
At Mon, 28 Jul 2014 15:48:41 +0200,
Takashi Iwai wrote:
At Mon, 28 Jul 2014 09:16:48 -0400,
Josef Bacik wrote:
On
At Wed, 30 Jul 2014 17:01:52 +0200,
Takashi Iwai wrote:
At Wed, 30 Jul 2014 10:29:46 -0400,
Josef Bacik wrote:
On 07/30/2014 05:57 AM, Takashi Iwai wrote:
At Mon, 28 Jul 2014 16:01:55 +0200,
Takashi Iwai wrote:
At Mon, 28 Jul 2014 15:48:41 +0200,
Takashi Iwai wrote:
On 07/30/2014 10:13 AM, Theodore Ts'o wrote:
On Wed, Jul 30, 2014 at 10:38:21AM +0100, Hugo Mills wrote:
qemu/kvm is good for this, because it has a mode
that bypasses the BIOS and bootloader emulation, and just directly
runs a kernel from a file on the host machine. This is fast. You can
On Tue, Jul 29, 2014 at 11:54:20PM -0400, Nick Krause wrote:
Hey Guys ,
I interested in helping improving the compression of btrfs by using a
set of threads using work queues like XFS
or reads and keeping the page cache after reading compressed blocks as
these seem to be a great way to
On 07/30/2014 11:05 AM, Takashi Iwai wrote:
At Wed, 30 Jul 2014 17:01:52 +0200,
Takashi Iwai wrote:
At Wed, 30 Jul 2014 10:29:46 -0400,
Josef Bacik wrote:
On 07/30/2014 05:57 AM, Takashi Iwai wrote:
At Mon, 28 Jul 2014 16:01:55 +0200,
Takashi Iwai wrote:
At Mon, 28 Jul 2014 15:48:41
At Wed, 30 Jul 2014 11:40:14 -0400,
Josef Bacik wrote:
On 07/30/2014 11:05 AM, Takashi Iwai wrote:
At Wed, 30 Jul 2014 17:01:52 +0200,
Takashi Iwai wrote:
At Wed, 30 Jul 2014 10:29:46 -0400,
Josef Bacik wrote:
On 07/30/2014 05:57 AM, Takashi Iwai wrote:
At Mon, 28 Jul 2014
On Wed, Jul 30, 2014 at 11:58:37AM +0900, Satoru Takeuchi wrote:
Hi David,
(2014/07/29 22:32), David Sterba wrote:
On Fri, Jul 25, 2014 at 03:16:58PM +0900, Satoru Takeuchi wrote:
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
There are many duplicated codes to check if the given
On 07/30/2014 11:52 AM, Takashi Iwai wrote:
At Wed, 30 Jul 2014 11:40:14 -0400,
Josef Bacik wrote:
On 07/30/2014 11:05 AM, Takashi Iwai wrote:
At Wed, 30 Jul 2014 17:01:52 +0200,
Takashi Iwai wrote:
At Wed, 30 Jul 2014 10:29:46 -0400,
Josef Bacik wrote:
On 07/30/2014 05:57 AM, Takashi
At Wed, 30 Jul 2014 12:01:31 -0400,
Josef Bacik wrote:
On 07/30/2014 11:52 AM, Takashi Iwai wrote:
At Wed, 30 Jul 2014 11:40:14 -0400,
Josef Bacik wrote:
On 07/30/2014 11:05 AM, Takashi Iwai wrote:
At Wed, 30 Jul 2014 17:01:52 +0200,
Takashi Iwai wrote:
At Wed, 30 Jul 2014
We've got bug reports that btrfs crashes when quota is enabled on
32bit kernel, typically with the Oops like below:
BUG: unable to handle kernel NULL pointer dereference at 0004
IP: [f9234590] find_parent_nodes+0x360/0x1380 [btrfs]
*pde =
Oops: [#1] SMP
CPU: 0 PID: 151 Comm:
These macros are no longer used after replacements of aux data type.
Let's kill them.
Signed-off-by: Takashi Iwai ti...@suse.de
---
fs/btrfs/qgroup.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index b499f580d005..dc2665cb3f1b 100644
---
On 07/30/2014 12:35 PM, Takashi Iwai wrote:
At Wed, 30 Jul 2014 12:01:31 -0400,
Josef Bacik wrote:
On 07/30/2014 11:52 AM, Takashi Iwai wrote:
At Wed, 30 Jul 2014 11:40:14 -0400,
Josef Bacik wrote:
On 07/30/2014 11:05 AM, Takashi Iwai wrote:
At Wed, 30 Jul 2014 17:01:52 +0200,
Takashi Iwai
Add a new member to fiemap_extent that represents the physical extent
length. This value is undefined if the flag EXTENT_PHYS_LENGTH is not
set.
No functional change to existing fiemap users.
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/extent_io.c| 2 +-
fs/ext4/extents.c
Compressed extents set the physical length and the corresponging extent
flags.
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/extent_io.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index
The original FIEMAP patch did not define the bits, btrfs would like to use a
flag for compressed extents. The PHYS_LENGTH flag emerged during patchset
revisions to keep backward compatibility and flexible fiemap API.
Currently, the 'filefrag' utility has no way to recognize and denote a
On Wed, Jul 30, 2014 at 11:36 AM, ashf...@whisperpc.com wrote:
On Tue, Jul 29, 2014 at 11:54:20PM -0400, Nick Krause wrote:
Hey Guys ,
I interested in helping improving the compression of btrfs by using a
set of threads using work queues like XFS
or reads and keeping the page cache after
At Wed, 30 Jul 2014 13:00:24 -0400,
Josef Bacik wrote:
On 07/30/2014 12:35 PM, Takashi Iwai wrote:
At Wed, 30 Jul 2014 12:01:31 -0400,
Josef Bacik wrote:
On 07/30/2014 11:52 AM, Takashi Iwai wrote:
At Wed, 30 Jul 2014 11:40:14 -0400,
Josef Bacik wrote:
On 07/30/2014 11:05 AM,
Since all users of ulist_add() and ulist_add_merge() pass the pointer
of objects to aux, replace the aux data type itself to void pointer,
so that the caller can pass without ugly int/pointer casts.
Along with the replacements, kill u64/ptr conversion macros and
ulist_add_merge_ptr() wrapper
Thanks for the feedback, appreciated.
On Wed, Jul 30, 2014 at 05:55:19PM +0600, Roman Mamedov wrote:
+static const char * const cmd_subvol_sync_usage[] = {
+ btrfs subvolume sync path [subvol-id...],
+ Wait until given subvolume(s) are completely cleaned,
+ Wait until given
Nick,
On Wed, Jul 30, 2014 at 11:36 AM, ashf...@whisperpc.com wrote:
On Tue, Jul 29, 2014 at 11:54:20PM -0400, Nick Krause wrote:
Hey Guys ,
I interested in helping improving the compression of btrfs by using a
set of threads using work queues like XFS
or reads and keeping the page cache
On Wed, Jul 30, 2014 at 2:31 PM, ashf...@whisperpc.com wrote:
Nick,
On Wed, Jul 30, 2014 at 11:36 AM, ashf...@whisperpc.com wrote:
On Tue, Jul 29, 2014 at 11:54:20PM -0400, Nick Krause wrote:
Hey Guys ,
I interested in helping improving the compression of btrfs by using a
set of threads
On Jul 30, 2014, at 11:18 AM, David Sterba dste...@suse.cz wrote:
Add a new member to fiemap_extent that represents the physical extent
length. This value is undefined if the flag EXTENT_PHYS_LENGTH is not
set.
The description here of PHYS_LENGTH makes sense...
The patch description should
This patch removes the lines for releasing the page cache in certain
files as this may aid in perfomance with writes in the compression
rountines of btrfs. Please note that this patch has not been tested
on my own hardware due to no compression based btrfs volumes of my
own.
Signed-off-by:
On 07/30/2014 04:42 PM, Nicholas Krause wrote:
This patch removes the lines for releasing the page cache in certain
files as this may aid in perfomance with writes in the compression
rountines of btrfs. Please note that this patch has not been tested
on my own hardware due to no compression
On Wed, Jul 30, 2014 at 04:47:12PM -0400, Josef Bacik wrote:
On 07/30/2014 04:42 PM, Nicholas Krause wrote:
This patch removes the lines for releasing the page cache in certain
files as this may aid in perfomance with writes in the compression
rountines of btrfs. Please note that this patch
Concerning http://thread.gmane.org/gmane.comp.file-systems.btrfs/31018, does
this bug still exists?
Kernel 3.14
B: 2x HDD 1 TB
C: 1x SSD 256 GB
# make-bcache -B /dev/sda /dev/sdb -C /dev/sdc --cache_replacement_policy=lru
# mkfs.btrfs -d raid1 -m raid1 -L BTRFS_RAID /dev/bcache0 /dev/bcache1
I
On Wed, Jul 30, 2014 at 4:51 PM, Zach Brown z...@zabbo.net wrote:
On Wed, Jul 30, 2014 at 04:47:12PM -0400, Josef Bacik wrote:
On 07/30/2014 04:42 PM, Nicholas Krause wrote:
This patch removes the lines for releasing the page cache in certain
files as this may aid in perfomance with writes in
I've been running two backup servers, with 25T and 20T of data, using
btrfs on bcache (writeback) for about 7 months. I periodically run btrfs
scrubs and backup verifies (SHA1 hashes) and have never had a corruption
issue.
My use of btrfs is simple, though, with no subvolumes and no btrfs level
So I'm going to list all the things that are wrong with this in the off chance
that you will actually improve and then go back to ignoring your emails.
1) You test your patches before you send them. Xfstests is how you test.
2) You seem to think page_cache_release releases the page cache. It
This patch removes the lines for releasing the page cache in certain
files as this may aid in perfomance with writes in the compression
rountines of btrfs. Please note that this patch has not been tested
on my own hardware due to no compression based btrfs volumes of my
own.
For all that is
On Wed, 2014-07-30 at 10:26 +, Duncan wrote:
Gui Hecheng posted on Wed, 30 Jul 2014 15:32:05 +0800 as excerpted:
Also, add description of the potential failure as follows
If a scrub is already running running, it fails.
Just a typo (running running?) in the description...
Hmmm,
The -f option of scrub means to
force starting new scrub even if a scrub is already running
*not*
force to check whether scrub has started or resumed in userspace
as described originally.
So replace the orignal description in the manpage and code.
Also, add description of the potential
On Wed, Jul 30, 2014 at 7:30 PM, Dave Airlie airl...@gmail.com wrote:
This patch removes the lines for releasing the page cache in certain
files as this may aid in perfomance with writes in the compression
rountines of btrfs. Please note that this patch has not been tested
on my own hardware
The local variable @object etc. in btrfs-property get/set functions
are to be checked whether to be NULL or not, but the @parse_args()
don't guarantee to assign a value to it, so it is better to init
it to NULL.
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
cmds-property.c | 8
The function @parse_prop() returns either -1 or 0, no need to check
for other values. Just return the unnecessary check.
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
cmds-property.c | 4
1 file changed, 4 deletions(-)
diff --git a/cmds-property.c b/cmds-property.c
index
The function @is_existing_blk_or_reg_file has a return value of -errno,
which indicate the @stat call fails with non-ENOENT errors.
In this condition, we should not continue the following work.
But -errno evaluates to true and will let the following work go.
So we should judge more accurately
Hi David,
No mean to disturb you, but it has been serveral days since last comment.
If you have any comment about the new patch, since due to my lack of
explain the patch seems not
reviewed, I am very glad to hear.
If any other ideas occur to you, like the pro and cons about old mount
trick
On 31 July 2014 12:05, Nick Krause xerofo...@gmail.com wrote:
On Wed, Jul 30, 2014 at 7:30 PM, Dave Airlie airl...@gmail.com wrote:
This patch removes the lines for releasing the page cache in certain
files as this may aid in perfomance with writes in the compression
rountines of btrfs. Please
On Wed, Jul 30, 2014 at 11:57 PM, Dave Airlie airl...@gmail.com wrote:
On 31 July 2014 12:05, Nick Krause xerofo...@gmail.com wrote:
On Wed, Jul 30, 2014 at 7:30 PM, Dave Airlie airl...@gmail.com wrote:
This patch removes the lines for releasing the page cache in certain
files as this may aid
Hey guys,
First thing is thanks a lot for the help , considering how busy some
of you are. I am interested in the project with extent_io as it seems
a good
place to start before my other project idea in order to get used to
coding for btrfs. I am wondering through as the project definition is
very
Nick Krause posted on Thu, 31 Jul 2014 00:14:50 -0400 as excerpted:
I am wondering if some one can
give me a pointer on where to download the git repos for the btrfs user
spaces tools as it seems on the btrfs tools on the wiki.
62 matches
Mail list logo
