Before this patch, check_tree_block() will print error on bytenr
mismatch but don't output error on fsid mismatch.
This patch will modify check_tree_block(), so it will only return errno
but not print error messages.
The error message will be output by print_tree_block_err() function.
Add new open ctree flag OPEN_CTREE_SUPPRESS_ERROR to suppress tree block
csum error output.
Provides the basis for new btrfs-find-root and other enhancement on
btrfs offline tools output.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
---
changelog:
v2:
None
v3:
Use 'suppress_tree_error'
On Thu, 29 Jan 2015 01:44:02 +, Steven Schlansker wrote:
[..snip..]
The symptoms are an endlessly increasing stream of hung tasks and high
Please try 3.18.5 (-rc1 is good) which contains the following fix:
workqueue: fix subtle pool management issue which can stall whole
worker_pool
On Wed, Jan 28, 2015 at 08:04:39PM +0300, Pavel Volkov wrote:
In my 3.18.3 sources the file at Documentation/filesystems/btrfs.txt says:
Btrfs is under heavy development, and is not suitable for
any uses other than benchmarking and review. The Btrfs disk format is
not yet finalized.
btrfs
On Thu, Jan 29, 2015 at 01:37:58PM +0100, David Sterba wrote:
Adding Al Viro into CC
On Thu, Jan 29, 2015 at 10:24:39AM +0800, Qu Wenruo wrote:
+struct vfsmount *get_vfsmount_sb(struct super_block *sb)
+{
+ struct vfsmount *ret_vfs = NULL;
+ struct mount *mnt;
+ int ret = 0;
Adding Al Viro into CC
On Thu, Jan 29, 2015 at 10:24:39AM +0800, Qu Wenruo wrote:
+struct vfsmount *get_vfsmount_sb(struct super_block *sb)
+{
+ struct vfsmount *ret_vfs = NULL;
+ struct mount *mnt;
+ int ret = 0;
+
+ lock_mount_hash();
+ if (list_empty(sb-s_mounts))
Committing a transaction can race with automatic removal of empty block
groups (cleaner kthread), leading to a BUG_ON() in the transaction
commit code while running btrfs_finish_extent_commit(). The following
sequence diagram shows how it can happen:
CPU 1
Original Message
Subject: Re: [PATCH RESEND v4 6/8] vfs: Add get_vfsmount_sb() function
to get vfsmount from a given sb.
From: Al Viro v...@zeniv.linux.org.uk
To: dste...@suse.cz, Qu Wenruo quwen...@cn.fujitsu.com,
linux-btrfs@vger.kernel.org, linux-fsdevel
On Fri, 30 Jan 2015 09:33:17 +0800, Qu Wenruo wrote:
Original Message
Subject: Re: [PATCH RESEND v4 2/8] btrfs: Make btrfs_parse_options() parse
mount
option in a atomic way
From: Miao Xie miao...@huawei.com
To: Qu Wenruo quwen...@cn.fujitsu.com,
On Fri, Jan 30, 2015 at 09:44:03AM +0800, Qu Wenruo wrote:
This shouldn't happen. If someone is ro, the whole fs should be ro, right?
Wrong. Individual vfsmounts over an r/w superblock might very well be r/o.
As for that trylock... What for? It invites transient failures for no
good reason.
On Thu, 29 Jan 2015 10:24:35 +0800, Qu Wenruo wrote:
Current btrfs_parse_options() is not atomic, which can set and clear a
bit, especially for nospace_cache case.
For example, if a fs is mounted with nospace_cache,
btrfs_parse_options() will set SPACE_CACHE bit first(since
cache_generation
Original Message
Subject: Re: [PATCH RESEND v4 2/8] btrfs: Make btrfs_parse_options()
parse mount option in a atomic way
From: Miao Xie miao...@huawei.com
To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org
Date: 2015年01月30日 08:31
On Thu, 29 Jan 2015 10:24:35
Original Message
Subject: Re: [PATCH RESEND v4 6/8] vfs: Add get_vfsmount_sb() function
to get vfsmount from a given sb.
From: Al Viro v...@zeniv.linux.org.uk
To: Qu Wenruo quwen...@cn.fujitsu.com
Date: 2015年01月30日 10:09
On Fri, Jan 30, 2015 at 09:11:26AM +0800, Qu Wenruo
Original Message
Subject: Re: [PATCH RESEND v4 2/8] btrfs: Make btrfs_parse_options()
parse mount option in a atomic way
From: Miao Xie miao...@huawei.com
To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org
Date: 2015年01月30日 09:29
On Fri, 30 Jan 2015 09:20:46
Hi Holger,
On Jan 29, 2015, at 2:08 AM, Holger Hoffstätte
holger.hoffstae...@googlemail.com wrote:
[This mail was also posted to gmane.comp.file-systems.btrfs.]
On Thu, 29 Jan 2015 01:44:02 +, Steven Schlansker wrote:
[..snip..]
The symptoms are an endlessly increasing stream of
Original Message
Subject: Re: [PATCH RESEND v4 6/8] vfs: Add get_vfsmount_sb() function
to get vfsmount from a given sb.
From: Qu Wenruo quwen...@cn.fujitsu.com
To: Miao Xie miao...@huawei.com, linux-btrfs@vger.kernel.org
Date: 2015年01月30日 09:44
Original Message
On Fri, Jan 30, 2015 at 09:11:26AM +0800, Qu Wenruo wrote:
For the mounted ro case, that's not a problem, since if one instance
is mounted ro,
other instances are also mounted ro, so that's not a problem.
Not really.
root@satch:~# cd /tmp/
root@satch:~# mkdir /tm/a
root@satch:~# mount --bind
Original Message
Subject: Re: [PATCH RESEND v4 6/8] vfs: Add get_vfsmount_sb() function
to get vfsmount from a given sb.
From: Miao Xie miao...@huawei.com
To: Al Viro v...@zeniv.linux.org.uk, Qu Wenruo quwen...@cn.fujitsu.com
Date: 2015年01月30日 12:14
On Fri, 30 Jan 2015
Original Message
Subject: Re: [PATCH RESEND v4 2/8] btrfs: Make btrfs_parse_options()
parse mount option in a atomic way
From: Miao Xie miao...@huawei.com
To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org
Date: 2015年01月30日 10:06
On Fri, 30 Jan 2015 09:33:17
On Fri, 30 Jan 2015 10:51:52 +0800, Qu Wenruo wrote:
Original Message
Subject: Re: [PATCH RESEND v4 2/8] btrfs: Make btrfs_parse_options() parse
mount
option in a atomic way
From: Miao Xie miao...@huawei.com
To: Qu Wenruo quwen...@cn.fujitsu.com,
On Fri, Jan 30, 2015 at 12:14:24PM +0800, Miao Xie wrote:
On Fri, 30 Jan 2015 02:14:45 +, Al Viro wrote:
On Fri, Jan 30, 2015 at 09:44:03AM +0800, Qu Wenruo wrote:
This shouldn't happen. If someone is ro, the whole fs should be ro, right?
Wrong. Individual vfsmounts over an r/w
On Fri, 30 Jan 2015 04:37:14 +, Al Viro wrote:
On Fri, Jan 30, 2015 at 12:14:24PM +0800, Miao Xie wrote:
On Fri, 30 Jan 2015 02:14:45 +, Al Viro wrote:
On Fri, Jan 30, 2015 at 09:44:03AM +0800, Qu Wenruo wrote:
This shouldn't happen. If someone is ro, the whole fs should be ro, right?
Original Message
Subject: Re: [PATCH RESEND v4 2/8] btrfs: Make btrfs_parse_options()
parse mount option in a atomic way
From: Miao Xie miao...@huawei.com
To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org
Date: 2015年01月30日 11:21
On Fri, 30 Jan 2015 10:51:52
On Fri, 30 Jan 2015 10:02:26 +0800, Qu Wenruo wrote:
Original Message
Subject: Re: [PATCH RESEND v4 6/8] vfs: Add get_vfsmount_sb() function to get
vfsmount from a given sb.
From: Qu Wenruo quwen...@cn.fujitsu.com
To: Miao Xie miao...@huawei.com,
On Fri, 30 Jan 2015 02:14:45 +, Al Viro wrote:
On Fri, Jan 30, 2015 at 09:44:03AM +0800, Qu Wenruo wrote:
This shouldn't happen. If someone is ro, the whole fs should be ro, right?
Wrong. Individual vfsmounts over an r/w superblock might very well be r/o.
As for that trylock... What
On Fri, Jan 30, 2015 at 01:34:41PM +0800, Miao Xie wrote:
First of all, -s_umount is not a mutex; it's rwsem. So you mean
down_read_trylock(). As for the transient failures - grep for down_write
on it... E.g. have somebody call mount() from the same device. We call
sget(), which
On Thu, 29 Jan 2015 10:24:39 +0800, Qu Wenruo wrote:
There are sysfs interfaces in some fs, only btrfs yet, which will modify
on-disk data.
Unlike normal file operation routine we can use mnt_want_write_file() to
protect the operation, change through sysfs won't to be binded to any file
in
Original Message
Subject: Re: [PATCH RESEND v4 6/8] vfs: Add get_vfsmount_sb() function
to get vfsmount from a given sb.
From: Miao Xie miao...@huawei.com
To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org
Date: 2015年01月30日 08:52
On Thu, 29 Jan 2015 10:24:39
28 matches
Mail list logo
